In password generation prompt and in password confirmation bubble links should go to passwords.google.com not to chrome://settings/passwords as now.
Links "Google saved passwords" on both screenshots should go to passwords.google.com
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/99d21fffc7976a075b6351db541b203c750926cb commit 99d21fffc7976a075b6351db541b203c750926cb Author: dvadym <dvadym@chromium.org> Date: Mon Feb 27 10:30:33 2017 Links in generation prompts should go to passwords.google.com. Screenshots for more context are on the bug https://bugs.chromium.org/p/chromium/issues/detail?id=695468#c1 This CL covers all Desktop except Mac, Mac implementation will be in separate CL. BUG= 695468 Review-Url: https://codereview.chromium.org/2711563006 Cr-Commit-Position: refs/heads/master@{#453180} [modify] https://crrev.com/99d21fffc7976a075b6351db541b203c750926cb/chrome/browser/ui/autofill/password_generation_popup_controller_impl.cc [modify] https://crrev.com/99d21fffc7976a075b6351db541b203c750926cb/chrome/browser/ui/passwords/manage_passwords_bubble_model.cc [modify] https://crrev.com/99d21fffc7976a075b6351db541b203c750926cb/chrome/browser/ui/passwords/manage_passwords_bubble_model.h [modify] https://crrev.com/99d21fffc7976a075b6351db541b203c750926cb/chrome/browser/ui/passwords/manage_passwords_ui_controller.cc [modify] https://crrev.com/99d21fffc7976a075b6351db541b203c750926cb/chrome/browser/ui/passwords/manage_passwords_ui_controller.h [modify] https://crrev.com/99d21fffc7976a075b6351db541b203c750926cb/chrome/browser/ui/passwords/passwords_model_delegate.h [modify] https://crrev.com/99d21fffc7976a075b6351db541b203c750926cb/chrome/browser/ui/passwords/passwords_model_delegate_mock.h [modify] https://crrev.com/99d21fffc7976a075b6351db541b203c750926cb/chrome/browser/ui/views/passwords/manage_passwords_bubble_view.cc [modify] https://crrev.com/99d21fffc7976a075b6351db541b203c750926cb/components/password_manager/core/browser/password_manager_metrics_util.h [modify] https://crrev.com/99d21fffc7976a075b6351db541b203c750926cb/tools/metrics/histograms/histograms.xml
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5bfa37111b4826928a2e67b7c0a5dc0b99904d7c commit 5bfa37111b4826928a2e67b7c0a5dc0b99904d7c Author: dvadym <dvadym@chromium.org> Date: Wed Mar 01 15:39:01 2017 Links in generation prompts should go to passwords.google.com (Mac). Screenshots for more context are on the bug https://bugs.chromium.org/p/chromium/issues/detail?id=695468#c1 BUG= 695468 Review-Url: https://codereview.chromium.org/2720413004 Cr-Commit-Position: refs/heads/master@{#453938} [modify] https://crrev.com/5bfa37111b4826928a2e67b7c0a5dc0b99904d7c/chrome/browser/ui/cocoa/passwords/confirmation_password_saved_view_controller.mm [modify] https://crrev.com/5bfa37111b4826928a2e67b7c0a5dc0b99904d7c/chrome/browser/ui/cocoa/passwords/confirmation_password_saved_view_controller_unittest.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/70b42e102656627f3bd5259d0364f00c88f1c8f5 commit 70b42e102656627f3bd5259d0364f00c88f1c8f5 Author: dvadym <dvadym@chromium.org> Date: Fri Mar 31 15:24:28 2017 Update generation strings according to UI review comments. BUG= 695468 Review-Url: https://codereview.chromium.org/2788803004 Cr-Commit-Position: refs/heads/master@{#461128} [modify] https://crrev.com/70b42e102656627f3bd5259d0364f00c88f1c8f5/chrome/app/chromium_strings.grd [modify] https://crrev.com/70b42e102656627f3bd5259d0364f00c88f1c8f5/chrome/app/generated_resources.grd [modify] https://crrev.com/70b42e102656627f3bd5259d0364f00c88f1c8f5/chrome/app/google_chrome_strings.grd
Android screenshots
Comment 1 by dvadym@chromium.org
, Feb 23 20178.2 KB
8.2 KB View Download
6.8 KB
6.8 KB View Download