New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 695462 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Android MediaRouter only (left Chro...
Closed: Mar 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Feature

Blocked on:
issue 690960



Sign in to add a comment

Detect whether a video is fullscreen with custom controls

Project Member Reported by mlamouri@chromium.org, Feb 23 2017

Issue description

A video can be fullscreen with native controls or custom controls. We would like to detect when fullscreen of any sort happen. This bug is for the detection heuristics.
 
Cc: zqzh...@chromium.org m...@chromium.org
 Issue 692098  has been merged into this issue.
Project Member

Comment 2 by bugdroid1@chromium.org, Mar 2 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/abc082487c58110e72e8d8e9ff6fa0b7abc9dd12

commit abc082487c58110e72e8d8e9ff6fa0b7abc9dd12
Author: zqzhang <zqzhang@chromium.org>
Date: Thu Mar 02 16:07:14 2017

[Blink>Media] Add heuristic for dominant video detection for Android

This CL adds the heuristic for dominant video detection for
Android, in which we use the fullscreen state of the document and
the viewport intersection to determine if a video is the dominant
content in fullscreen mode (as the page may fullscreen the
embedding div instead of the video element).

BUG= 695462 

Review-Url: https://codereview.chromium.org/2696893002
Cr-Commit-Position: refs/heads/master@{#454272}

[modify] https://crrev.com/abc082487c58110e72e8d8e9ff6fa0b7abc9dd12/media/blink/webmediaplayer_impl.cc
[modify] https://crrev.com/abc082487c58110e72e8d8e9ff6fa0b7abc9dd12/media/blink/webmediaplayer_impl.h
[modify] https://crrev.com/abc082487c58110e72e8d8e9ff6fa0b7abc9dd12/third_party/WebKit/Source/core/BUILD.gn
[modify] https://crrev.com/abc082487c58110e72e8d8e9ff6fa0b7abc9dd12/third_party/WebKit/Source/core/html/BUILD.gn
[modify] https://crrev.com/abc082487c58110e72e8d8e9ff6fa0b7abc9dd12/third_party/WebKit/Source/core/html/HTMLVideoElement.cpp
[modify] https://crrev.com/abc082487c58110e72e8d8e9ff6fa0b7abc9dd12/third_party/WebKit/Source/core/html/HTMLVideoElement.h
[add] https://crrev.com/abc082487c58110e72e8d8e9ff6fa0b7abc9dd12/third_party/WebKit/Source/core/html/MediaCustomControlsFullscreenDetector.cpp
[add] https://crrev.com/abc082487c58110e72e8d8e9ff6fa0b7abc9dd12/third_party/WebKit/Source/core/html/MediaCustomControlsFullscreenDetector.h
[add] https://crrev.com/abc082487c58110e72e8d8e9ff6fa0b7abc9dd12/third_party/WebKit/Source/core/html/MediaCustomControlsFullscreenDetectorTest.cpp
[modify] https://crrev.com/abc082487c58110e72e8d8e9ff6fa0b7abc9dd12/third_party/WebKit/public/platform/WebMediaPlayer.h

Status: Fixed (was: Started)

Comment 4 by dah...@chromium.org, Mar 29 2017

Blocking: -679364 -695103

Sign in to add a comment