Scrub time updates are laggy unless starting from current position |
||
Issue descriptionChrome Version: ToT What steps will reproduce the problem? (1) Visit https://mounirlamouri.github.io/sandbox/media/dynamic-controls.html (or any page with default media controls). (2) Mousedown on the scrubber. (3) Slowly move the mouse sideways (which drags the scrubber). (4) Mouseup. (5) Mousedown somewhere on the timeline track that is far away from the scrubber (the scrubber will jump to the mouse position). (6) Slowly move the mouse sideways (which drags the scrubber). What is the expected result? In both steps (3) and (6) the displayed current time within the media file should update in realtime as you move the scrubber around. This helps the user accurately seek to a given time. What happens instead? That works in (3), but in (6) the displayed current time doesn't update at all unless you stop moving the mouse for over a second - it seems to only update the displayed time once the player has seeked the media to the given position (which might involve waiting for Range requests to download the media?).
,
Mar 7 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/792dd3474f7076b0dc33126a90ba4affbaac2c7f commit 792dd3474f7076b0dc33126a90ba4affbaac2c7f Author: johnme <johnme@chromium.org> Date: Tue Mar 07 18:50:00 2017 Media Controls timeline: immediately update current time display Before this patch, dragging the scrubber starting from its current position would immediately update the current time display, but all other ways of changing the scrubber (dragging from some other start position, click on a position, or using the keyboard) would only update the current time display once the media had finished seeking to the desired position (which might have to wait for network requests). This patch removes that distinction, and now immediately updates the current time display whenever the timeline receives input. This should make it easier to precisely set the current time. BUG= 695459 ,699096 Review-Url: https://codereview.chromium.org/2725893002 Cr-Commit-Position: refs/heads/master@{#455158} [modify] https://crrev.com/792dd3474f7076b0dc33126a90ba4affbaac2c7f/third_party/WebKit/LayoutTests/TestExpectations [modify] https://crrev.com/792dd3474f7076b0dc33126a90ba4affbaac2c7f/third_party/WebKit/Source/core/html/shadow/MediaControlElements.cpp [modify] https://crrev.com/792dd3474f7076b0dc33126a90ba4affbaac2c7f/third_party/WebKit/Source/core/html/shadow/MediaControlsTest.cpp
,
Mar 8 2017
|
||
►
Sign in to add a comment |
||
Comment 1 by joh...@chromium.org
, Mar 1 2017Scrub time updates are also laggy if you give the scrubber keyboard focus and hold down left/right. I'm starting to think we should always immediately update the current time, rather than waiting for the seek to finish. (A related bug is that the media controls timeline tries to eat {mouse,pointer}{over,out,move} events whilst the scrubber is being dragged, but because dragging detection is buggy it only eats those events for drags that start from the current position.)