New issue
Advanced search Search tips

Issue 695441 link

Starred by 2 users

Issue metadata

Status: Duplicate
Merged: issue 695428
Owner:
Closed: Feb 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug



Sign in to add a comment

Android build is broken on ToT

Project Member Reported by zqzh...@chromium.org, Feb 23 2017

Issue description

I found my local Android build is broken on ToT

Getting errors as the following:
Traceback (most recent call last):
  File "../../build/android/gyp/javac.py", line 510, in <module>
    sys.exit(main(sys.argv[1:]))
  File "../../build/android/gyp/javac.py", line 506, in main
    pass_changes=True)
  File "/usr/local/google/code/chromium/src/build/android/gyp/util/build_utils.py", line 578, in CallAndWriteDepfileIfStale
    pass_changes=True)
  File "/usr/local/google/code/chromium/src/build/android/gyp/util/md5_check.py", line 87, in CallAndRecordIfStale
    function(*args)
  File "/usr/local/google/code/chromium/src/build/android/gyp/util/build_utils.py", line 561, in on_stale_md5
    function(*args)
  File "../../build/android/gyp/javac.py", line 499, in <lambda>
    classpath_inputs),
  File "../../build/android/gyp/javac.py", line 260, in _OnStaleMd5
    attempt_build()
  File "../../build/android/gyp/javac.py", line 258, in <lambda>
    stderr_filter=ColorJavacOutput)
  File "/usr/local/google/code/chromium/src/build/android/gyp/util/build_utils.py", line 170, in CheckOutput
    raise CalledProcessError(cwd, args, stdout + stderr)
util.build_utils.CalledProcessError: Command failed: ( cd /usr/local/google/code/chromium/src/out/Android; bin/jmake -pdb gen/chrome/android/webapk/shell_apk/javatests/canary_lib/canary_lib2_java__compile_java.javac.jar.pdb -jcexec bin/jmake -C-g -C-encoding -CUTF-8 -classpath : -C-sourcepath -C: -bootclasspath lib.java/android.interface.jar -C-source -C1.7 -C-target -C1.7 -C-Xlint:unchecked -C-Xlint:deprecation -d /tmp/tmpsvZtiO/classes ../../chrome/android/webapk/shell_apk/javatests/canary_lib/src/org/chromium/webapk/shell_apk/test/canary/Canary2.java )
jmake: jmake: -g is an invalid option or argument.
Run "jmake -h" for help.

After bisecting, the culprit CL is:
https://codereview.chromium.org/2712453003

agrieve@, can you take a look?

I guess it could be related to debug build. After removing "is_debug" the build succeeded.

My GN args:

is_component_build = true
is_debug = true

enable_nacl = false

use_goma = true
target_os = "android"
is_clang = true
enable_incremental_javac = true
disable_incremental_isolated_processes = true

media_use_ffmpeg = true
media_use_libvpx = true
proprietary_codecs = true
ffmpeg_branding = "Chrome"

run_findbugs = true

 
Mergedinto: 695428
Status: Duplicate (was: Assigned)
Project Member

Comment 2 by bugdroid1@chromium.org, Feb 23 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a38190340ae16cb9043857f9ef85eea193ded7f5

commit a38190340ae16cb9043857f9ef85eea193ded7f5
Author: agrieve <agrieve@chromium.org>
Date: Thu Feb 23 14:52:33 2017

Revert of Fix up javac.py's depfile to include all relevant inputs (patchset #2 id:20001 of https://codereview.chromium.org/2712453003/ )

Reason for revert:
Broke enable_incremental_javac GN arg

Original issue's description:
> Fix up javac.py's depfile to include all relevant inputs
>
> The missing .jar files was broken a while ago by:
> https://codereview.chromium.org/1730993002
>
> But it never contained the javac binary
>
> BUG=589311
>
> Review-Url: https://codereview.chromium.org/2712453003
> Cr-Commit-Position: refs/heads/master@{#452156}
> Committed: https://chromium.googlesource.com/chromium/src/+/df82b88ea4aa22520083f90922a99540902f666e

TBR=nyquist@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=589311, 695441 

Review-Url: https://codereview.chromium.org/2712973002
Cr-Commit-Position: refs/heads/master@{#452485}

[modify] https://crrev.com/a38190340ae16cb9043857f9ef85eea193ded7f5/build/android/gyp/javac.py

Project Member

Comment 3 by bugdroid1@chromium.org, Feb 24 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/453ee830bdd7e8a3ac3f05c0f348deb75f35f4ae

commit 453ee830bdd7e8a3ac3f05c0f348deb75f35f4ae
Author: agrieve <agrieve@chromium.org>
Date: Fri Feb 24 21:21:40 2017

Reland of Fix up javac.py's depfile to include all relevant inputs

The missing .jar files was broken a while ago by:
https://codereview.chromium.org/1730993002

But it never contained the javac binary

Reverted in:
https://codereview.chromium.org/2712973002/

Reason for reland:
Now works with enable_incremental_javac=true

BUG=589311, 695441 

Review-Url: https://codereview.chromium.org/2711413002
Cr-Commit-Position: refs/heads/master@{#452923}

[modify] https://crrev.com/453ee830bdd7e8a3ac3f05c0f348deb75f35f4ae/build/android/gyp/javac.py

Sign in to add a comment