New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 695421 link

Starred by 1 user
Status: Fixed
Owner:
arthurso...@chromium.org
Closed: Dec 2017
Cc:
jam@chromium.org
engedy@chromium.org
clamy@chromium.org
█ nasko@chromium.org
Components:
EstimatedDays: 2
NextAction: ----
OS: All
Pri: 2
Type: Bug

Blocking:
issue 685074



Sign in to add a comment

ResourceMsg_ReceivedRedirect message is never sent when a request is blocked by a NavigationThrottle.

Project Member Reported by arthurso...@chromium.org, Feb 23 2017 
When PlzNavigate is **disabled**, when a request is blocked on a redirect, the ResourceMsg_ReceivedRedirect message is never sent, only ResourceMsg_RequestComplete is sent. Hence the renderer never learns of the redirect, so the provisional load fails on the renderer side with the pre-redirect URL.

This means that the error page is also committed under the pre-redirect URL,
which causes a mismatch in TakeNavigationHandleForCommit, because the NavigationHandle already has the post-redirect URL.

It is not a problem for now since there is no NavigationThrottle that will block a Navigation on a redirect with an error code different of ERR_ABORTED.

It is blocking:
https://codereview.chromium.org/2632633006/
https://codereview.chromium.org/2698623006/
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 16 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5b5c309859412def817a518a7dddbf413cd892e9

commit 5b5c309859412def817a518a7dddbf413cd892e9
Author: arthursonzogni <arthursonzogni@chromium.org>
Date: Thu Mar 16 09:55:25 2017

PlzNavigate: add support for BLOCK_REQUEST during redirects

This CL adds support for blocking requests in NavigationRequest during
redirects. It also fixes an issue in NavigationHandle, without
PlzNavigate activated, where the NavigationHandle would not be properly
recognized at error page commit if the navigation was blocked by a
NavigationThrottle during a redirect.

BUG= 685074 ,  695421 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2698623006
Cr-Commit-Position: refs/heads/master@{#457387}

[modify] https://crrev.com/5b5c309859412def817a518a7dddbf413cd892e9/content/browser/frame_host/navigation_handle_impl.cc
[modify] https://crrev.com/5b5c309859412def817a518a7dddbf413cd892e9/content/browser/frame_host/navigation_handle_impl_browsertest.cc
[modify] https://crrev.com/5b5c309859412def817a518a7dddbf413cd892e9/content/browser/frame_host/navigation_request.cc
[modify] https://crrev.com/5b5c309859412def817a518a7dddbf413cd892e9/content/public/browser/navigation_throttle.h

Comment 2 by arthurso...@chromium.org, Mar 16 2017

Status: Available (was: Assigned)
Make this issue available. The last CL didn't solve the bug contrary to what is was supposed to do initially.

Comment 3 by arthurso...@chromium.org, Dec 21 2017

Status: Fixed (was: Available)
PlzNavigate has shipped. This bug occurred when it was disabled.
I can now close the bug.
►

Sign in to add a comment