Non-Regression : Toggle Button is seen Enabled on closing 'ENTER SIM PIN' Dialog box in Cellular Connection Page |
||||||||||||||
Issue descriptionChrome Version: 57.0.2987.75/9202.37.0 Beta -channel Minnie,Daisy,Candy,Quawks OS: Chrome What steps will reproduce the problem? (1)Sign into User ->Insert Mobile Dongle and ensure it is connected (2)Now go to chrome://md-settings page -> At Internet Connection click on Cellular connection -> Navigates to Cellular connected page (3)Now Enable 'Enable SIM Card locking(require PIN to use Mobile data) option -> 'ENTER SIM PIN' Dialog box is seen and now click on Close icon-> Observe Toggle Button is seen enabled(Please refer Video) Expected: On closing 'ENTER SIM PIN' Dialog box Toggle Button should be seen disabled Actual: Instead Toggle Button is seen Enabled This is Non-Regression issue seen from M-56.
,
Feb 28 2017
,
Feb 28 2017
Thanks. We can fix this in 59.
,
Mar 8 2017
,
Apr 13 2017
,
Apr 14 2017
,
Apr 17 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/780ef7b430dc6976831ae4f952cf34579b101f70 commit 780ef7b430dc6976831ae4f952cf34579b101f70 Author: stevenjb <stevenjb@chromium.org> Date: Mon Apr 17 21:22:19 2017 MD Settings: Network: SIM unlock: Fix focus and cancel This CL: * Focuses the first input field for all sim dialogs. * Fixes the toggle logic when the dialog is canceled. BUG= 695409 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2821743002 Cr-Commit-Position: refs/heads/master@{#465021} [modify] https://crrev.com/780ef7b430dc6976831ae4f952cf34579b101f70/chrome/browser/resources/settings/internet_page/network_siminfo.html [modify] https://crrev.com/780ef7b430dc6976831ae4f952cf34579b101f70/chrome/browser/resources/settings/internet_page/network_siminfo.js
,
Apr 17 2017
,
Apr 18 2017
,
Apr 18 2017
Your change meets the bar and is auto-approved for M59. Please go ahead and merge the CL to branch 3071 manually. Please contact milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), gkihumba@(ChromeOS), Abdul Syed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Apr 24 2017
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible! If all merges have been completed, please remove any remaining Merge-Approved labels from this issue. Thanks for your time! To disable nags, add the Disable-Nags label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Apr 25 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/cd306d8a99765cd2c9cbd05f39a93bacd9cfd078 commit cd306d8a99765cd2c9cbd05f39a93bacd9cfd078 Author: Steven Bennetts <stevenjb@chromium.org> Date: Tue Apr 25 00:12:14 2017 MD Settings: Network: SIM unlock: Fix focus and cancel This CL: * Focuses the first input field for all sim dialogs. * Fixes the toggle logic when the dialog is canceled. BUG= 695409 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2821743002 Cr-Commit-Position: refs/heads/master@{#465021} (cherry picked from commit 780ef7b430dc6976831ae4f952cf34579b101f70) Review-Url: https://codereview.chromium.org/2835973003 . Cr-Commit-Position: refs/branch-heads/3071@{#185} Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641} [modify] https://crrev.com/cd306d8a99765cd2c9cbd05f39a93bacd9cfd078/chrome/browser/resources/settings/internet_page/network_siminfo.html [modify] https://crrev.com/cd306d8a99765cd2c9cbd05f39a93bacd9cfd078/chrome/browser/resources/settings/internet_page/network_siminfo.js
,
May 22 2017
@mmanchala, Please verify!
,
May 22 2017
,
May 25 2017
Checked Issue in M-59 #59.0.3071.72/9460.51.0 and in latest ToT #60.0.3107.0/9587.0.0. Issue is working fine i.e. Toggle Button is seen disabled on closing 'ENTER SIM PIN' Dialog box in Cellular Connection Page.(Attaching video)
,
Jan 22 2018
|
||||||||||||||
►
Sign in to add a comment |
||||||||||||||
Comment 1 by mitsuji@chromium.org
, Feb 28 2017Status: Assigned (was: Untriaged)