New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 695394 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner:
Last visit > 30 days ago
Closed: Jan 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

6.3% regression in smoothness.gpu_rasterization.tough_filters_cases at 452027:452076

Project Member Reported by primiano@chromium.org, Feb 23 2017

Issue description

See the link to graphs below.
 
All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=695394

Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?keys=agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDghJPXqQoM


Bot(s) for this bug's original alert(s):

android-one
Project Member

Comment 3 by 42576172...@developer.gserviceaccount.com, Feb 23 2017

Cc: junov@chromium.org
Owner: junov@chromium.org

=== Auto-CCing suspected CL author junov@chromium.org ===

Hi junov@chromium.org, the bisect results pointed to your CL, please take a look at the
results.


=== BISECT JOB RESULTS ===
Perf regression found with culprit

Suspected Commit
  Author : junov
  Commit : 9ac0ae9669662fadaf27f247d0c46d6e14e075fe
  Date   : Wed Feb 22 16:03:54 2017
  Subject: Simplify rate limiter logic in Canvas2DLayerBridge

Bisect Details
  Configuration: android_one_perf_bisect
  Benchmark    : smoothness.gpu_rasterization.tough_filters_cases
  Metric       : frame_times/http___web.archive.org_web_20150502135732_http___ie.microsoft.com_testdrive_Performance_Pirates_Default.html
  Change       : 5.91% | 44.75247955 -> 47.3983999333

Revision             Result                   N
chromium@452026      44.7525 +- 0.324261      6      good
chromium@452068      45.0132 +- 1.29276       9      good
chromium@452070      45.6056 +- 7.12068       9      good
chromium@452071      47.4317 +- 0.85434       9      bad       <--
chromium@452072      47.5654 +- 1.49182       9      bad
chromium@452076      47.3984 +- 0.500126      6      bad

To Run This Test
  src/tools/perf/run_benchmark -v --browser=android-chromium --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests --story-filter=http...web.archive.org.web.20150502135732.http...ie.microsoft.com.testdrive.Performance.Pirates.Default.html smoothness.gpu_rasterization.tough_filters_cases

Debug Info
  https://chromeperf.appspot.com/buildbucket_job_status/8986869950956764096

Is this bisect wrong?
  https://chromeperf.appspot.com/bad_bisect?try_job_id=4981462262087680


| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Speed>Bisection.  Thank you!
Labels: Performance-Responsiveness
Status: Assigned (was: Untriaged)
Explictly assigning. A CL you landed tripped one of the speed metrics we measure in the lab. If this is the first time this has happened to one of your CLs, or if it's been a while, please read: https://chromium.googlesource.com/chromium/src/+/master/docs/speed/addressing_performance_regressions.md

We're looking for one of the following:
1. Justification via explanation
2. Plan to revert or fix
3. Angry rage throwing of equipment at my head

Just be aware that I'm trained in trumpet playing and First Aid and am not afraid to use it.

Note: This was a bulk edit message and not very personal.
junov: it looks like your CL was the cause of the regression, and it didn't recover. This bug was from back in February; anything we can do about it now, or should we WontFix?
junov: ping on this bug?
Components: Blink>Canvas
Status: WontFix (was: Assigned)
Closing since this hasn't had any update in almost a year and some of the tests that regressed have been turned down at this point.

Sign in to add a comment