New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 695388 link

Starred by 4 users

Issue metadata

Status: Fixed
Owner: ----
Closed: May 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Error when sync-compiling a large Wasm modiule is obtuse

Project Member Reported by mscales@chromium.org, Feb 23 2017

Issue description

When compiling a module synchronously, v8 will throw if the source buffer is larger than some threshold. This is a new feature added in https://codereview.chromium.org/2699843003/

The error is "Wasm compilation exceeds internal limits in this context for the provided arguments" which is extremely uninformative. When I got this error in Canary yesterday I had no idea what the problem might be until I happened across the codereview link by Googling for the message.

We should make this more informative, perhaps: "Module is too large for synchronous compile. Use WebAssembly.instantiate() instead."

 
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 1 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/19f24d6ef5ac652a444664d75fd1c52cd96cff2a

commit 19f24d6ef5ac652a444664d75fd1c52cd96cff2a
Author: titzer <titzer@chromium.org>
Date: Wed Mar 01 19:46:04 2017

[wasm] Better error message for exceeding module size limits.

R=mtrofin@chromium.org
BUG= chromium:695388 

Review-Url: https://codereview.chromium.org/2724053002
Cr-Commit-Position: refs/heads/master@{#43524}

[modify] https://crrev.com/19f24d6ef5ac652a444664d75fd1c52cd96cff2a/src/wasm/wasm-js.cc

Cc: bradnelson@chromium.org
Status: Available (was: Untriaged)
Status: Fixed (was: Available)
Looks like this is fixed.

Sign in to add a comment