Older versions of UPower doesn't have GetDisplayDevice |
||
Issue descriptionChrome Version: 56.0.2924.87 OS: Linux Thanks for the work on r413745, but there's a slight problem with the code. - We already check to see if the system has UPower 0.9.23 or 0.99.x. - We know GetDisplayDevice does not exist in 0.9.23. - Yet we still try to call it. Can we add a check and stop calling it with older UPower? I occasionally see messages like the following on Ubuntu 14.04: [$PID:$TID:ERROR:object_proxy.cc(583)] Failed to call method: org.freedesktop.UPower.GetDisplayDevice: object_path= /org/freedesktop/UPower: org.freedesktop.DBus.Error.UnknownMethod: Method "GetDisplayDevice" with signature "" on interface "org.freedesktop.UPower" doesn't exist It's just log spam for me, but this has caused a bit of confusion in bug 670959 as it is the last thing the user seems before their browser crashes.
,
Apr 10 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/91037c1a4a82985c652ac38826fd5b3fc6d56d91 commit 91037c1a4a82985c652ac38826fd5b3fc6d56d91 Author: thestig <thestig@chromium.org> Date: Mon Apr 10 19:24:41 2017 Do not call GetDisplayDevice for older UPower versions. On Linux, older versions of UPower did not have the GetDisplayDevice method. Trying to call it generates log spam. Modernize the modified file with base::MakeUnique while we are here. BUG= 695383 Review-Url: https://codereview.chromium.org/2795713003 Cr-Commit-Position: refs/heads/master@{#463358} [modify] https://crrev.com/91037c1a4a82985c652ac38826fd5b3fc6d56d91/device/battery/battery_status_manager_linux.cc
,
Apr 10 2017
|
||
►
Sign in to add a comment |
||
Comment 1 by thestig@chromium.org
, Apr 4 2017Status: Assigned (was: Available)