New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 695378 link

Starred by 1 user
Status: Fixed
Owner:
█ robhogan@chromium.org
Use other robhogan account instead.
Closed: Jun 2017
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Flaky tests: fast/block/float/float-should-dirty-line-when-adjacent-to-line-breaks.html

Reported by msten...@opera.com, Feb 23 2017 
This also applies to float-should-dirty-line-when-adjacent-to-line-breaks-2.html

If you open the test locally in content_shell, or even Chrome, and then reload a few times, you'll see that the test fails quite often (i.e. all the words end up on the same line), but far from always.

Or just run-webkit-tests.

Comment 1 by msten...@opera.com, Feb 23 2017

Blocking: 601332

Comment 2 by msten...@opera.com, Feb 23 2017

Blocking: -601332
Project Member

Comment 3 by bugdroid1@chromium.org, Apr 19 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c7a0755ef5b59863b714ceaa988a57c882195f86

commit c7a0755ef5b59863b714ceaa988a57c882195f86
Author: robhogan <robhogan@gmail.com>
Date: Wed Apr 19 19:00:30 2017

Search correctly for inline ancestors without a sibling when dirtying lineboxes

Fixes a mistake in https://codereview.chromium.org/2486423003 - it should have
checked whether the current child has a previous sibling, not the candidate parent.

Also revert to the original version of the two tests - as the new versions never
fail.

BUG= 695378 

Review-Url: https://codereview.chromium.org/2828553002
Cr-Commit-Position: refs/heads/master@{#465686}

[modify] https://crrev.com/c7a0755ef5b59863b714ceaa988a57c882195f86/third_party/WebKit/LayoutTests/fast/block/float/float-should-dirty-line-when-adjacent-to-line-breaks-2-expected.html
[modify] https://crrev.com/c7a0755ef5b59863b714ceaa988a57c882195f86/third_party/WebKit/LayoutTests/fast/block/float/float-should-dirty-line-when-adjacent-to-line-breaks-2.html
[modify] https://crrev.com/c7a0755ef5b59863b714ceaa988a57c882195f86/third_party/WebKit/LayoutTests/fast/block/float/float-should-dirty-line-when-adjacent-to-line-breaks-expected.html
[modify] https://crrev.com/c7a0755ef5b59863b714ceaa988a57c882195f86/third_party/WebKit/LayoutTests/fast/block/float/float-should-dirty-line-when-adjacent-to-line-breaks.html
[modify] https://crrev.com/c7a0755ef5b59863b714ceaa988a57c882195f86/third_party/WebKit/Source/core/layout/line/LineBoxList.cpp

Comment 4 by robhogan@chromium.org, Jun 15 2017

Status: Fixed (was: Assigned)
►

Sign in to add a comment