content_unittests failing on 3 builders |
||||||
Issue descriptioncontent_unittests failing on 3 builders Builders failed on: - Win 7 Tests x64 (1): https://build.chromium.org/p/chromium.win/builders/Win%207%20Tests%20x64%20%281%29 - Win10 Tests x64: https://build.chromium.org/p/chromium.win/builders/Win10%20Tests%20x64 - Win7 Tests (1): https://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%281%29
,
Feb 23 2017
Suspected culprit reverted in https://codereview.chromium.org/2717453002/ Let's see if that fixes things.
,
Feb 23 2017
The revert didn't help; CL was relanded. I'm disabling the test on Windows.
,
Feb 23 2017
CL to disable the test is in the CQ: https://codereview.chromium.org/2712713006 Assigning to an owner; CCing other owner and people who recently touched code in this area.
,
Feb 23 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8d90ac250bb2ac5aaa876b04300c8edce0a7b824 commit 8d90ac250bb2ac5aaa876b04300c8edce0a7b824 Author: treib <treib@chromium.org> Date: Thu Feb 23 11:49:38 2017 Disable RenderWidgetHostViewGuestTest.VisibilityTest on Windows BUG= 695375 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation TBR=alexmos@chromium.org Review-Url: https://codereview.chromium.org/2712713006 Cr-Commit-Position: refs/heads/master@{#452464} [modify] https://crrev.com/8d90ac250bb2ac5aaa876b04300c8edce0a7b824/content/browser/frame_host/render_widget_host_view_guest_unittest.cc
,
Feb 23 2017
I think this is due to missing TaskScheduler instance used by base::PostTaskWithTraits in RenderWidgetHostImpl ctor. I don't know why it has not failed before, but adding a ScopedTaskScheduler should fix the failure.
,
Feb 23 2017
tzik@ has a CL in progress to fix this.
,
Feb 24 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/33237fadcbda24bd31d2a166ba9a79c994671dda commit 33237fadcbda24bd31d2a166ba9a79c994671dda Author: tzik <tzik@chromium.org> Date: Fri Feb 24 00:52:10 2017 Keep a TaskScheduler instance in RenderWidgetHostViewGuestTest RenderWidgetHostImpl on Windows uses TaskScheduler in its constructor, and that requires a TaskScheduler instance. This CL add one to RenderWidgetHostViewGuestTest, so that it unbreak the test failure on Windows bots. BUG= 695375 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation Review-Url: https://codereview.chromium.org/2710053003 Cr-Commit-Position: refs/heads/master@{#452696} [modify] https://crrev.com/33237fadcbda24bd31d2a166ba9a79c994671dda/content/browser/frame_host/render_widget_host_view_guest_unittest.cc
,
Feb 24 2017
,
Feb 24 2017
FYI: The crash log was buildbot: https://build.chromium.org/p/chromium.win/builders/Win%207%20Tests%20x64%20%281%29/builds/21047 logdoc: https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Fchromium.win%2FWin_7_Tests_x64__1_%2F21047%2F%2B%2Frecipes%2Fsteps%2Fcontent_unittests%2F0%2Flogs%2FRenderWidgetHostViewGuestTest.VisibilityTest%2F0 Sorry for the lack of the information, and thank you for fixing, tzik@!
,
Jan 24 2018
|
||||||
►
Sign in to add a comment |
||||||
Comment 1 by maxmorin@chromium.org
, Feb 23 2017