Test GoogleNowCardsUnitTest.onAlarmUpdate crashes when started in bigger batch |
|||
Issue descriptionChrome Version: 58.0.3013.3 OS: OSX 10.12 What steps will reproduce the problem? (1) Build target unit_tests (2) Launch ./out/Debug/unit_tests --test-launcher-batch-limit=50 --gtest_filter=GoogleNowCardsUnitTest.* What is the expected result? All tests pass. What happens instead? Test GoogleNowCardsUnitTest.onAlarmUpdate crashes. Crash is caused by null pointer dereference in lazy_scheduler_message_loop_delegate_for_tests.cc : 43 (message_loop_ is nullptr).
,
Feb 23 2017
,
Mar 6 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/798c699f3c8ca93487d257d7eda0a59b35ee1d9e commit 798c699f3c8ca93487d257d7eda0a59b35ee1d9e Author: ckulakowski <ckulakowski@opera.com> Date: Mon Mar 06 18:40:13 2017 Add message loop to v8's unittests When (at least some) v8 unittests are started in bigger batch we hit v8 garbage collector's incremental marking hard limit. When it happens v8's engine posts task and it causes crash as there is no active message loop. This change creates message loop for v8's unittests to fix this crash. BUG= 695374 Review-Url: https://codereview.chromium.org/2735703003 Cr-Commit-Position: refs/heads/master@{#454898} [modify] https://crrev.com/798c699f3c8ca93487d257d7eda0a59b35ee1d9e/chrome/test/base/v8_unit_test.cc [modify] https://crrev.com/798c699f3c8ca93487d257d7eda0a59b35ee1d9e/chrome/test/base/v8_unit_test.h
,
Mar 6 2017
|
|||
►
Sign in to add a comment |
|||
Comment 1 by ckulakow...@opera.com
, Feb 23 2017