New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 695370 link

Starred by 2 users
Status: Fixed
Owner:
█ tsergeant@chromium.org
Not on Chrome
Closed: Feb 2017
Cc:
nyerramilli@chromium.org
rbasuvula@chromium.org
█ msrchandra@chromium.org
█ ranjitkan@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression : "No history entries found" text is missing when history is empty.

Reported by yfulgaon...@etouch.net, Feb 23 2017 
Chrome Version : 58.0.3021.0 (Official Build) 24ff81d5bbced05323d0ea9a56b3cac756015c7d-refs/heads/master@{#452347} 32/64 bit
OS : Windows (7,8,10), Mac (10.11.6, 10.12.1, 10.12), Linux (14.04 LTS)

Precondition : Freshly install chrome.

What steps will reproduce the problem?
1. Launch chrome and navigate to chrome://history, observe the page.

Actual : "No history entries found" text is missing when history is empty.
Expected : "No history entries found" text should be seen when there is no history.

This is a regression issue broken in ‘M-58’, below is the Manual Regression range and will soon update other info.
Good build : 58.0.3020.0 
Bad build : 58.0.3021.0
Actual_History.mp4
504 KB View Download
Expected_History.mp4
409 KB View Download

Comment 1 by rbasuvula@chromium.org, Feb 23 2017

Cc: rbasuvula@chromium.org
Labels: hasbisect-per-revision ReleaseBlock-Stable
Owner: tsergeant@chromium.org
Status: Assigned (was: Unconfirmed)
Using the per-revision bisect providing the bisect results,
Good build: 58.0.3020.0 (Revision: 451874).
Bad build: 58.0.3021.0 (Revision: 452347).

You are probably looking for a change made after 451940 (known good), but no later than 451941 (first known bad).

CHANGE-LOG URL:
---------------
https://chromium.googlesource.com/chromium/src/+log/602d6f696604aa263c17a78460ac59efbfbe256f..e07cf60f84106241ccd5093e5ad3dc23f01e8b7d

From the CL above, assigning the issue to the concern owner

@tsergeant : Could you please look into the issue, pardon me if it has nothing to do with your changes and if possible please assign it to concern owner.

Review-Url: https://codereview.chromium.org/2684693004
Note : 1.Able to reproduce the issue in Ubuntu 14.04,Win 10.0 and Mac 10.12.2.Able to reproduce in latest Canary #58.0.3021.0
2.Adding Release Block-Stable for this issue.Please remove if not the case.

Comment 2 by tsergeant@chromium.org, Feb 23 2017

Status: Started (was: Assigned)
Project Member

Comment 3 by bugdroid1@chromium.org, Feb 24 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/952fab9efa69cf3d0cc2a003762deec638199cdf

commit 952fab9efa69cf3d0cc2a003762deec638199cdf
Author: tsergeant <tsergeant@chromium.org>
Date: Fri Feb 24 02:53:01 2017

MD History: Fix display of 'No history entries found' message

BUG= 695370 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2709423003
Cr-Commit-Position: refs/heads/master@{#452726}

[modify] https://crrev.com/952fab9efa69cf3d0cc2a003762deec638199cdf/chrome/browser/resources/md_history/history_list.html
[modify] https://crrev.com/952fab9efa69cf3d0cc2a003762deec638199cdf/chrome/test/data/webui/md_history/history_list_test.js

Comment 4 by tsergeant@chromium.org, Feb 24 2017

Status: Fixed (was: Started)

Comment 5 by kkaluri@chromium.org, Feb 28 2017

Labels: TE-Verified-M58 TE-Verified-58.0.3025.5
Verified this issue on Windows-10, Mac 10.12.3 and Ubuntu-14.04 using Chrome version #58.0.3025.5 as per the comment #0.

Observed that the fix is working as expected.

Attaching the screen cast for reference.

Hence, adding the verified labels.

Thanks.
Issue 695370.mp4
255 KB View Download
►

Sign in to add a comment