New issue
Advanced search Search tips

Issue 695358 link

Starred by 1 user
Status: Verified
Owner:
nya@chromium.org
Closed: Feb 2017
Cc:
hidehiko@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

mediaview: File operations are not deferred during ARC boot

Project Member Reported by nya@chromium.org, Feb 23 2017 
Chrome Version: ToT
OS: Chrome OS

What steps will reproduce the problem?
(1) Login, opt-in to ARC, then logout.
(2) Login again.
(3) While ARC is booting, launch Files.app and open media views.

What is the expected result?
Progress bar rotates until ARC finishes booting. After ARC boot is finished, the contents are shown.

What happens instead?
No progress bar is shown and empty content is shown. Even if ARC boot finishes, the directory content remains empty.
Project Member

Comment 1 by bugdroid1@chromium.org, Feb 23 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8514e79471d9dfa4a9376317b86f45b57e11eea6

commit 8514e79471d9dfa4a9376317b86f45b57e11eea6
Author: nya <nya@chromium.org>
Date: Thu Feb 23 09:29:56 2017

mediaview: Fix ARC file system operation deferring.

After recent changes of ARC startup refactoring (crbug.com/657687), ARC
file system operation deferring of media views was broken.

Formerly ArcFileSystemOperationRunner was constructed in
ArcServiceLauncher::Initialize(), which happens before a primary profile
is created. Thus it was wrong to check ARC opt-in status in its
constructor. Nevertheless it seemed to work because
ArcFileSystemOperationRunner::OnArcPlayStoreEnabledChanged() was always
called soon after login, which is no longer the case after the
refactoring.

This patch moves the construction of ArcFileSystemOperationRunner to
ArcServiceLauncher::OnPrimaryUserProfilePrepared() and passes Profile to
ArcFileSystemOperationRunner explicitly.

Due to this change, ARC file operations issued before a primary profile
gets ready are dropped, but we do not expect such operations. But just
in case, we emit error logs in such cases.

BUG= chromium:695358 
BUG=chromium:657687
TEST=unit_tests
TEST=No "operations are dropped" lines in /var/log/ui/ui.LATEST

Review-Url: https://codereview.chromium.org/2704123007
Cr-Commit-Position: refs/heads/master@{#452441}

[modify] https://crrev.com/8514e79471d9dfa4a9376317b86f45b57e11eea6/chrome/browser/chromeos/arc/arc_service_launcher.cc
[modify] https://crrev.com/8514e79471d9dfa4a9376317b86f45b57e11eea6/chrome/browser/chromeos/arc/fileapi/arc_file_system_operation_runner.cc
[modify] https://crrev.com/8514e79471d9dfa4a9376317b86f45b57e11eea6/chrome/browser/chromeos/arc/fileapi/arc_file_system_operation_runner.h
[modify] https://crrev.com/8514e79471d9dfa4a9376317b86f45b57e11eea6/chrome/browser/chromeos/arc/fileapi/arc_file_system_operation_runner_util.cc

Comment 2 by nya@chromium.org, Feb 23 2017

Status: Fixed (was: Started)

Comment 3 by rookrishna@chromium.org, Mar 31 2017

Status: Verified (was: Fixed)
►

Sign in to add a comment