Issue metadata
Sign in to add a comment
|
Regression:Focus is missing on buttons while pressing tab. |
||||||||||||||||||||||
Issue descriptionChrome Version:58.0.3021.0 dev OS:Ubuntu 14.04 Precondition:Make sure you are in GTK+ theme. What steps will reproduce the problem? (1)On fresh installation of chrome, press tab and Observe focus on OK button of installation bubble.(OR) (2)Launch chrome, open profile icon menu,press tab and observe the focus on Sign in to Chrome button This issue is also seen in some other places too.. (location bubbles,bookmark bubble..) Expected Result:Focus should be seen on buttons while pressing tab. Actual Result:Focus highlight is missing while pressing tab. This is a Regression issue broken in M-58 Manual Bisect Info: =================== Good build:58.0.3020.0 Bad build :58.0.3021.0 NOTE:Issue is not applicable to Windows.
,
Feb 23 2017
Able to reproduce this issue on Ubuntu 14.04 using chrome latest Dev #58.0.3021.0, Not reproducible on Mac OS 10.12.3. Bisect Information: --------------------- Using the per-revision bisect providing the bisect results, You are probably looking for a change made after 452117 (known good), but no later than 452118 (first known bad). CHANGE-LOG URL: ----------------- https://chromium.googlesource.com/chromium/src/+log/c088d17506c14fbfbab1d34538dcca64a561e315..872a494bba52e597388aec738d9d681183a3d47b From the CL above, assigning the issue to the concern owner Review-Url: https://codereview.chromium.org/2670623002 thomasanderson@ Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner. Note: Adding RB-Stable since this is a recent regression on M58, please feel free to edit if this is not the case. Thanks!
,
Feb 23 2017
thomasanderson@:In GTK+ theme,wrench menu and context menu are displayed in dark colour(same for Normal window,Guest,Incognito).Is this change is Intended or shall I raise an issue for this??Please confirm.
,
Feb 23 2017
#3 That is correct behavior for the Ambiance theme
,
Feb 27 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e9b9fb0998172808d880ca208685d8007b8f5a6e commit e9b9fb0998172808d880ca208685d8007b8f5a6e Author: thomasanderson <thomasanderson@google.com> Date: Mon Feb 27 19:25:44 2017 Gtk3: Refactor GtkButtonImageSource::GetImageForScale This CL refactors GetImageForScale() on Gtk3 so no widget gets created. Only a GtkStyleContext is needed. In addition, it adds GtkStateFlagFocused to the style context if |focus_| is true. This fixes focused button rendering on Ambiance, which doesn't use a focus rectangle, but instead changes the button's border directly. BUG= 695357 R=erg@chromium.org Review-Url: https://codereview.chromium.org/2715153002 Cr-Commit-Position: refs/heads/master@{#453292} [modify] https://crrev.com/e9b9fb0998172808d880ca208685d8007b8f5a6e/chrome/browser/ui/libgtkui/gtk_ui.cc [modify] https://crrev.com/e9b9fb0998172808d880ca208685d8007b8f5a6e/chrome/browser/ui/libgtkui/gtk_util.cc [modify] https://crrev.com/e9b9fb0998172808d880ca208685d8007b8f5a6e/chrome/browser/ui/libgtkui/gtk_util.h [modify] https://crrev.com/e9b9fb0998172808d880ca208685d8007b8f5a6e/chrome/browser/ui/libgtkui/native_theme_gtk3.cc
,
Feb 27 2017
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by kochi@chromium.org
, Feb 23 2017