Issue metadata
Sign in to add a comment
|
Regression: no change event if input cleared in submit handler and then filled with same data
Reported by
mbest...@gmail.com,
Feb 23 2017
|
||||||||||||||||||||||
Issue descriptionUserAgent: Mozilla/5.0 (Windows NT 10.0; WOW64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/56.0.2924.87 Safari/537.36 Steps to reproduce the problem: 1. Go to https://jsfiddle.net/ocg90j0u/ 2. Type something in the field and press enter 3. Type the same thing in the field and press enter What is the expected behavior? You should see the same value twice in the "log" What went wrong? Instead you see null, which means that there was no change event fired for the input. Did this work before? Yes 55 Does this work in other browsers? Yes Chrome version: 56.0.2924.87 Channel: stable OS Version: 10.0 Flash Version: See https://github.com/knockout/knockout/issues/2206
,
Feb 23 2017
Assigning to the CL owner as per the above bisect.
,
Feb 24 2017
Sounds like a significant regression.
,
Feb 24 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5add6ffa7fc5878720f4a561b6edc4cc49e08936 commit 5add6ffa7fc5878720f4a561b6edc4cc49e08936 Author: tkent <tkent@chromium.org> Date: Fri Feb 24 05:36:34 2017 INPUT element: Implicit form submission should reset setTextAsOfLastFormControlChangeEvent. BUG= 695349 Review-Url: https://codereview.chromium.org/2716773002 Cr-Commit-Position: refs/heads/master@{#452762} [add] https://crrev.com/5add6ffa7fc5878720f4a561b6edc4cc49e08936/third_party/WebKit/LayoutTests/fast/forms/text/text-change-event-after-clear-in-submit.html [modify] https://crrev.com/5add6ffa7fc5878720f4a561b6edc4cc49e08936/third_party/WebKit/Source/core/html/HTMLInputElement.cpp
,
Feb 24 2017
,
Feb 24 2017
,
Feb 25 2017
Your change meets the bar and is auto-approved for M57. Please go ahead and merge the CL to branch 2987 manually. Please contact milestone owner if you have questions. Owners: amineer@(clank), cmasso@(bling), ketakid@(cros), govind@(desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Feb 25 2017
Please merge your change to M57 branch 2987 by 5:00 PM PT Monday (02/27) so we can take it in for next week last M57 Desktop Beta release before Stable promotion. Thank you.
,
Feb 26 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/12901a927913176a7c998f918e21b761608aaedc commit 12901a927913176a7c998f918e21b761608aaedc Author: Kent Tamura <tkent@chromium.org> Date: Sun Feb 26 19:34:41 2017 Merge "INPUT element: Implicit form submission should reset setTextAsOfLastFormControlChangeEvent." to M57 BUG= 695349 Review-Url: https://codereview.chromium.org/2716773002 Cr-Commit-Position: refs/heads/master@{#452762} (cherry picked from commit 5add6ffa7fc5878720f4a561b6edc4cc49e08936) Review-Url: https://codereview.chromium.org/2712313002 . Cr-Commit-Position: refs/branch-heads/2987@{#689} Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943} [add] https://crrev.com/12901a927913176a7c998f918e21b761608aaedc/third_party/WebKit/LayoutTests/fast/forms/text/text-change-event-after-clear-in-submit.html [modify] https://crrev.com/12901a927913176a7c998f918e21b761608aaedc/third_party/WebKit/Source/core/html/HTMLInputElement.cpp
,
Mar 1 2017
Rechecked this issue on chrome version 57.0.2987.88 on Windows 10, 7, fix is working as intended. Entered value is displayed twice in the log. Thanks.! |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by woxxom@gmail.com
, Feb 23 2017