New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 695315 link

Starred by 3 users
Status: Fixed
Owner:
dominickn@chromium.org
Closed: Feb 2017
Cc:
█ raymes@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac
Pri: 3
Type: Task



Sign in to add a comment

Replace enums with enum classes in permissions code

Project Member Reported by dominickn@chromium.org, Feb 23 2017 
Permissions code currently uses a mix of enums and enum classes, with many unspecified constants (like GRANTED or DENIED) scattered around. We should consolidate everything into enum classes. This will:

1. require full qualification of each enum class type (good for readability)
2. require a static_cast<int> when recording metrics (minor downside)
Project Member

Comment 1 by bugdroid1@chromium.org, Feb 23 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2e27deaf15dd4cd8462c122479c7c15f69faa80d

commit 2e27deaf15dd4cd8462c122479c7c15f69faa80d
Author: dominickn <dominickn@chromium.org>
Date: Thu Feb 23 23:00:25 2017

Replace all enums with enum classes in permissions code.

This CL removes all unqualified enums in permissions code and replaces
them with enum classes. This improves readability, at the small cost of
requiring static_cast<int> when recording UMA metrics.

BUG= 695315 
TBR=nparker@chromium.org

Review-Url: https://codereview.chromium.org/2715643002
Cr-Commit-Position: refs/heads/master@{#452663}

[modify] https://crrev.com/2e27deaf15dd4cd8462c122479c7c15f69faa80d/chrome/browser/permissions/permission_context_base_unittest.cc
[modify] https://crrev.com/2e27deaf15dd4cd8462c122479c7c15f69faa80d/chrome/browser/permissions/permission_decision_auto_blocker_unittest.cc
[modify] https://crrev.com/2e27deaf15dd4cd8462c122479c7c15f69faa80d/chrome/browser/permissions/permission_infobar_delegate.cc
[modify] https://crrev.com/2e27deaf15dd4cd8462c122479c7c15f69faa80d/chrome/browser/permissions/permission_queue_controller.cc
[modify] https://crrev.com/2e27deaf15dd4cd8462c122479c7c15f69faa80d/chrome/browser/permissions/permission_uma_util.cc
[modify] https://crrev.com/2e27deaf15dd4cd8462c122479c7c15f69faa80d/chrome/browser/permissions/permission_uma_util.h
[modify] https://crrev.com/2e27deaf15dd4cd8462c122479c7c15f69faa80d/chrome/browser/permissions/permission_util.h
[modify] https://crrev.com/2e27deaf15dd4cd8462c122479c7c15f69faa80d/chrome/browser/permissions/permission_util_unittest.cc
[modify] https://crrev.com/2e27deaf15dd4cd8462c122479c7c15f69faa80d/chrome/browser/safe_browsing/permission_reporter.cc
[modify] https://crrev.com/2e27deaf15dd4cd8462c122479c7c15f69faa80d/chrome/browser/safe_browsing/permission_reporter_unittest.cc

Comment 2 by dominickn@chromium.org, Feb 27 2017

Status: Fixed (was: Started)
►

Sign in to add a comment