New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 695314 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Closed: Feb 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Failed steps failed compile on MAC trunk for official desktop continuous builder

Project Member Reported by ranjitkan@chromium.org, Feb 23 2017

Issue description

Link to Builds:
===============
https://uberchromegw.corp.google.com/i/official.desktop.continuous/builders/mac%20trunk/builds/46153

Link to Log File:
=================
https://uberchromegw.corp.google.com/i/official.desktop.continuous/builders/mac%20trunk/builds/46153/steps/compile/logs/stdio

Error from the Log:
===================
FAILED: obj/third_party/crashpad/crashpad/handler/handler_lib/handler_main.o 
export DEVELOPER_DIR=/b/build/slave/mac_trunk/build/src/build/mac_files/Xcode.app;  ../../third_party/llvm-build/Release+Asserts/bin/clang++ -MMD -MF obj/third_party/crashpad/crashpad/handler/handler_lib/handler_main.o.d -DV8_DEPRECATION_WARNINGS -DNO_TCMALLOC -DUSE_EXTERNAL_POPUP_MENU=1 -DFULL_SAFE_BROWSING -DSAFE_BROWSING_CSD -DSAFE_BROWSING_DB_LOCAL -DOFFICIAL_BUILD -DGOOGLE_CHROME_BUILD -DENABLE_MEDIA_ROUTER=1 -DCR_CLANG_REVISION=\"289944-2\" -DCR_XCODE_VERSION=0511 -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D_FORTIFY_SOURCE=2 -D__ASSERT_MACROS_DEFINE_VERSIONS_WITHOUT_UNDERSCORE=0 -DNDEBUG -DNVALGRIND -DDYNAMIC_ANNOTATIONS_ENABLED=0 -I../../third_party/crashpad/crashpad -I../.. -Igen -I../../third_party/crashpad/crashpad/compat/non_win -I../../third_party/crashpad/crashpad/compat/mac -I../../third_party/crashpad/crashpad/compat/non_cxx11_lib -fno-strict-aliasing -fstack-protector -fcolor-diagnostics -arch x86_64 -Wall -Werror -Wextra -Wpartial-availability -Wno-missing-field-initializers -Wno-unused-parameter -Wno-c++11-narrowing -Wno-covered-switch-default -Wno-deprecated-register -Wno-unneeded-internal-declaration -Wno-inconsistent-missing-override -Wno-shift-negative-value -Wno-undefined-var-template -Wno-nonportable-include-path -Wno-address-of-packed-member -Wno-block-capture-autoreleasing -O2 -gdwarf-2 -fno-standalone-debug -isysroot /b/build/slave/mac_trunk/build/src/build/mac_files/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.10.sdk -mmacosx-version-min=10.9 -fvisibility=hidden -Xclang -load -Xclang ../../third_party/llvm-build/Release+Asserts/lib/libFindBadConstructs.dylib -Xclang -add-plugin -Xclang find-bad-constructs -Wheader-hygiene -Wstring-conversion -Wtautological-overlap-compare -fvisibility-inlines-hidden -std=c++11 -stdlib=libc++ -fno-rtti -fno-exceptions -c ../../third_party/crashpad/crashpad/handler/handler_main.cc -o obj/third_party/crashpad/crashpad/handler/handler_lib/handler_main.o
../../third_party/crashpad/crashpad/handler/handler_main.cc:166:7: error: unused variable 'rv' [-Werror,-Wunused-variable]
  int rv = sigaction(sig, &sa, nullptr);
      ^
../../third_party/crashpad/crashpad/handler/handler_main.cc:241:9: error: unused variable 'rv' [-Werror,-Wunused-variable]
    int rv = raise(sig);
        ^
../../third_party/crashpad/crashpad/handler/handler_main.cc:254:7: error: unused variable 'rv' [-Werror,-Wunused-variable]
  int rv = raise(sig);
      ^
Suspecting below change could be a possible culprit:

https://chromium.googlesource.com/chromium/src/+/c4d7eaed0fcac839f1fd4f2a763bcb1ee52fd227

@ mark: Kindly look into it. Please help us to find an owner of not with respect to your change.

Thanks.!
 
 

Comment 1 by mark@chromium.org, Feb 23 2017

I can ALLOW_UNUSED_LOCAL these as a quick fix, but they’re not unused. DPLOG_IF may be broken.

Comment 3 by mark@chromium.org, Feb 23 2017

I guess that this is intentional because logging.h says this

// If !DCHECK_IS_ON(), we want to avoid emitting any references to |condition|
// (which may reference a variable defined only if DCHECK_IS_ON()).
// Contrast this with DCHECK et al., which has different behavior.

I sent https://codereview.chromium.org/2716563002/ to the CQ as TBR because this has broken the official build, but a review would be appreciated.

Comment 5 by mark@chromium.org, Feb 23 2017

Status: Fixed (was: Assigned)
Got reverted at https://codereview.chromium.org/2705373005/, instead

Comment 6 by cda...@chromium.org, Feb 24 2017

Status: Verified (was: Fixed)
Verified next builds are passing.https://uberchromegw.corp.google.com/i/official.desktop.continuous/builders/mac%20trunk/builds/46161

Sign in to add a comment