New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 695307 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Mar 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug



Sign in to add a comment

Starting WebPage Downloads at Startup

Project Member Reported by romax@chromium.org, Feb 23 2017

Issue description

start the pending offline page downloads when chrome starts. it was waiting for the scheduler based on gcm network manager to wake up, which isn't a good user experience since they're expecting those pending downloads would auto restart. it doesn't affect paused downloads.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 3 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5ca7b6b81b7dfb267481b28728d36ac3cef4b87c

commit 5ca7b6b81b7dfb267481b28728d36ac3cef4b87c
Author: romax <romax@chromium.org>
Date: Fri Mar 03 19:57:03 2017

[Offline Pages] Resume pending requests when chrome starts.

Resume pending download requests for offline pages when chrome starts by
calling startImmediateProcessing. This should only work for user-requested
downloads.

BUG= 695307 

Review-Url: https://codereview.chromium.org/2714693003
Cr-Commit-Position: refs/heads/master@{#454655}

[modify] https://crrev.com/5ca7b6b81b7dfb267481b28728d36ac3cef4b87c/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/downloads/OfflinePageDownloadBridge.java
[modify] https://crrev.com/5ca7b6b81b7dfb267481b28728d36ac3cef4b87c/chrome/browser/android/offline_pages/downloads/offline_page_download_bridge.cc
[modify] https://crrev.com/5ca7b6b81b7dfb267481b28728d36ac3cef4b87c/chrome/browser/android/offline_pages/downloads/offline_page_download_bridge.h

Comment 2 by romax@chromium.org, Mar 3 2017

Status: Fixed (was: Started)

Comment 3 by romax@chromium.org, Mar 20 2017

Labels: Merge-Request-58 M-58
Project Member

Comment 4 by sheriffbot@chromium.org, Mar 20 2017

Labels: -Merge-Request-58 Hotlist-Merge-Approved Merge-Approved-58
Your change meets the bar and is auto-approved for M58. Please go ahead and merge the CL to branch 3029 manually. Please contact milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), bhthompson@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 5 by sheriffbot@chromium.org, Mar 24 2017

Cc: keta...@chromium.org bhthompson@google.com ketakid@google.com vsu...@chromium.org
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 6 by romax@chromium.org, Mar 24 2017

Labels: -Hotlist-Merge-Approved -Merge-Approved-58
with git find-release:
commit 5ca7b6b81b7d was:
  initially in 59.0.3030.0
  merged to 58.0.3029.30

i think this is safe to remove the merge-approved label.

Sign in to add a comment