New issue
Advanced search Search tips

Issue 695286 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Feb 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

SpellCheckerTest.SpellCheckDoesNotCauseUpdateLayout doesn't work correctly

Project Member Reported by xiaoche...@chromium.org, Feb 23 2017

Issue description

The unit test is for checking the behavior of spell checker, which requires spell checking to be enabled.

However, the test is run with spell checking disabled, as EditingTestBase is setup with an empty SpellCheckClient.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Feb 23 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5a9a2764673ac595836bb6cc67237ae60c3aa0bf

commit 5a9a2764673ac595836bb6cc67237ae60c3aa0bf
Author: xiaochengh <xiaochengh@chromium.org>
Date: Thu Feb 23 07:43:42 2017

Ensure spell checking is enabled in SpellCheckerTest

This patch introduces SpellCheckTestBase, which sets up a non-empty
SpellCheckerClient that enables spell checking, so that
SpellCheckerTest can utilize this base class to correctly perform
unit tests that requires spell checking to be enabled.

The new base class will also be useful when adding unit test for
idle time spell checker.

This patch also removes spell checking related stuff from
TextFormControlElementTest, since it is leftover after we previously
moved a spell checking unit test from TextFromControlElementTest to
SpellCheckerTest.

BUG= 695286 

Review-Url: https://codereview.chromium.org/2711053002
Cr-Commit-Position: refs/heads/master@{#452427}

[modify] https://crrev.com/5a9a2764673ac595836bb6cc67237ae60c3aa0bf/third_party/WebKit/Source/core/editing/BUILD.gn
[modify] https://crrev.com/5a9a2764673ac595836bb6cc67237ae60c3aa0bf/third_party/WebKit/Source/core/editing/EditingTestBase.cpp
[modify] https://crrev.com/5a9a2764673ac595836bb6cc67237ae60c3aa0bf/third_party/WebKit/Source/core/editing/EditingTestBase.h
[add] https://crrev.com/5a9a2764673ac595836bb6cc67237ae60c3aa0bf/third_party/WebKit/Source/core/editing/spellcheck/SpellCheckTestBase.cpp
[add] https://crrev.com/5a9a2764673ac595836bb6cc67237ae60c3aa0bf/third_party/WebKit/Source/core/editing/spellcheck/SpellCheckTestBase.h
[modify] https://crrev.com/5a9a2764673ac595836bb6cc67237ae60c3aa0bf/third_party/WebKit/Source/core/editing/spellcheck/SpellCheckerTest.cpp

Labels: M-58
Status: Fixed (was: Assigned)

Sign in to add a comment