New issue
Advanced search Search tips

Issue 695284 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Jul 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug



Sign in to add a comment

Clearing Chrome's data causes associated WebAPKs to open as Chrome tabs

Project Member Reported by sbirch@chromium.org, Feb 23 2017

Issue description

I know this was an issue with shortcut-based A2HS, but I thought that WebAPKs would be OK -- IIRC there's no state in Chrome needed to verify a WebAPK (just the signature.) Is this WAI?
 
In order to check whether WebAPKs are enabled we need native. So we cache whether WebAPKs are enabled in preferences. When a user "Clears all data" this preference gets cleared too.

After a user "Clears all data", WebAPKs will start in a tab the first time (unless the user has launched Chrome after "Clearing all Data") and start as a WebAPK every subsequent time

Once we get rid of the variations experiment WebAPKs will start as WebAPKs after a user has "Cleared all Data" even if Chrome was not launched after the user "Cleared all Data"
Status: WontFix (was: Assigned)

Comment 3 by sbirch@chromium.org, Feb 27 2017

Thanks Peter!
Status: Available (was: WontFix)
Reopenign this bug. This is definitely a user annoyance. Leaving it available so that we don't loose track of it.
Labels: -Pri-2 M-61 Pri-1
Status: Started (was: Available)
Peter mentioned a CL to do this in the works
Project Member

Comment 6 by bugdroid1@chromium.org, Jul 6 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/001f557bcaa2a1064874b69e67b1e30c2688cad0

commit 001f557bcaa2a1064874b69e67b1e30c2688cad0
Author: pkotwicz <pkotwicz@chromium.org>
Date: Thu Jul 06 20:05:43 2017

[Android WebAPK] Make variations only control whether WebAPKs can be installed

Previously, variations controlled whether:
- WebAPKs could be installed
- Already installed WebAPKs would open as WebAPKs

This CL makes variations only control whether WebAPKs can be installed

BUG=738133, 739497,  695284 

Review-Url: https://codereview.chromium.org/2965233003
Cr-Commit-Position: refs/heads/master@{#484722}

[modify] https://crrev.com/001f557bcaa2a1064874b69e67b1e30c2688cad0/chrome/android/java/src/org/chromium/chrome/browser/ServiceTabLauncher.java
[modify] https://crrev.com/001f557bcaa2a1064874b69e67b1e30c2688cad0/chrome/android/java/src/org/chromium/chrome/browser/ShortcutHelper.java
[modify] https://crrev.com/001f557bcaa2a1064874b69e67b1e30c2688cad0/chrome/android/java/src/org/chromium/chrome/browser/externalnav/ExternalNavigationHandler.java
[modify] https://crrev.com/001f557bcaa2a1064874b69e67b1e30c2688cad0/chrome/android/java/src/org/chromium/chrome/browser/init/ProcessInitializationHandler.java
[modify] https://crrev.com/001f557bcaa2a1064874b69e67b1e30c2688cad0/chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationPlatformBridge.java
[modify] https://crrev.com/001f557bcaa2a1064874b69e67b1e30c2688cad0/chrome/android/java/src/org/chromium/chrome/browser/webapps/ChromeWebApkHost.java
[modify] https://crrev.com/001f557bcaa2a1064874b69e67b1e30c2688cad0/chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappLauncherActivity.java
[modify] https://crrev.com/001f557bcaa2a1064874b69e67b1e30c2688cad0/chrome/android/javatests/src/org/chromium/chrome/browser/externalnav/ExternalNavigationHandlerTest.java
[modify] https://crrev.com/001f557bcaa2a1064874b69e67b1e30c2688cad0/chrome/android/junit/src/org/chromium/chrome/browser/webapps/WebApkUpdateManagerTest.java

Status: Fixed (was: Started)

Sign in to add a comment