New issue
Advanced search Search tips

Issue 695281 link

Starred by 3 users

Issue metadata

Status: Verified
Owner:
Closed: Mar 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug


Participants' hotlists:
Fixing-touch


Sign in to add a comment

"rotation lock" state sometimes gets lost when switching between tablet<->clamshell mode

Project Member Reported by osh...@chromium.org, Feb 23 2017

Issue description

ToT: 58.x

see attached video. One is for working state, and anther one for not working state.
 

Comment 2 by zork@chromium.org, Mar 21 2017

Owner: zork@chromium.org

Comment 3 by osh...@chromium.org, Mar 22 2017

Owner: osh...@chromium.org
This behavior will be changed as a part of  crbug.com/683456 , so let me work on this.

Comment 4 by osh...@chromium.org, Mar 23 2017

Status: Started (was: Assigned)
Project Member

Comment 5 by bugdroid1@chromium.org, Mar 24 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/28bd8173b80ae1fe5e22875580051664cd97363d

commit 28bd8173b80ae1fe5e22875580051664cd97363d
Author: oshima <oshima@chromium.org>
Date: Fri Mar 24 19:00:26 2017

Remember User locked rotation

* Save when the toggle state changes, as that's
 only time the value changes.
* implement reverse lock.

BUG= 695281 ,  683456 
TEST=manual, covered by unit test

Review-Url: https://codereview.chromium.org/2773013003
Cr-Commit-Position: refs/heads/master@{#459502}

[modify] https://crrev.com/28bd8173b80ae1fe5e22875580051664cd97363d/ash/display/display_manager_unittest.cc
[modify] https://crrev.com/28bd8173b80ae1fe5e22875580051664cd97363d/ash/display/screen_orientation_controller_chromeos.cc
[modify] https://crrev.com/28bd8173b80ae1fe5e22875580051664cd97363d/ash/system/chromeos/rotation/tray_rotation_lock_unittest.cc

Comment 6 by osh...@chromium.org, Mar 24 2017

Labels: Merge-Request-58
Project Member

Comment 7 by sheriffbot@chromium.org, Mar 25 2017

Labels: -Merge-Request-58 Hotlist-Merge-Approved Merge-Approved-58
Your change meets the bar and is auto-approved for M58. Please go ahead and merge the CL to branch 3029 manually. Please contact milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), bhthompson@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 8 by bugdroid1@chromium.org, Mar 27 2017

Labels: -merge-approved-58 merge-merged-3029
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/18462f6c9998579452ba3f6531170f8bb14f38c1

commit 18462f6c9998579452ba3f6531170f8bb14f38c1
Author: Mitsuru Oshima <oshima@chromium.org>
Date: Mon Mar 27 19:35:09 2017

Remember User locked rotation

* Save when the toggle state changes, as that's
 only time the value changes.
* implement reverse lock.

BUG= 695281 ,  683456 
TEST=manual, covered by unit test

Review-Url: https://codereview.chromium.org/2773013003
Cr-Commit-Position: refs/heads/master@{#459502}
(cherry picked from commit 28bd8173b80ae1fe5e22875580051664cd97363d)
(cherry picked from commit ffb46dd77d7c4702110bf9dd6f3a9d35f70b41e5)

Review-Url: https://codereview.chromium.org/2777163003 .
Cr-Commit-Position: refs/branch-heads/3029@{#437}
Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471}

[modify] https://crrev.com/18462f6c9998579452ba3f6531170f8bb14f38c1/ash/display/display_manager_unittest.cc
[modify] https://crrev.com/18462f6c9998579452ba3f6531170f8bb14f38c1/ash/display/screen_orientation_controller_chromeos.cc
[modify] https://crrev.com/18462f6c9998579452ba3f6531170f8bb14f38c1/ash/system/chromeos/rotation/tray_rotation_lock_unittest.cc

Comment 9 by osh...@chromium.org, Mar 27 2017

Status: Fixed (was: Started)
Status: Verified (was: Fixed)
verified on 58.0.3029.51

Sign in to add a comment