[root layer scrolls] broken scrollbar on google.com |
||||||
Issue descriptionRepro on Linux ToT: 1. Run content_shell --root-layer-scrolls 2. Click the down stepper arrow Expected: page scrolls down Actual: nothing happens
,
Feb 23 2017
Happy to take this!
,
Feb 24 2017
Interestingly mousewheel scrolling works, just not clicking the button
,
Feb 25 2017
In this code in PaintLayerScrollableArea::maximumScrollOffsetInt:
if (this == controller.rootScrollerArea())
visibleSize = controller.rootScrollerVisibleArea();
controller.rootScrollerVisibleArea does not take the existance of the horizontal scrollbar into account (empirically). I guess that makes sense because it uses view()->visibleContentSize(ExcludeScrollbars) but the FrameView does not have scrollbars anymore. Maybe we need to subtract the scrollbar size separately?
,
Feb 25 2017
,
Feb 25 2017
Yeah, reverting that patch fixes this bug.
,
Feb 25 2017
Maybe TDRSC::rootScrollerVisibleArea needs to do view()->layoutViewportScrollableArea()->visibleContentSize(ExcludeScrollbars).
,
Feb 25 2017
Oh, I didn't know that was a thing. I can try that. (Assume you mean visibleContentRect)
,
Feb 25 2017
https://codereview.chromium.org/2713353002/ fixes this bug
,
Mar 14 2017
,
Jun 1 2017
,
Jun 4 2017
Somehow PLSA::VisibleContentRect has been inverting the semantics of scrollbar_inclusion since the dawn of time (http://crrev.com/885d16e4). We'll have to fix that in order for TDRSC::RootScrollerVisibleArea to get the right value.
,
Jun 9 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a0083d3b950116054ca29d0c457d311c2cfb309b commit a0083d3b950116054ca29d0c457d311c2cfb309b Author: Steve Kobes <skobes@chromium.org> Date: Fri Jun 09 20:48:45 2017 Fix treatment of scrollbar_inclusion in PLSA::VisibleContentRect. It was swapping the meanings of kIncludeScrollbars and kExcludeScrollbars. Bug: 695257 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I9b7fc394e79253c7dd04375bf2d2b92cdbadc25f Reviewed-on: https://chromium-review.googlesource.com/528340 Reviewed-by: Stefan Zager <szager@chromium.org> Commit-Queue: Steve Kobes <skobes@chromium.org> Cr-Commit-Position: refs/heads/master@{#478405} [modify] https://crrev.com/a0083d3b950116054ca29d0c457d311c2cfb309b/third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.cpp [modify] https://crrev.com/a0083d3b950116054ca29d0c457d311c2cfb309b/third_party/WebKit/Source/core/paint/ScrollableAreaPainter.cpp
,
Jun 14 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/dcb75b204e4e3a1eb1e3765a7bd158c811a6297a commit dcb75b204e4e3a1eb1e3765a7bd158c811a6297a Author: Steve Kobes <skobes@chromium.org> Date: Wed Jun 14 05:17:36 2017 Use the correct layout viewport in TDRSC::RootScrollerVisibleArea. This fixes incorrect computation of root PLSA scroll bounds when scrollbars need to be excluded. (PLSA::MaximumScrollOffsetInt delegates to TDRSC.) Note that ResizeViewportAnchor wants the layout viewport to be clamped to the updated bounds during LocalFrameView::Resize. For this reason, we eagerly update the root PaintLayer size in LocalFrameView::ViewportSizeChanged. Bug: 695257 Change-Id: If3490fd15cb232d2e6d2be951377e484c8b77a72 Reviewed-on: https://chromium-review.googlesource.com/531934 Reviewed-by: Stefan Zager <szager@chromium.org> Commit-Queue: Steve Kobes <skobes@chromium.org> Cr-Commit-Position: refs/heads/master@{#479293} [modify] https://crrev.com/dcb75b204e4e3a1eb1e3765a7bd158c811a6297a/third_party/WebKit/Source/core/frame/LocalFrameView.cpp [modify] https://crrev.com/dcb75b204e4e3a1eb1e3765a7bd158c811a6297a/third_party/WebKit/Source/core/page/scrolling/TopDocumentRootScrollerController.cpp [modify] https://crrev.com/dcb75b204e4e3a1eb1e3765a7bd158c811a6297a/third_party/WebKit/Source/core/paint/PaintLayerTest.cpp
,
Jun 14 2017
|
||||||
►
Sign in to add a comment |
||||||
Comment 1 by skobes@chromium.org
, Feb 23 2017Owner: cbiesin...@chromium.org
Status: Assigned (was: Available)