BlobBytesConsumer leaking blobs |
||
Issue descriptionWhen debugging issue #688100 , I noticed two bugs in BlobBytesConsumer https://cs.chromium.org/chromium/src/third_party/WebKit/Source/modules/fetch/BlobBytesConsumer.cpp?q=BlobBytesConsumer&dr=CSs&l=55 Number 1: the m_blobURL isn't being saved to a member variable ever - so it can't be revoked and we don't know it's set. Number 2: Even if it was set correctly, the the URL is never revoked on a successful read. This means that the class leaks blobs.
,
Feb 24 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0486b0ab21ee916488a991e3654e00220f787ae8 commit 0486b0ab21ee916488a991e3654e00220f787ae8 Author: yhirano <yhirano@chromium.org> Date: Fri Feb 24 02:11:17 2017 Fix BlobBytesConsumer leak This CL fixes a BlobBytesConsumer leak caused by mis-setting blob URL and a lack of revokePublicBlobURL call. R=dmurph@chromium.org BUG= 695250 Review-Url: https://codereview.chromium.org/2702403007 Cr-Commit-Position: refs/heads/master@{#452715} [modify] https://crrev.com/0486b0ab21ee916488a991e3654e00220f787ae8/third_party/WebKit/Source/modules/fetch/BlobBytesConsumer.cpp
,
Feb 24 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0486b0ab21ee916488a991e3654e00220f787ae8 commit 0486b0ab21ee916488a991e3654e00220f787ae8 Author: yhirano <yhirano@chromium.org> Date: Fri Feb 24 02:11:17 2017 Fix BlobBytesConsumer leak This CL fixes a BlobBytesConsumer leak caused by mis-setting blob URL and a lack of revokePublicBlobURL call. R=dmurph@chromium.org BUG= 695250 Review-Url: https://codereview.chromium.org/2702403007 Cr-Commit-Position: refs/heads/master@{#452715} [modify] https://crrev.com/0486b0ab21ee916488a991e3654e00220f787ae8/third_party/WebKit/Source/modules/fetch/BlobBytesConsumer.cpp
,
Feb 24 2017
|
||
►
Sign in to add a comment |
||
Comment 1 by yhirano@chromium.org
, Feb 23 2017