New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 695236 link

Starred by 1 user
Status: Fixed
Owner:
█ kozyatinskiy@chromium.org
Last visit > 30 days ago
Closed: May 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Feature



Sign in to add a comment

[DevTools] green dots to rule them all

Project Member Reported by kozyatinskiy@chromium.org, Feb 22 2017 
Better continue to here.
Project Member

Comment 2 by bugdroid1@chromium.org, Feb 23 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/bdd23acd9253bf7ca1fd5763f8314d673e627c69

commit bdd23acd9253bf7ca1fd5763f8314d673e627c69
Author: machenbach <machenbach@chromium.org>
Date: Thu Feb 23 20:27:08 2017

Revert of [inspector] use BREAK_POSITION_ALIGNED for breakpoints (patchset #7 id:120001 of https://codereview.chromium.org/2709263002/ )

Reason for revert:
breaks layout tests:
https://build.chromium.org/p/client.v8.fyi/builders/V8-Blink%20Linux%2064/builds/13747

which blocks rolling. See also:
https://github.com/v8/v8/wiki/Blink-layout-tests

Original issue's description:
> [inspector] use BREAK_POSITION_ALIGNED for breakpoints
>
> With inline breakpoints DevTools are ready for break position aligned breakpoints instead of statement aligned.
>
> BUG= chromium:695236 
> R=dgozman@chromium.org,yangguo@chromium.org
>
> Review-Url: https://codereview.chromium.org/2709263002
> Cr-Commit-Position: refs/heads/master@{#43385}
> Committed: https://chromium.googlesource.com/v8/v8/+/2fed7a0090b316d77ebbf509d2cc98edd4b6ccf0

TBR=dgozman@chromium.org,yangguo@chromium.org,kozyatinskiy@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= chromium:695236 

Review-Url: https://codereview.chromium.org/2709313003
Cr-Commit-Position: refs/heads/master@{#43395}

[modify] https://crrev.com/bdd23acd9253bf7ca1fd5763f8314d673e627c69/src/debug/debug.cc
[modify] https://crrev.com/bdd23acd9253bf7ca1fd5763f8314d673e627c69/src/inspector/debugger-script.js
[modify] https://crrev.com/bdd23acd9253bf7ca1fd5763f8314d673e627c69/test/inspector/debugger/get-possible-breakpoints-expected.txt
[modify] https://crrev.com/bdd23acd9253bf7ca1fd5763f8314d673e627c69/test/inspector/debugger/get-possible-breakpoints.js
[modify] https://crrev.com/bdd23acd9253bf7ca1fd5763f8314d673e627c69/test/inspector/testcfg.py
Project Member

Comment 3 by bugdroid1@chromium.org, Feb 23 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c32079e66898f3d463f9ac8d83e16a119382a84b

commit c32079e66898f3d463f9ac8d83e16a119382a84b
Author: kozyatinskiy <kozyatinskiy@chromium.org>
Date: Thu Feb 23 23:19:58 2017

[DevTools] prepare getPossibleBreakpoints before rolling V8

New V8 will contain new flag for Debugger.getPossibleBreakpoints method, so replaced agent method call with invoke to make closure compiler happy during rolling.

BUG= chromium:695236 
R=dgozman@chromium.org

Review-Url: https://codereview.chromium.org/2712843004
Cr-Commit-Position: refs/heads/master@{#452669}

[modify] https://crrev.com/c32079e66898f3d463f9ac8d83e16a119382a84b/third_party/WebKit/Source/devtools/front_end/sdk/DebuggerModel.js
Project Member

Comment 5 by bugdroid1@chromium.org, Feb 27 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/4d7fa10c2bb08343417e448208976ab63cac08c6

commit 4d7fa10c2bb08343417e448208976ab63cac08c6
Author: kozyatinskiy <kozyatinskiy@chromium.org>
Date: Mon Feb 27 16:53:03 2017

[inspector] added restrictToFunction flag for getPossibleBreakpoints

BUG= chromium:695236 
R=dgozman@chromium.org,yangguo@chromium.org

Review-Url: https://codereview.chromium.org/2710953004
Cr-Commit-Position: refs/heads/master@{#43457}

[modify] https://crrev.com/4d7fa10c2bb08343417e448208976ab63cac08c6/src/api.cc
[modify] https://crrev.com/4d7fa10c2bb08343417e448208976ab63cac08c6/src/debug/debug-interface.h
[modify] https://crrev.com/4d7fa10c2bb08343417e448208976ab63cac08c6/src/debug/debug.cc
[modify] https://crrev.com/4d7fa10c2bb08343417e448208976ab63cac08c6/src/debug/debug.h
[modify] https://crrev.com/4d7fa10c2bb08343417e448208976ab63cac08c6/src/inspector/js_protocol.json
[modify] https://crrev.com/4d7fa10c2bb08343417e448208976ab63cac08c6/src/inspector/v8-debugger-agent-impl.cc
[modify] https://crrev.com/4d7fa10c2bb08343417e448208976ab63cac08c6/src/inspector/v8-debugger-agent-impl.h
[modify] https://crrev.com/4d7fa10c2bb08343417e448208976ab63cac08c6/src/inspector/v8-debugger-script.cc
[modify] https://crrev.com/4d7fa10c2bb08343417e448208976ab63cac08c6/src/inspector/v8-debugger-script.h
[add] https://crrev.com/4d7fa10c2bb08343417e448208976ab63cac08c6/test/inspector/debugger/get-possible-breakpoints-restrict-to-function-expected.txt
[add] https://crrev.com/4d7fa10c2bb08343417e448208976ab63cac08c6/test/inspector/debugger/get-possible-breakpoints-restrict-to-function.js
Project Member

Comment 7 by bugdroid1@chromium.org, Mar 3 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9c2c178bf2d446aefeb2b7a24c7cf55856e10b0d

commit 9c2c178bf2d446aefeb2b7a24c7cf55856e10b0d
Author: kozyatinskiy <kozyatinskiy@chromium.org>
Date: Fri Mar 03 02:56:01 2017

[DevTools] 'Continue to location markers' should be always correctly shown

We should follow inline values behavior and independently when setExecutionLocation was called - currently show markers.

BUG= chromium:695236 
R=lushnikov@chromium.org

Review-Url: https://codereview.chromium.org/2729773005
Cr-Commit-Position: refs/heads/master@{#454484}

[modify] https://crrev.com/9c2c178bf2d446aefeb2b7a24c7cf55856e10b0d/third_party/WebKit/Source/devtools/front_end/sources/JavaScriptSourceFrame.js
Project Member

Comment 8 by bugdroid1@chromium.org, Mar 7 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2872795e2d339145662df47540fefdb430331ce1

commit 2872795e2d339145662df47540fefdb430331ce1
Author: kozyatinskiy <kozyatinskiy@chromium.org>
Date: Tue Mar 07 17:29:05 2017

[DevTools] move green dots further

- first special green dot ability.

BUG= chromium:432469 , chromium:695236 
R=pfeldman@chromium.org,dgozman@chromium.org

Review-Url: https://codereview.chromium.org/2726183003
Cr-Commit-Position: refs/heads/master@{#455116}

[modify] https://crrev.com/2872795e2d339145662df47540fefdb430331ce1/third_party/WebKit/Source/devtools/front_end/Images/smallIcons.png
[modify] https://crrev.com/2872795e2d339145662df47540fefdb430331ce1/third_party/WebKit/Source/devtools/front_end/Images/smallIcons_2x.png
[modify] https://crrev.com/2872795e2d339145662df47540fefdb430331ce1/third_party/WebKit/Source/devtools/front_end/Images/src/optimize_png.hashes
[modify] https://crrev.com/2872795e2d339145662df47540fefdb430331ce1/third_party/WebKit/Source/devtools/front_end/Images/src/smallIcons.svg
[modify] https://crrev.com/2872795e2d339145662df47540fefdb430331ce1/third_party/WebKit/Source/devtools/front_end/Images/src/svg2png.hashes
[modify] https://crrev.com/2872795e2d339145662df47540fefdb430331ce1/third_party/WebKit/Source/devtools/front_end/bindings/BreakpointManager.js
[modify] https://crrev.com/2872795e2d339145662df47540fefdb430331ce1/third_party/WebKit/Source/devtools/front_end/sdk/DebuggerModel.js
[modify] https://crrev.com/2872795e2d339145662df47540fefdb430331ce1/third_party/WebKit/Source/devtools/front_end/sources/JavaScriptSourceFrame.js
[modify] https://crrev.com/2872795e2d339145662df47540fefdb430331ce1/third_party/WebKit/Source/devtools/front_end/ui/Icon.js
Project Member

Comment 9 by bugdroid1@chromium.org, Mar 10 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/921d5298e10e7010e3609f5608e060cfac761ef7

commit 921d5298e10e7010e3609f5608e060cfac761ef7
Author: kozyatinskiy <kozyatinskiy@chromium.org>
Date: Fri Mar 10 21:45:01 2017

[DevTools] chaotic green dots displacement fix

With the experiment, we see the markers for a brief second before they are
immediately removed without any user intervention.  This CL fixes the race.

BUG= chromium:695236 
R=luoe@chromium.org,lushnikov@chromium.org

Review-Url: https://codereview.chromium.org/2742653003
Cr-Commit-Position: refs/heads/master@{#456174}

[modify] https://crrev.com/921d5298e10e7010e3609f5608e060cfac761ef7/third_party/WebKit/Source/devtools/front_end/sources/JavaScriptSourceFrame.js

Comment 10 by kozyatinskiy@chromium.org, May 19 2017

Status: Fixed (was: Assigned)
►

Sign in to add a comment