New issue
Advanced search Search tips

Issue 695235 link

Starred by 1 user

Issue metadata

Status: Archived
Owner:
Closed: Jun 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

[Bootstrapping] Send meaningful error code/message from Slave device to Master device to help diagnose

Project Member Reported by x...@chromium.org, Feb 22 2017

Issue description

Per offline chat with agawronska@:
Enrollment failure should come with some error code, so we can display meaningful information to the user why enrollment fail and how to recover.
Right now it is totally blackbox. The failure might be temporary connectivity on Slave or problem with FRE record that won't go away with time. 

Proposed change:
Send [error code, error message] to Master using following convention:
[0, "no error"]
[1*, "network error"]
[2*, "authentication error"], e.g., [21, "Service unavailable"], ...
[3*, "enrollment error"], e.g., [31, "DMserver registration error"], [32, "Policy validation error"], ...
[4*, "other error"]
 
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 23 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a6c5fb0be53c19f15c3f134a8d2f2e760e83c421

commit a6c5fb0be53c19f15c3f134a8d2f2e760e83c421
Author: xdai <xdai@chromium.org>
Date: Thu Mar 23 17:31:44 2017

Bootstrapping: Display meaningful enrollment error message on Slave device.

Enrollment failure is a blackbox right now. We should display meaningful
information to the user why enrollment failed and how to recover.

BUG= 695235 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2771623002
Cr-Commit-Position: refs/heads/master@{#459129}

[modify] https://crrev.com/a6c5fb0be53c19f15c3f134a8d2f2e760e83c421/chrome/browser/chromeos/login/screens/host_pairing_screen.cc
[modify] https://crrev.com/a6c5fb0be53c19f15c3f134a8d2f2e760e83c421/chrome/browser/chromeos/login/screens/host_pairing_screen.h
[modify] https://crrev.com/a6c5fb0be53c19f15c3f134a8d2f2e760e83c421/chrome/browser/chromeos/login/screens/host_pairing_screen_view.cc
[modify] https://crrev.com/a6c5fb0be53c19f15c3f134a8d2f2e760e83c421/chrome/browser/chromeos/login/screens/host_pairing_screen_view.h
[modify] https://crrev.com/a6c5fb0be53c19f15c3f134a8d2f2e760e83c421/chrome/browser/resources/chromeos/login/host-pairing-screen.html
[modify] https://crrev.com/a6c5fb0be53c19f15c3f134a8d2f2e760e83c421/chrome/browser/resources/chromeos/login/host-pairing-screen.js
[modify] https://crrev.com/a6c5fb0be53c19f15c3f134a8d2f2e760e83c421/chrome/browser/ui/webui/chromeos/login/host_pairing_screen_handler.cc
[modify] https://crrev.com/a6c5fb0be53c19f15c3f134a8d2f2e760e83c421/chrome/browser/ui/webui/chromeos/login/host_pairing_screen_handler.h

Comment 2 by x...@chromium.org, Jun 20 2017

Status: Fixed (was: Assigned)
https://codereview.chromium.org/2890383003/ has been landed. Not sure why it didn't update the bug here. 

With the CL in place, the enrollment error message can now be sent from the Slave device to the Master device following the convention defined in the bug description. 

Comment 3 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Sign in to add a comment