Issue metadata
Sign in to add a comment
|
MD Settings: Cros: Direct navigaton to chrome://md-settings/pointer-overlay not working. |
||||||||||||||||||||||
Issue descriptionRepro steps: Paste chrome://md-settings/pointer-overlay into the omnibox and navigate. Expected: Navigation succeeds and user is forwarded to the "Mouse and Touchpad" settings subpage. Actual: A redirect to chrome://md-settings/device happens. Note that navigating via clicking works as expected.
,
Feb 22 2017
We explicitly handled this condition by checking that the mouse and touchpad status have actually been received from the browser before deciding whether to close the subpage (if you navigated directly to it). As of https://codereview.chromium.org/2644713002, hasMouse_ and hasTouchpad_ on settings-device-page are given a default value of |false| so we immediately close the page unconditionally. (Note the comment above hasMouse_ that is now untrue.) jdufault@ do you recall why these properties were given default values?
,
Feb 22 2017
That was my fault, based on my bad experiences with https://github.com/Polymer/polymer/issues/2447 We probably need to change the logic for when we automatically close the subpage.
,
Feb 23 2017
,
Feb 28 2017
,
Mar 1 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/186f899c6201f18f98e56c640c97430063906d4d commit 186f899c6201f18f98e56c640c97430063906d4d Author: stevenjb <stevenjb@chromium.org> Date: Wed Mar 01 05:39:02 2017 MD Settings: Device: fix initialization BUG= 695201 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2727443003 Cr-Commit-Position: refs/heads/master@{#453856} [modify] https://crrev.com/186f899c6201f18f98e56c640c97430063906d4d/chrome/browser/resources/settings/device_page/device_page.js
,
Mar 1 2017
,
Mar 22 2017
Verified Chrome OS version 58.0.3029.31/934.18.0 kevin |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by steve...@chromium.org
, Feb 22 2017Labels: M-58
Owner: steve...@chromium.org
Status: Assigned (was: Untriaged)