New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 695197 link

Starred by 1 user
Status: Fixed
Owner:
█ eostroukhov@chromium.org
Last visit > 30 days ago
Closed: May 2017
Cc:
█ krajshree@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug-Regression



Sign in to add a comment

DataGrid - text doesn't line up when DevTools are zoomed in/out

Reported by kdzwinel@gmail.com, Feb 22 2017 
UserAgent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_12_3) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/58.0.3020.0 Safari/537.36

Steps to reproduce the problem:
1. Go to Application > Local Storage
2. Make sure there is some data in the grid
3. Zoom DevTools in or out (cmd + -, cmd + +)

What is the expected behavior?

What went wrong?
Table doesn't look correctly, text doesn't line up with rows (see screenshot)

Did this work before? Yes 56.0.2924.87

Chrome version: 58.0.3020.0  Channel: canary
OS Version: OS X 10.12.3
Flash Version: 

I was told that @eostroukhov was working on storage panels recently, maybe this is connected.
Screen Shot 2017-02-22 at 22.33.50.png
16.6 KB View Download

Comment 1 by nyerramilli@chromium.org, Feb 23 2017

Labels: Needs-Bisect Needs-Triage-M56

Comment 2 by krajshree@chromium.org, Feb 23 2017

Cc: krajshree@chromium.org
Labels: Needs-Feedback
Unable to reproduce the issue in Mac 10.12.2 using chrome reported version #58.0.3020.0 

Steps followed to reproduce the issue are as follows:
-----------
1. Navigated to test mail and opened dev tools.
2. Went to Application > Local Storage
3. Looked out for some data in the grid
4. Zoomed DevTools in and out (cmd + -, cmd + +)
5. Observed that text was in line up with rows.

Attaching screen cast and screenshot for reference

kdzwinel@ - Could you please provide any sample URL to test this issue.

Thanks...!!
695197.mp4
3.0 MB View Download
screenshot@devtools.png
23.6 KB View Download

Comment 3 by kdzwinel@gmail.com, Feb 23 2017 

Thanks for testing it! You are right, it doesn't happen on every website, I wasn't aware of that. Please test onet.pl (see screenshot).
Screen Shot 2017-02-23 at 07.37.53.png
88.3 KB View Download

Comment 4 by lushnikov@chromium.org, Feb 24 2017

Owner: eostroukhov@chromium.org
Status: Assigned (was: Unconfirmed)
Assigning to Eugene since he's already mentioned in this bug!
Project Member

Comment 5 by bugdroid1@chromium.org, May 25 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/35a7e7d29a36ec864267db7c057aa12aaa69b7ce

commit 35a7e7d29a36ec864267db7c057aa12aaa69b7ce
Author: eostroukhov <eostroukhov@chromium.org>
Date: Thu May 25 23:44:33 2017

[DevTools] Set row background instead of the table

BUG= 695197 

Review-Url: https://codereview.chromium.org/2894083002
Cr-Commit-Position: refs/heads/master@{#474845}

[modify] https://crrev.com/35a7e7d29a36ec864267db7c057aa12aaa69b7ce/third_party/WebKit/LayoutTests/inspector/components/datagrid-expected.txt
[modify] https://crrev.com/35a7e7d29a36ec864267db7c057aa12aaa69b7ce/third_party/WebKit/LayoutTests/inspector/components/datagrid.html
[modify] https://crrev.com/35a7e7d29a36ec864267db7c057aa12aaa69b7ce/third_party/WebKit/LayoutTests/inspector/components/viewport-datagrid-expected.txt
[modify] https://crrev.com/35a7e7d29a36ec864267db7c057aa12aaa69b7ce/third_party/WebKit/LayoutTests/inspector/components/viewport-datagrid.html
[modify] https://crrev.com/35a7e7d29a36ec864267db7c057aa12aaa69b7ce/third_party/WebKit/Source/devtools/front_end/console/ConsoleViewMessage.js
[modify] https://crrev.com/35a7e7d29a36ec864267db7c057aa12aaa69b7ce/third_party/WebKit/Source/devtools/front_end/cookie_table/CookiesTable.js
[modify] https://crrev.com/35a7e7d29a36ec864267db7c057aa12aaa69b7ce/third_party/WebKit/Source/devtools/front_end/data_grid/DataGrid.js
[modify] https://crrev.com/35a7e7d29a36ec864267db7c057aa12aaa69b7ce/third_party/WebKit/Source/devtools/front_end/data_grid/ViewportDataGrid.js
[modify] https://crrev.com/35a7e7d29a36ec864267db7c057aa12aaa69b7ce/third_party/WebKit/Source/devtools/front_end/data_grid/dataGrid.css
[modify] https://crrev.com/35a7e7d29a36ec864267db7c057aa12aaa69b7ce/third_party/WebKit/Source/devtools/front_end/network/EventSourceMessagesView.js
[modify] https://crrev.com/35a7e7d29a36ec864267db7c057aa12aaa69b7ce/third_party/WebKit/Source/devtools/front_end/resources/ApplicationCacheItemsView.js
[modify] https://crrev.com/35a7e7d29a36ec864267db7c057aa12aaa69b7ce/third_party/WebKit/Source/devtools/front_end/resources/DOMStorageItemsView.js
[modify] https://crrev.com/35a7e7d29a36ec864267db7c057aa12aaa69b7ce/third_party/WebKit/Source/devtools/front_end/resources/DatabaseQueryView.js
[modify] https://crrev.com/35a7e7d29a36ec864267db7c057aa12aaa69b7ce/third_party/WebKit/Source/devtools/front_end/resources/DatabaseTableView.js
[modify] https://crrev.com/35a7e7d29a36ec864267db7c057aa12aaa69b7ce/third_party/WebKit/Source/devtools/front_end/resources/IndexedDBViews.js
[modify] https://crrev.com/35a7e7d29a36ec864267db7c057aa12aaa69b7ce/third_party/WebKit/Source/devtools/front_end/resources/ServiceWorkerCacheViews.js
[modify] https://crrev.com/35a7e7d29a36ec864267db7c057aa12aaa69b7ce/third_party/WebKit/Source/devtools/front_end/resources/indexedDBViews.css
[modify] https://crrev.com/35a7e7d29a36ec864267db7c057aa12aaa69b7ce/third_party/WebKit/Source/devtools/front_end/resources/serviceWorkerCacheViews.css

Comment 6 by eostroukhov@chromium.org, May 25 2017

Status: Fixed (was: Assigned)

Comment 7 by eostroukhov@chromium.org, May 25 2017

Labels: -Needs-Feedback -Needs-Bisect -Needs-Triage-M56
►

Sign in to add a comment