Also rename LoadCommittedDetails.is_in_page

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a11672fb4c998040224d7dc97e5bdc05d46a4145

commit a11672fb4c998040224d7dc97e5bdc05d46a4145
Author: eugenebut <eugenebut@chromium.org>
Date: Tue Mar 07 17:13:51 2017

Renamed NavigationHandle::IsSamePage to NavigationHandle::IsSameDocument

Old name was presumable used to match was_within_same_page IPC, but
IsSameDocument name better reflects the the type of the navigation
(navigation did not change the document object).

This change will make naming more consistent with WebKit (which has
SameDocumentNavigationSource class) and Chrome for iOS, which uses
SameDocument term.

BUG= 695189 
TBR=dbeam@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2716493004
Cr-Commit-Position: refs/heads/master@{#455106}

[modify] https://crrev.com/a11672fb4c998040224d7dc97e5bdc05d46a4145/chrome/android/java/src/org/chromium/chrome/browser/ActivityTabTaskDescriptionHelper.java
[modify] https://crrev.com/a11672fb4c998040224d7dc97e5bdc05d46a4145/chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java
[modify] https://crrev.com/a11672fb4c998040224d7dc97e5bdc05d46a4145/chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/OverlayPanelContent.java
[modify] https://crrev.com/a11672fb4c998040224d7dc97e5bdc05d46a4145/chrome/android/java/src/org/chromium/chrome/browser/customtabs/PostMessageHandler.java
[modify] https://crrev.com/a11672fb4c998040224d7dc97e5bdc05d46a4145/chrome/android/java/src/org/chromium/chrome/browser/dom_distiller/ReaderModeManager.java
[modify] https://crrev.com/a11672fb4c998040224d7dc97e5bdc05d46a4145/chrome/android/java/src/org/chromium/chrome/browser/infobar/InfoBarContainer.java
[modify] https://crrev.com/a11672fb4c998040224d7dc97e5bdc05d46a4145/chrome/android/java/src/org/chromium/chrome/browser/media/ui/MediaSessionTabHelper.java
[modify] https://crrev.com/a11672fb4c998040224d7dc97e5bdc05d46a4145/chrome/android/java/src/org/chromium/chrome/browser/tab/EmptyTabObserver.java
[modify] https://crrev.com/a11672fb4c998040224d7dc97e5bdc05d46a4145/chrome/android/java/src/org/chromium/chrome/browser/tab/TabObserver.java
[modify] https://crrev.com/a11672fb4c998040224d7dc97e5bdc05d46a4145/chrome/android/java/src/org/chromium/chrome/browser/tab/TabStateBrowserControlsVisibilityDelegate.java
[modify] https://crrev.com/a11672fb4c998040224d7dc97e5bdc05d46a4145/chrome/android/java/src/org/chromium/chrome/browser/tab/TabWebContentsObserver.java
[modify] https://crrev.com/a11672fb4c998040224d7dc97e5bdc05d46a4145/chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarManager.java
[modify] https://crrev.com/a11672fb4c998040224d7dc97e5bdc05d46a4145/chrome/android/java/src/org/chromium/chrome/browser/webapps/FullScreenActivity.java
[modify] https://crrev.com/a11672fb4c998040224d7dc97e5bdc05d46a4145/chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappActivity.java
[modify] https://crrev.com/a11672fb4c998040224d7dc97e5bdc05d46a4145/chrome/android/javatests/src/org/chromium/chrome/browser/externalnav/UrlOverridingTest.java
[modify] https://crrev.com/a11672fb4c998040224d7dc97e5bdc05d46a4145/chrome/browser/android/offline_pages/background_loader_offliner.cc
[modify] https://crrev.com/a11672fb4c998040224d7dc97e5bdc05d46a4145/chrome/browser/android/offline_pages/offline_page_tab_helper.cc
[modify] https://crrev.com/a11672fb4c998040224d7dc97e5bdc05d46a4145/chrome/browser/android/offline_pages/recent_tab_helper.cc
[modify] https://crrev.com/a11672fb4c998040224d7dc97e5bdc05d46a4145/chrome/browser/banners/app_banner_manager.cc
[modify] https://crrev.com/a11672fb4c998040224d7dc97e5bdc05d46a4145/chrome/browser/chromeos/attestation/platform_verification_dialog.cc
[modify] https://crrev.com/a11672fb4c998040224d7dc97e5bdc05d46a4145/chrome/browser/content_settings/tab_specific_content_settings.cc
[modify] https://crrev.com/a11672fb4c998040224d7dc97e5bdc05d46a4145/chrome/browser/data_use_measurement/chrome_data_use_ascriber_service.cc
[modify] https://crrev.com/a11672fb4c998040224d7dc97e5bdc05d46a4145/chrome/browser/engagement/site_engagement_helper.cc
[modify] https://crrev.com/a11672fb4c998040224d7dc97e5bdc05d46a4145/chrome/browser/extensions/active_tab_permission_granter.cc
[modify] https://crrev.com/a11672fb4c998040224d7dc97e5bdc05d46a4145/chrome/browser/extensions/api/declarative_content/declarative_content_css_condition_tracker.cc
[modify] https://crrev.com/a11672fb4c998040224d7dc97e5bdc05d46a4145/chrome/browser/extensions/api/messaging/extension_message_port.cc
[modify] https://crrev.com/a11672fb4c998040224d7dc97e5bdc05d46a4145/chrome/browser/extensions/api/web_navigation/web_navigation_api.cc
[modify] https://crrev.com/a11672fb4c998040224d7dc97e5bdc05d46a4145/chrome/browser/extensions/extension_action_runner.cc
[modify] https://crrev.com/a11672fb4c998040224d7dc97e5bdc05d46a4145/chrome/browser/extensions/tab_helper.cc
[modify] https://crrev.com/a11672fb4c998040224d7dc97e5bdc05d46a4145/chrome/browser/extensions/webstore_inline_installer.cc
[modify] https://crrev.com/a11672fb4c998040224d7dc97e5bdc05d46a4145/chrome/browser/infobars/infobar_service.cc
[modify] https://crrev.com/a11672fb4c998040224d7dc97e5bdc05d46a4145/chrome/browser/installable/installable_manager.cc
[modify] https://crrev.com/a11672fb4c998040224d7dc97e5bdc05d46a4145/chrome/browser/metrics/first_web_contents_profiler.cc
[modify] https://crrev.com/a11672fb4c998040224d7dc97e5bdc05d46a4145/chrome/browser/page_load_metrics/metrics_web_contents_observer.cc
[modify] https://crrev.com/a11672fb4c998040224d7dc97e5bdc05d46a4145/chrome/browser/page_load_metrics/observers/google_captcha_observer.cc
[modify] https://crrev.com/a11672fb4c998040224d7dc97e5bdc05d46a4145/chrome/browser/permissions/permission_request_manager.cc
[modify] https://crrev.com/a11672fb4c998040224d7dc97e5bdc05d46a4145/chrome/browser/prerender/prerender_contents.cc
[modify] https://crrev.com/a11672fb4c998040224d7dc97e5bdc05d46a4145/chrome/browser/prerender/prerender_tab_helper.cc
[modify] https://crrev.com/a11672fb4c998040224d7dc97e5bdc05d46a4145/chrome/browser/previews/previews_infobar_tab_helper.cc
[modify] https://crrev.com/a11672fb4c998040224d7dc97e5bdc05d46a4145/chrome/browser/safe_browsing/client_side_detection_host.cc
[modify] https://crrev.com/a11672fb4c998040224d7dc97e5bdc05d46a4145/chrome/browser/ssl/security_state_tab_helper.cc
[modify] https://crrev.com/a11672fb4c998040224d7dc97e5bdc05d46a4145/chrome/browser/ssl/ssl_error_handler.cc
[modify] https://crrev.com/a11672fb4c998040224d7dc97e5bdc05d46a4145/chrome/browser/supervised_user/supervised_user_navigation_observer.cc
[modify] https://crrev.com/a11672fb4c998040224d7dc97e5bdc05d46a4145/chrome/browser/tab_contents/navigation_metrics_recorder.cc
[modify] https://crrev.com/a11672fb4c998040224d7dc97e5bdc05d46a4145/chrome/browser/ui/autofill/save_card_bubble_controller_impl.cc
[modify] https://crrev.com/a11672fb4c998040224d7dc97e5bdc05d46a4145/chrome/browser/ui/blocked_content/popup_blocker_tab_helper.cc
[modify] https://crrev.com/a11672fb4c998040224d7dc97e5bdc05d46a4145/chrome/browser/ui/omnibox/chrome_omnibox_navigation_observer.cc
[modify] https://crrev.com/a11672fb4c998040224d7dc97e5bdc05d46a4145/chrome/browser/ui/passwords/manage_passwords_ui_controller.cc
[modify] https://crrev.com/a11672fb4c998040224d7dc97e5bdc05d46a4145/chrome/browser/ui/search/search_tab_helper.cc
[modify] https://crrev.com/a11672fb4c998040224d7dc97e5bdc05d46a4145/chrome/browser/ui/webui/extensions/extensions_ui.cc
[modify] https://crrev.com/a11672fb4c998040224d7dc97e5bdc05d46a4145/chrome/browser/ui/webui/options/options_ui.cc
[modify] https://crrev.com/a11672fb4c998040224d7dc97e5bdc05d46a4145/chrome/browser/ui/webui/settings/md_settings_ui.cc
[modify] https://crrev.com/a11672fb4c998040224d7dc97e5bdc05d46a4145/components/autofill/content/browser/content_autofill_driver.cc
[modify] https://crrev.com/a11672fb4c998040224d7dc97e5bdc05d46a4145/components/dom_distiller/content/browser/distillability_driver.cc
[modify] https://crrev.com/a11672fb4c998040224d7dc97e5bdc05d46a4145/components/dom_distiller/content/browser/dom_distiller_viewer_source.cc
[modify] https://crrev.com/a11672fb4c998040224d7dc97e5bdc05d46a4145/components/dom_distiller/content/browser/web_contents_main_frame_observer.cc
[modify] https://crrev.com/a11672fb4c998040224d7dc97e5bdc05d46a4145/components/guest_view/browser/guest_view_base.cc
[modify] https://crrev.com/a11672fb4c998040224d7dc97e5bdc05d46a4145/components/password_manager/content/browser/content_password_manager_driver.cc
[modify] https://crrev.com/a11672fb4c998040224d7dc97e5bdc05d46a4145/components/subresource_filter/content/browser/content_subresource_filter_driver_factory.cc
[modify] https://crrev.com/a11672fb4c998040224d7dc97e5bdc05d46a4145/components/translate/content/browser/content_translate_driver.cc
[modify] https://crrev.com/a11672fb4c998040224d7dc97e5bdc05d46a4145/components/zoom/zoom_controller.cc
[modify] https://crrev.com/a11672fb4c998040224d7dc97e5bdc05d46a4145/content/browser/android/web_contents_observer_proxy.cc
[modify] https://crrev.com/a11672fb4c998040224d7dc97e5bdc05d46a4145/content/browser/bluetooth/web_bluetooth_service_impl.cc
[modify] https://crrev.com/a11672fb4c998040224d7dc97e5bdc05d46a4145/content/browser/frame_host/navigation_controller_impl_browsertest.cc
[modify] https://crrev.com/a11672fb4c998040224d7dc97e5bdc05d46a4145/content/browser/frame_host/navigation_controller_impl_unittest.cc
[modify] https://crrev.com/a11672fb4c998040224d7dc97e5bdc05d46a4145/content/browser/frame_host/navigation_handle_impl.cc
[modify] https://crrev.com/a11672fb4c998040224d7dc97e5bdc05d46a4145/content/browser/frame_host/navigation_handle_impl.h
[modify] https://crrev.com/a11672fb4c998040224d7dc97e5bdc05d46a4145/content/browser/frame_host/navigation_handle_impl_browsertest.cc
[modify] https://crrev.com/a11672fb4c998040224d7dc97e5bdc05d46a4145/content/browser/frame_host/navigation_request.cc
[modify] https://crrev.com/a11672fb4c998040224d7dc97e5bdc05d46a4145/content/browser/frame_host/render_frame_host_impl.cc
[modify] https://crrev.com/a11672fb4c998040224d7dc97e5bdc05d46a4145/content/browser/media/session/media_session_impl.cc
[modify] https://crrev.com/a11672fb4c998040224d7dc97e5bdc05d46a4145/content/browser/permissions/permission_service_context.cc
[modify] https://crrev.com/a11672fb4c998040224d7dc97e5bdc05d46a4145/content/browser/plugin_content_origin_whitelist.cc
[modify] https://crrev.com/a11672fb4c998040224d7dc97e5bdc05d46a4145/content/browser/presentation/presentation_service_impl.cc
[modify] https://crrev.com/a11672fb4c998040224d7dc97e5bdc05d46a4145/content/browser/screen_orientation/screen_orientation_provider.cc
[modify] https://crrev.com/a11672fb4c998040224d7dc97e5bdc05d46a4145/content/browser/webui/web_ui_impl.cc
[modify] https://crrev.com/a11672fb4c998040224d7dc97e5bdc05d46a4145/content/public/android/java/src/org/chromium/content/browser/webcontents/WebContentsObserverProxy.java
[modify] https://crrev.com/a11672fb4c998040224d7dc97e5bdc05d46a4145/content/public/android/java/src/org/chromium/content_public/browser/WebContentsObserver.java
[modify] https://crrev.com/a11672fb4c998040224d7dc97e5bdc05d46a4145/content/public/browser/navigation_handle.h
[modify] https://crrev.com/a11672fb4c998040224d7dc97e5bdc05d46a4145/content/public/browser/web_contents_observer.h
[modify] https://crrev.com/a11672fb4c998040224d7dc97e5bdc05d46a4145/content/public/test/test_frame_navigation_observer.cc
[modify] https://crrev.com/a11672fb4c998040224d7dc97e5bdc05d46a4145/content/public/test/test_navigation_observer.cc
[modify] https://crrev.com/a11672fb4c998040224d7dc97e5bdc05d46a4145/extensions/browser/extension_web_contents_observer.cc
[modify] https://crrev.com/a11672fb4c998040224d7dc97e5bdc05d46a4145/extensions/browser/guest_view/mime_handler_view/mime_handler_stream_manager.cc
[modify] https://crrev.com/a11672fb4c998040224d7dc97e5bdc05d46a4145/extensions/browser/guest_view/web_view/web_view_guest.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/02ebf8339c19e2972d49d5fbbade603be652bbec

commit 02ebf8339c19e2972d49d5fbbade603be652bbec
Author: eugenebut <eugenebut@chromium.org>
Date: Wed Mar 08 16:37:08 2017

s/isSamePage/isSameDocument in AndroidWebView.

Old name was presumable used to match was_within_same_page IPC, but
SameDocument name better reflects the the type of the navigation
(navigation did not change the document object).

This change will make naming more consistent with NavigationHandle API:
https://codereview.chromium.org/2716493004/
and ContentViewCore API:
https://codereview.chromium.org/2735063005/

BUG= 695189 

Review-Url: https://codereview.chromium.org/2740593002
Cr-Commit-Position: refs/heads/master@{#455467}

[modify] https://crrev.com/02ebf8339c19e2972d49d5fbbade603be652bbec/android_webview/java/src/org/chromium/android_webview/AwWebContentsObserver.java
[modify] https://crrev.com/02ebf8339c19e2972d49d5fbbade603be652bbec/android_webview/javatests/src/org/chromium/android_webview/test/AwWebContentsObserverTest.java

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/59ab7a2000a72a8d7ec9467672d6636683c62622

commit 59ab7a2000a72a8d7ec9467672d6636683c62622
Author: eugenebut <eugenebut@chromium.org>
Date: Thu Mar 09 16:21:12 2017

s/isSamePage/isSameDocument in ContentViewCore.didFinishNavigation.

Follow up cleanup after https://codereview.chromium.org/2716493004/

BUG= 695189 

Review-Url: https://codereview.chromium.org/2735063005
Cr-Commit-Position: refs/heads/master@{#455757}

[modify] https://crrev.com/59ab7a2000a72a8d7ec9467672d6636683c62622/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java

Thanks for doing this!  As I noted in https://codereview.chromium.org/2716493004#msg19, I think it's a nice improvement:

"I'll put in an argument that renaming everything to SameDocument seems more
precise, and might be a worthwhile thing to converge on (despite the current
heavy use of SamePage to the contrary).  In general, "page" refers to the whole
frame tree and "document" refers to what's in a single frame, and we're
discussing what happens for a navigation in a single frame here.

I'll also note that in-page/InPage is a common term inside NavigationController,
but it means the same thing.  We should probably update that usage as well if we
go down this path."

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d62ba1f5529bb7bfa48ea80ea131c1b9fd0f17b6

commit d62ba1f5529bb7bfa48ea80ea131c1b9fd0f17b6
Author: eugenebut <eugenebut@chromium.org>
Date: Sat Mar 11 00:28:10 2017

Use SameDocument term in tests instead of SamePage.

This is follow up cleanup after renaming NavigationHandle::IsSamePage to
NavigationHandle::IsSameDocument in this CL:
https://codereview.chromium.org/2716493004/

BUG= 695189 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2742923002
Cr-Commit-Position: refs/heads/master@{#456231}

[modify] https://crrev.com/d62ba1f5529bb7bfa48ea80ea131c1b9fd0f17b6/content/browser/frame_host/navigation_controller_impl_browsertest.cc
[modify] https://crrev.com/d62ba1f5529bb7bfa48ea80ea131c1b9fd0f17b6/content/browser/media/session/media_session_service_impl_browsertest.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/af71322a182d469fc0acede81218fdeb19d5ecb2

commit af71322a182d469fc0acede81218fdeb19d5ecb2
Author: eugenebut <eugenebut@chromium.org>
Date: Mon Mar 13 21:11:12 2017

s/IsSamePage/IsSameDocument for NavigationContext.

This mirrors a change for all other platforms:
https://codereview.chromium.org/2716493004/

BUG= 695189 

Review-Url: https://codereview.chromium.org/2734293002
Cr-Commit-Position: refs/heads/master@{#456483}

[modify] https://crrev.com/af71322a182d469fc0acede81218fdeb19d5ecb2/components/translate/ios/browser/language_detection_controller.mm
[modify] https://crrev.com/af71322a182d469fc0acede81218fdeb19d5ecb2/ios/chrome/browser/tabs/tab.mm
[modify] https://crrev.com/af71322a182d469fc0acede81218fdeb19d5ecb2/ios/web/public/test/fakes/crw_test_web_state_observer.mm
[modify] https://crrev.com/af71322a182d469fc0acede81218fdeb19d5ecb2/ios/web/public/test/fakes/test_web_state_observer.mm
[modify] https://crrev.com/af71322a182d469fc0acede81218fdeb19d5ecb2/ios/web/public/web_state/navigation_context.h
[modify] https://crrev.com/af71322a182d469fc0acede81218fdeb19d5ecb2/ios/web/public/web_state/web_state_observer.h
[modify] https://crrev.com/af71322a182d469fc0acede81218fdeb19d5ecb2/ios/web/web_state/navigation_callbacks_inttest.mm
[modify] https://crrev.com/af71322a182d469fc0acede81218fdeb19d5ecb2/ios/web/web_state/navigation_context_impl.h
[modify] https://crrev.com/af71322a182d469fc0acede81218fdeb19d5ecb2/ios/web/web_state/navigation_context_impl.mm
[modify] https://crrev.com/af71322a182d469fc0acede81218fdeb19d5ecb2/ios/web/web_state/navigation_context_impl_unittest.mm
[modify] https://crrev.com/af71322a182d469fc0acede81218fdeb19d5ecb2/ios/web/web_state/web_state_impl_unittest.mm
[modify] https://crrev.com/af71322a182d469fc0acede81218fdeb19d5ecb2/ios/web/web_state/web_state_observer_bridge_unittest.mm

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cf731b5cfca8a5d9d58493c43224a0274b564432

commit cf731b5cfca8a5d9d58493c43224a0274b564432
Author: eugenebut <eugenebut@chromium.org>
Date: Fri Mar 17 17:36:34 2017

Renamed NavigationState::WasWithinSamePage to WasWithinSameDocument.

Also renamed was_within_same_page IPC message to was_within_same_document
and NavigationState::WasWithinSameDocument to WasWithinSamePage

BUG= 695189 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2741313002
Cr-Commit-Position: refs/heads/master@{#457806}

[modify] https://crrev.com/cf731b5cfca8a5d9d58493c43224a0274b564432/chrome/renderer/safe_browsing/phishing_classifier_delegate.cc
[modify] https://crrev.com/cf731b5cfca8a5d9d58493c43224a0274b564432/components/subresource_filter/content/browser/content_subresource_filter_driver_factory_unittest.cc
[modify] https://crrev.com/cf731b5cfca8a5d9d58493c43224a0274b564432/content/browser/frame_host/navigation_controller_impl_unittest.cc
[modify] https://crrev.com/cf731b5cfca8a5d9d58493c43224a0274b564432/content/browser/frame_host/navigation_handle_impl.cc
[modify] https://crrev.com/cf731b5cfca8a5d9d58493c43224a0274b564432/content/browser/frame_host/navigator_impl.cc
[modify] https://crrev.com/cf731b5cfca8a5d9d58493c43224a0274b564432/content/browser/frame_host/navigator_impl_unittest.cc
[modify] https://crrev.com/cf731b5cfca8a5d9d58493c43224a0274b564432/content/browser/frame_host/render_frame_host_impl.cc
[modify] https://crrev.com/cf731b5cfca8a5d9d58493c43224a0274b564432/content/browser/frame_host/render_frame_host_manager_unittest.cc
[modify] https://crrev.com/cf731b5cfca8a5d9d58493c43224a0274b564432/content/browser/loader/resource_scheduler_filter.cc
[modify] https://crrev.com/cf731b5cfca8a5d9d58493c43224a0274b564432/content/browser/security_exploit_browsertest.cc
[modify] https://crrev.com/cf731b5cfca8a5d9d58493c43224a0274b564432/content/browser/web_contents/web_contents_view_aura_browsertest.cc
[modify] https://crrev.com/cf731b5cfca8a5d9d58493c43224a0274b564432/content/common/frame_messages.h
[modify] https://crrev.com/cf731b5cfca8a5d9d58493c43224a0274b564432/content/public/renderer/navigation_state.h
[modify] https://crrev.com/cf731b5cfca8a5d9d58493c43224a0274b564432/content/public/test/navigation_simulator.cc
[modify] https://crrev.com/cf731b5cfca8a5d9d58493c43224a0274b564432/content/public/test/navigation_simulator.h
[modify] https://crrev.com/cf731b5cfca8a5d9d58493c43224a0274b564432/content/renderer/navigation_state_impl.cc
[modify] https://crrev.com/cf731b5cfca8a5d9d58493c43224a0274b564432/content/renderer/navigation_state_impl.h
[modify] https://crrev.com/cf731b5cfca8a5d9d58493c43224a0274b564432/content/renderer/render_frame_impl.cc
[modify] https://crrev.com/cf731b5cfca8a5d9d58493c43224a0274b564432/content/renderer/render_frame_impl_browsertest.cc
[modify] https://crrev.com/cf731b5cfca8a5d9d58493c43224a0274b564432/content/test/test_render_frame_host.cc
[modify] https://crrev.com/cf731b5cfca8a5d9d58493c43224a0274b564432/content/test/test_render_view_host.cc
[modify] https://crrev.com/cf731b5cfca8a5d9d58493c43224a0274b564432/content/test/test_web_contents.cc
[modify] https://crrev.com/cf731b5cfca8a5d9d58493c43224a0274b564432/content/test/test_web_contents.h

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/12977a2e65c4dd71808494a55ac291c94febacd9

commit 12977a2e65c4dd71808494a55ac291c94febacd9
Author: eugenebut <eugenebut@chromium.org>
Date: Tue Mar 21 20:22:57 2017

Use SameDocument instead of SamePage term on iOS.

BUG= 695189 

Review-Url: https://codereview.chromium.org/2759613003
Cr-Commit-Position: refs/heads/master@{#458531}

[modify] https://crrev.com/12977a2e65c4dd71808494a55ac291c94febacd9/ios/chrome/browser/web/window_open_by_dom_egtest.mm
[modify] https://crrev.com/12977a2e65c4dd71808494a55ac291c94febacd9/ios/testing/data/http_server_files/window_open.html
[modify] https://crrev.com/12977a2e65c4dd71808494a55ac291c94febacd9/ios/web/public/test/fakes/crw_test_web_state_observer.mm
[modify] https://crrev.com/12977a2e65c4dd71808494a55ac291c94febacd9/ios/web/public/test/fakes/test_web_state_observer.mm
[modify] https://crrev.com/12977a2e65c4dd71808494a55ac291c94febacd9/ios/web/web_state/navigation_callbacks_inttest.mm
[modify] https://crrev.com/12977a2e65c4dd71808494a55ac291c94febacd9/ios/web/web_state/navigation_context_impl.h
[modify] https://crrev.com/12977a2e65c4dd71808494a55ac291c94febacd9/ios/web/web_state/navigation_context_impl.mm
[modify] https://crrev.com/12977a2e65c4dd71808494a55ac291c94febacd9/ios/web/web_state/navigation_context_impl_unittest.mm
[modify] https://crrev.com/12977a2e65c4dd71808494a55ac291c94febacd9/ios/web/web_state/ui/crw_web_controller.mm
[modify] https://crrev.com/12977a2e65c4dd71808494a55ac291c94febacd9/ios/web/web_state/web_state_impl.h
[modify] https://crrev.com/12977a2e65c4dd71808494a55ac291c94febacd9/ios/web/web_state/web_state_impl.mm
[modify] https://crrev.com/12977a2e65c4dd71808494a55ac291c94febacd9/ios/web/web_state/web_state_impl_unittest.mm

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f942ba0c142618d08df7eaab7619d61758cc8826

commit f942ba0c142618d08df7eaab7619d61758cc8826
Author: eugenebut <eugenebut@chromium.org>
Date: Fri Mar 24 15:41:07 2017

Use SameDocument instead of SamePage term for extensions.

Old name was presumably used to match was_within_same_page IPC, but
SameDocument name better reflects the the type of the navigation
(navigation did not change the document object).

This change will make naming more consistent with the rest of Chromium
code.

BUG= 695189 

Review-Url: https://codereview.chromium.org/2777443002
Cr-Commit-Position: refs/heads/master@{#459432}

[modify] https://crrev.com/f942ba0c142618d08df7eaab7619d61758cc8826/extensions/browser/guest_view/web_view/web_view_apitest.cc
[rename] https://crrev.com/f942ba0c142618d08df7eaab7619d61758cc8826/extensions/test/data/web_view/apitest/guest_same_document_navigation.html
[modify] https://crrev.com/f942ba0c142618d08df7eaab7619d61758cc8826/extensions/test/data/web_view/apitest/main.js

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5ae751e8e94501c884e5ac2335cc358f37310129

commit 5ae751e8e94501c884e5ac2335cc358f37310129
Author: eugenebut <eugenebut@chromium.org>
Date: Tue Mar 28 17:10:37 2017

s/same_page/same_document for DidCommitProvisionalLoad method.

Old name was presumably used to match was_within_same_page IPC, but
SameDocument name better reflects the the type of the navigation
(navigation did not change the document object).

This change will make naming more consistent with the rest of Chromium
code.

BUG= 695189 

Review-Url: https://codereview.chromium.org/2775963002
Cr-Commit-Position: refs/heads/master@{#460143}

[modify] https://crrev.com/5ae751e8e94501c884e5ac2335cc358f37310129/android_webview/renderer/aw_render_frame_ext.cc
[modify] https://crrev.com/5ae751e8e94501c884e5ac2335cc358f37310129/android_webview/renderer/aw_render_frame_ext.h
[modify] https://crrev.com/5ae751e8e94501c884e5ac2335cc358f37310129/chrome/renderer/autofill/password_autofill_agent_browsertest.cc
[modify] https://crrev.com/5ae751e8e94501c884e5ac2335cc358f37310129/chrome/renderer/chrome_render_frame_observer.cc
[modify] https://crrev.com/5ae751e8e94501c884e5ac2335cc358f37310129/chrome/renderer/chrome_render_frame_observer.h
[modify] https://crrev.com/5ae751e8e94501c884e5ac2335cc358f37310129/chrome/renderer/content_settings_observer.cc
[modify] https://crrev.com/5ae751e8e94501c884e5ac2335cc358f37310129/chrome/renderer/content_settings_observer.h
[modify] https://crrev.com/5ae751e8e94501c884e5ac2335cc358f37310129/chrome/renderer/net/net_error_helper.cc
[modify] https://crrev.com/5ae751e8e94501c884e5ac2335cc358f37310129/chrome/renderer/net/net_error_helper.h
[modify] https://crrev.com/5ae751e8e94501c884e5ac2335cc358f37310129/chrome/renderer/page_load_metrics/metrics_render_frame_observer.cc
[modify] https://crrev.com/5ae751e8e94501c884e5ac2335cc358f37310129/chrome/renderer/page_load_metrics/metrics_render_frame_observer.h
[modify] https://crrev.com/5ae751e8e94501c884e5ac2335cc358f37310129/chrome/renderer/safe_browsing/phishing_classifier_delegate.cc
[modify] https://crrev.com/5ae751e8e94501c884e5ac2335cc358f37310129/chrome/renderer/safe_browsing/phishing_classifier_delegate.h
[modify] https://crrev.com/5ae751e8e94501c884e5ac2335cc358f37310129/components/autofill/content/renderer/autofill_agent.cc
[modify] https://crrev.com/5ae751e8e94501c884e5ac2335cc358f37310129/components/autofill/content/renderer/autofill_agent.h
[modify] https://crrev.com/5ae751e8e94501c884e5ac2335cc358f37310129/components/autofill/content/renderer/password_autofill_agent.cc
[modify] https://crrev.com/5ae751e8e94501c884e5ac2335cc358f37310129/components/autofill/content/renderer/password_autofill_agent.h
[modify] https://crrev.com/5ae751e8e94501c884e5ac2335cc358f37310129/components/subresource_filter/content/renderer/subresource_filter_agent.cc
[modify] https://crrev.com/5ae751e8e94501c884e5ac2335cc358f37310129/components/subresource_filter/content/renderer/subresource_filter_agent.h
[modify] https://crrev.com/5ae751e8e94501c884e5ac2335cc358f37310129/components/subresource_filter/content/renderer/subresource_filter_agent_unittest.cc
[modify] https://crrev.com/5ae751e8e94501c884e5ac2335cc358f37310129/content/public/renderer/render_frame_observer.h
[modify] https://crrev.com/5ae751e8e94501c884e5ac2335cc358f37310129/content/renderer/manifest/manifest_manager.cc
[modify] https://crrev.com/5ae751e8e94501c884e5ac2335cc358f37310129/content/renderer/manifest/manifest_manager.h
[modify] https://crrev.com/5ae751e8e94501c884e5ac2335cc358f37310129/content/renderer/pepper/plugin_power_saver_helper.cc
[modify] https://crrev.com/5ae751e8e94501c884e5ac2335cc358f37310129/content/renderer/pepper/plugin_power_saver_helper.h
[modify] https://crrev.com/5ae751e8e94501c884e5ac2335cc358f37310129/content/renderer/presentation/presentation_dispatcher.cc
[modify] https://crrev.com/5ae751e8e94501c884e5ac2335cc358f37310129/content/renderer/presentation/presentation_dispatcher.h

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5ffab89a82a2dbf5e7b974fb41f7a9767e846c03

commit 5ffab89a82a2dbf5e7b974fb41f7a9767e846c03
Author: eugenebut <eugenebut@chromium.org>
Date: Mon Apr 03 17:38:30 2017

Use SameDocument term in subresource_filter tests.

Old name was presumably used to match was_within_same_page IPC, but
SameDocument name better reflects the the type of the navigation
(navigation did not change the document object).

This change will make naming more consistent with the rest of Chromium
code.

BUG= 695189 

Review-Url: https://codereview.chromium.org/2788143003
Cr-Commit-Position: refs/heads/master@{#461465}

[modify] https://crrev.com/5ffab89a82a2dbf5e7b974fb41f7a9767e846c03/components/subresource_filter/content/browser/content_subresource_filter_throttle_manager_unittest.cc
[modify] https://crrev.com/5ffab89a82a2dbf5e7b974fb41f7a9767e846c03/components/subresource_filter/content/renderer/subresource_filter_agent_unittest.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0b9db8c1ccf56746c5046b0ce7325d572d8d11c6

commit 0b9db8c1ccf56746c5046b0ce7325d572d8d11c6
Author: eugenebut <eugenebut@chromium.org>
Date: Mon Apr 03 21:55:38 2017

Use SameDocument term in navigation metrics unittest.

Old name was presumably used to match was_within_same_page IPC, but
SameDocument name better reflects the the type of the navigation
(navigation did not change the document object).

This change will make naming more consistent with the rest of Chromium
code.

BUG= 695189 

Review-Url: https://codereview.chromium.org/2793733002
Cr-Commit-Position: refs/heads/master@{#461549}

[modify] https://crrev.com/0b9db8c1ccf56746c5046b0ce7325d572d8d11c6/components/navigation_metrics/navigation_metrics_unittest.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cfaf497e50484a20c662f4bb57e3ce2c67463ed2

commit cfaf497e50484a20c662f4bb57e3ce2c67463ed2
Author: eugenebut <eugenebut@chromium.org>
Date: Wed Apr 05 15:44:48 2017

Use SameDocument term in subresource_filter_browsertest.

Old name was presumably used to match was_within_same_page IPC, but
SameDocument name better reflects the the type of the navigation
(navigation did not change the document object).

This change will make naming more consistent with the rest of Chromium
code.

BUG= 695189 

Review-Url: https://codereview.chromium.org/2796123004
Cr-Commit-Position: refs/heads/master@{#462083}

[modify] https://crrev.com/cfaf497e50484a20c662f4bb57e3ce2c67463ed2/chrome/browser/subresource_filter/subresource_filter_browsertest.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ee24cb324ef34572a83f4d81d8af11f91b59d378

commit ee24cb324ef34572a83f4d81d8af11f91b59d378
Author: eugenebut <eugenebut@chromium.org>
Date: Thu Apr 06 15:43:15 2017

s/DidNavigateWithinPage/OnSameDocumentNavigation.

Old name was presumably used to match was_within_same_page IPC, but
SameDocument name better reflects the the type of the navigation
(navigation did not change the document object).

This change will make naming more consistent with the rest of Chromium
code.

BUG= 695189 

Review-Url: https://codereview.chromium.org/2799093002
Cr-Commit-Position: refs/heads/master@{#462490}

[modify] https://crrev.com/ee24cb324ef34572a83f4d81d8af11f91b59d378/chrome/renderer/content_settings_observer_browsertest.cc
[modify] https://crrev.com/ee24cb324ef34572a83f4d81d8af11f91b59d378/chrome/renderer/safe_browsing/phishing_classifier_delegate_browsertest.cc
[modify] https://crrev.com/ee24cb324ef34572a83f4d81d8af11f91b59d378/content/public/test/render_view_test.cc
[modify] https://crrev.com/ee24cb324ef34572a83f4d81d8af11f91b59d378/content/public/test/render_view_test.h

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/34416a7e3c4764a5594dd31fb9ab0305caa46a62

commit 34416a7e3c4764a5594dd31fb9ab0305caa46a62
Author: eugenebut <eugenebut@chromium.org>
Date: Mon Apr 10 16:45:49 2017

Use SameDocument term instead of SamePage in chrome tests.

Old name was presumably used to match was_within_same_page IPC, but
SameDocument name better reflects the the type of the navigation
(navigation did not change the document object).

This change will make naming more consistent with the rest of Chromium
code.

BUG= 695189 

Review-Url: https://codereview.chromium.org/2807723002
Cr-Commit-Position: refs/heads/master@{#463293}

[modify] https://crrev.com/34416a7e3c4764a5594dd31fb9ab0305caa46a62/chrome/browser/android/offline_pages/recent_tab_helper_unittest.cc
[modify] https://crrev.com/34416a7e3c4764a5594dd31fb9ab0305caa46a62/chrome/browser/net/errorpage_browsertest.cc
[modify] https://crrev.com/34416a7e3c4764a5594dd31fb9ab0305caa46a62/chrome/browser/page_load_metrics/metrics_web_contents_observer_unittest.cc
[modify] https://crrev.com/34416a7e3c4764a5594dd31fb9ab0305caa46a62/chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer_unittest.cc
[modify] https://crrev.com/34416a7e3c4764a5594dd31fb9ab0305caa46a62/chrome/browser/page_load_metrics/page_load_metrics_browsertest.cc
[modify] https://crrev.com/34416a7e3c4764a5594dd31fb9ab0305caa46a62/chrome/browser/ssl/ssl_browser_tests.cc
[modify] https://crrev.com/34416a7e3c4764a5594dd31fb9ab0305caa46a62/chrome/renderer/content_settings_observer_browsertest.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c51f182ce2d04ed0d4a24279fe06651f805e22a9

commit c51f182ce2d04ed0d4a24279fe06651f805e22a9
Author: eugenebut <eugenebut@chromium.org>
Date: Fri Apr 21 19:19:25 2017

Use SameDocument term instead of SamePage in android media tests.

Old name was presumably used to match was_within_same_page IPC, but
SameDocument name better reflects the the type of the navigation
(navigation did not change the document object).

This change will make naming more consistent with the rest of Chromium
code.

BUG= 695189 

Review-Url: https://codereview.chromium.org/2826203002
Cr-Commit-Position: refs/heads/master@{#466410}

[modify] https://crrev.com/c51f182ce2d04ed0d4a24279fe06651f805e22a9/chrome/android/javatests/src/org/chromium/chrome/browser/media/ui/NotificationActionsUpdatedTest.java
[modify] https://crrev.com/c51f182ce2d04ed0d4a24279fe06651f805e22a9/chrome/android/javatests/src/org/chromium/chrome/browser/media/ui/NotificationTestUtils.java
[modify] https://crrev.com/c51f182ce2d04ed0d4a24279fe06651f805e22a9/chrome/android/javatests/src/org/chromium/chrome/browser/media/ui/NotificationTitleUpdatedTest.java

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ee08663ae2f6240b382249c849f5c42012143632

commit ee08663ae2f6240b382249c849f5c42012143632
Author: eugenebut <eugenebut@chromium.org>
Date: Thu Apr 27 17:43:12 2017

Renamed LoadCommittedDetails.is_in_page to is_same_document.

Old name was presumably used to match was_within_same_page IPC, but
SameDocument name better reflects the the type of the navigation
(navigation did not change the document object).

This change will make naming more consistent with the rest of Chromium
code.

BUG= 695189 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2841833002
Cr-Commit-Position: refs/heads/master@{#467720}

[modify] https://crrev.com/ee08663ae2f6240b382249c849f5c42012143632/chrome/browser/media_galleries/media_file_system_registry.cc
[modify] https://crrev.com/ee08663ae2f6240b382249c849f5c42012143632/chrome/browser/supervised_user/supervised_user_interstitial.cc
[modify] https://crrev.com/ee08663ae2f6240b382249c849f5c42012143632/chrome/browser/ui/chrome_bubble_manager.cc
[modify] https://crrev.com/ee08663ae2f6240b382249c849f5c42012143632/content/browser/frame_host/navigation_controller_impl.cc
[modify] https://crrev.com/ee08663ae2f6240b382249c849f5c42012143632/content/browser/web_contents/web_contents_impl.cc
[modify] https://crrev.com/ee08663ae2f6240b382249c849f5c42012143632/content/public/browser/navigation_details.cc
[modify] https://crrev.com/ee08663ae2f6240b382249c849f5c42012143632/content/public/browser/navigation_details.h
[modify] https://crrev.com/ee08663ae2f6240b382249c849f5c42012143632/services/navigation/view_impl.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4645ee94b0d729532c32eb504e7e1fe400206548

commit 4645ee94b0d729532c32eb504e7e1fe400206548
Author: eugenebut <eugenebut@chromium.org>
Date: Tue May 09 15:18:19 2017

Use is_same_document term instead of is_in_page for metrics.

RecordMainFrameNavigation receives NavigationHandle->IsSameDocument()
for its second argument, so the argument name should be is_same_page.
Also updated histogram comment to be accurate.

BUG= 695189 

Review-Url: https://codereview.chromium.org/2849593002
Cr-Commit-Position: refs/heads/master@{#470339}

[modify] https://crrev.com/4645ee94b0d729532c32eb504e7e1fe400206548/components/navigation_metrics/navigation_metrics.cc
[modify] https://crrev.com/4645ee94b0d729532c32eb504e7e1fe400206548/components/navigation_metrics/navigation_metrics.h
[modify] https://crrev.com/4645ee94b0d729532c32eb504e7e1fe400206548/tools/metrics/histograms/histograms.xml

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/604866f62c0eddbe28e155f124935069398dfed0

commit 604866f62c0eddbe28e155f124935069398dfed0
Author: eugenebut <eugenebut@chromium.org>
Date: Wed May 10 21:35:36 2017

Use is_same_document term instead of is_in_page in NavigationController.

Old name was presumably used to match was_within_same_page IPC, but
SameDocument name better reflects the the type of the navigation
(navigation did not change the document object).

This change will make naming more consistent with the rest of Chromium
code.

BUG= 695189 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2872033004
Cr-Commit-Position: refs/heads/master@{#470718}

[modify] https://crrev.com/604866f62c0eddbe28e155f124935069398dfed0/content/browser/frame_host/navigation_controller_impl.cc
[modify] https://crrev.com/604866f62c0eddbe28e155f124935069398dfed0/content/browser/frame_host/navigation_controller_impl.h

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/067c3b4f61f6f601a899043e91d3d25fe41997a9

commit 067c3b4f61f6f601a899043e91d3d25fe41997a9
Author: eugenebut <eugenebut@chromium.org>
Date: Wed May 17 23:24:08 2017

Use same document term instead of in-page in NavigationController test.

Old name was presumably used to match was_within_same_page IPC, but
SameDocument name better reflects the the type of the navigation
(navigation did not change the document object).

This change will make naming more consistent with the rest of Chromium
code.

BUG= 695189 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2892583003
Cr-Commit-Position: refs/heads/master@{#472599}

[modify] https://crrev.com/067c3b4f61f6f601a899043e91d3d25fe41997a9/content/browser/frame_host/navigation_controller_impl_browsertest.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a1ebacdb1bbacbf534ef9f8dc763bc77273fdfd0

commit a1ebacdb1bbacbf534ef9f8dc763bc77273fdfd0
Author: eugenebut <eugenebut@chromium.org>
Date: Tue May 23 22:58:45 2017

Use same document term instead of in-page in NavigationControllerTest.

Old name was presumably used to match was_within_same_page IPC, but
SameDocument name better reflects the the type of the navigation
(navigation did not change the document object).

This change will make naming more consistent with the rest of Chromium
code.

BUG= 695189 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2902513003
Cr-Commit-Position: refs/heads/master@{#474095}

[modify] https://crrev.com/a1ebacdb1bbacbf534ef9f8dc763bc77273fdfd0/content/browser/frame_host/navigation_controller_impl_unittest.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e7bc65f60b9532f252d975c93782f5b94a5aaf64

commit e7bc65f60b9532f252d975c93782f5b94a5aaf64
Author: creis <creis@chromium.org>
Date: Tue Jun 20 22:13:12 2017

Rename is_same_page to is_same_document in NavigationHandle.

BUG= 695189 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2949853002
Cr-Commit-Position: refs/heads/master@{#480985}

[modify] https://crrev.com/e7bc65f60b9532f252d975c93782f5b94a5aaf64/content/browser/frame_host/interstitial_page_navigator_impl.cc
[modify] https://crrev.com/e7bc65f60b9532f252d975c93782f5b94a5aaf64/content/browser/frame_host/navigation_handle_impl.cc
[modify] https://crrev.com/e7bc65f60b9532f252d975c93782f5b94a5aaf64/content/browser/frame_host/navigation_handle_impl.h
[modify] https://crrev.com/e7bc65f60b9532f252d975c93782f5b94a5aaf64/content/browser/frame_host/navigator_impl.cc
[modify] https://crrev.com/e7bc65f60b9532f252d975c93782f5b94a5aaf64/content/public/browser/navigation_handle.cc
[modify] https://crrev.com/e7bc65f60b9532f252d975c93782f5b94a5aaf64/content/public/browser/navigation_handle.h

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/eb728dc805a10d6a216b740bc9ece7b9443feded

commit eb728dc805a10d6a216b740bc9ece7b9443feded
Author: eugenebut <eugenebut@chromium.org>
Date: Tue Jul 18 22:04:22 2017

Use same_document term instead of same_page in FrameNavigationState

Old name was presumably used to match was_within_same_page IPC, but
SameDocument name better reflects the the type of the navigation
(navigation did not change the document object).

This change will make naming more consistent with the rest of Chromium
code.

BUG= 695189 

Review-Url: https://codereview.chromium.org/2971073002
Cr-Commit-Position: refs/heads/master@{#487623}

[modify] https://crrev.com/eb728dc805a10d6a216b740bc9ece7b9443feded/chrome/browser/extensions/api/web_navigation/frame_navigation_state.cc
[modify] https://crrev.com/eb728dc805a10d6a216b740bc9ece7b9443feded/chrome/browser/extensions/api/web_navigation/frame_navigation_state.h

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6f0e3b2e552282301575d17cf664d3b1f5888302

commit 6f0e3b2e552282301575d17cf664d3b1f5888302
Author: Eugene But <eugenebut@google.com>
Date: Thu Aug 10 22:23:26 2017

Use same_document term instead of same_page in ChromeDataUseAscriber.

Old name was presumably used to match was_within_same_page IPC, but
SameDocument name better reflects the the type of the navigation
(navigation did not change the document object).

This change will make naming more consistent with the rest of Chromium
code.

Bug:  695189 
Change-Id: I3dbf9b3c8adb47749e110431a8c7a56322c2aa3c
Reviewed-on: https://chromium-review.googlesource.com/610704
Reviewed-by: Megan Jablonski <megjablon@chromium.org>
Commit-Queue: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#493562}
[modify] https://crrev.com/6f0e3b2e552282301575d17cf664d3b1f5888302/chrome/browser/data_use_measurement/chrome_data_use_ascriber.cc
[modify] https://crrev.com/6f0e3b2e552282301575d17cf664d3b1f5888302/chrome/browser/data_use_measurement/chrome_data_use_ascriber.h

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c2eeb420384f0bf652ba03eb34b984483ff0dddb

commit c2eeb420384f0bf652ba03eb34b984483ff0dddb
Author: Eugene But <eugenebut@google.com>
Date: Wed Sep 20 14:14:48 2017

Corrected comment in SupervisedUserInterstitial::Init().

s/details.is_same_page/details.is_same_document because that's how
member is actually called.

Bug:  695189 
Change-Id: I1c8859f3d87efadde015d3a676b4407cf67f9ef5
Reviewed-on: https://chromium-review.googlesource.com/673872
Reviewed-by: Marc Treib <treib@chromium.org>
Commit-Queue: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#503131}
[modify] https://crrev.com/c2eeb420384f0bf652ba03eb34b984483ff0dddb/chrome/browser/supervised_user/supervised_user_interstitial.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/43e82d1ff29132f5fadda514b1e083bf846f4503

commit 43e82d1ff29132f5fadda514b1e083bf846f4503
Author: Eugene But <eugenebut@chromium.org>
Date: Wed Sep 20 16:38:28 2017

s/same_page/same_document for NavigationHandleImpl::Create() call comments.

Actual argument name is |is_same_document|.

Bug:  695189 
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_site_isolation
Change-Id: Idc9489d2194256f32bc66e848543048a6f7f37d6
Reviewed-on: https://chromium-review.googlesource.com/674445
Reviewed-by: Camille Lamy <clamy@chromium.org>
Commit-Queue: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#503178}
[modify] https://crrev.com/43e82d1ff29132f5fadda514b1e083bf846f4503/content/browser/frame_host/form_submission_throttle_browsertest.cc
[modify] https://crrev.com/43e82d1ff29132f5fadda514b1e083bf846f4503/content/browser/frame_host/navigation_handle_impl_unittest.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8f791134d6cbb99a8108bd5d64fa1eea0ceab2b5

commit 8f791134d6cbb99a8108bd5d64fa1eea0ceab2b5
Author: Eugene But <eugenebut@google.com>
Date: Thu Sep 21 17:06:11 2017

Use same_document term instead of in_page in LanguageState.

Old name was presumably used to match was_within_same_page IPC, but
SameDocument name better reflects the the type of the navigation
(navigation did not change the document object).

This change will make naming more consistent with the rest of Chromium
code.

Bug:  695189 
Change-Id: I10aa3742e693620f7cf2c56d40346252288e6f79
Reviewed-on: https://chromium-review.googlesource.com/674101
Reviewed-by: David Roger <droger@chromium.org>
Commit-Queue: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#503479}
[modify] https://crrev.com/8f791134d6cbb99a8108bd5d64fa1eea0ceab2b5/components/translate/core/browser/language_state.cc
[modify] https://crrev.com/8f791134d6cbb99a8108bd5d64fa1eea0ceab2b5/components/translate/core/browser/language_state.h

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a3410eca75d61a26724e498f378635aa20a59368

commit a3410eca75d61a26724e498f378635aa20a59368
Author: Eugene But <eugenebut@chromium.org>
Date: Fri Sep 22 16:52:52 2017

Use same_document term instead of same_page in RenderFrameImpl.

Old name was presumably used to match was_within_same_page IPC, but
SameDocument name better reflects the the type of the navigation
(navigation did not change the document object).

This change will make naming more consistent with the rest of Chromium
code.

Bug:  695189 
Change-Id: I155712f4044771b864cbb4133766b31366f5b935
Reviewed-on: https://chromium-review.googlesource.com/674047
Reviewed-by: Charlie Reis (OOO until 9/25) <creis@chromium.org>
Commit-Queue: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#503770}
[modify] https://crrev.com/a3410eca75d61a26724e498f378635aa20a59368/content/renderer/render_frame_impl.cc
[modify] https://crrev.com/a3410eca75d61a26724e498f378635aa20a59368/content/renderer/render_frame_impl.h

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/73ef892bc37715bbb498403f3365b2faf336d363

commit 73ef892bc37715bbb498403f3365b2faf336d363
Author: Eugene But <eugenebut@chromium.org>
Date: Fri Sep 22 22:36:46 2017

Use SameDocument term instead of SamePage in MediaNotificationTitleUpdatedTest.

Old name was presumably used to match was_within_same_page IPC, but
SameDocument name better reflects the the type of the navigation
(navigation did not change the document object).

This change will make naming more consistent with the rest of Chromium
code.

Bug:  695189 
Change-Id: Icce2201d9909708db7ada022e042bf62e5843319
Reviewed-on: https://chromium-review.googlesource.com/674055
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Commit-Queue: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#503879}
[modify] https://crrev.com/73ef892bc37715bbb498403f3365b2faf336d363/chrome/android/junit/src/org/chromium/chrome/browser/media/ui/MediaNotificationTitleUpdatedTest.java

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/37de89ac948b370dbfd8569ea5c5df4bea6ff7af

commit 37de89ac948b370dbfd8569ea5c5df4bea6ff7af
Author: Eugene But <eugenebut@chromium.org>
Date: Fri Sep 22 23:48:13 2017

Use SameDocument term instead of SamePage in ssl_browser_tests.cc.

Old name was presumably used to match was_within_same_page IPC, but
SameDocument name better reflects the the type of the navigation
(navigation did not change the document object).

This change will make naming more consistent with the rest of Chromium
code.

Bug:  695189 
Change-Id: I09d7c25dc973b30c90f65ebdd24e74bfa5a0899f
Reviewed-on: https://chromium-review.googlesource.com/674053
Reviewed-by: Emily Stark <estark@chromium.org>
Commit-Queue: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#503908}
[modify] https://crrev.com/37de89ac948b370dbfd8569ea5c5df4bea6ff7af/chrome/browser/ssl/ssl_browser_tests.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b4bd1b33a94c9b4384184a2bb3810f9a34f9cc40

commit b4bd1b33a94c9b4384184a2bb3810f9a34f9cc40
Author: Eugene But <eugenebut@google.com>
Date: Sat Sep 23 01:48:06 2017

Use SameDocument term instead of InPage in SSLUITest.

Old name was presumably used to match was_within_same_page IPC, but
SameDocument name better reflects the the type of the navigation
(navigation did not change the document object).

This change will make naming more consistent with the rest of Chromium
code.

Bug:  695189 
Change-Id: Iaf3c800e48a000547d87dd27d66a260bff38a38f
Reviewed-on: https://chromium-review.googlesource.com/674098
Reviewed-by: Emily Stark <estark@chromium.org>
Commit-Queue: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#503928}
[modify] https://crrev.com/b4bd1b33a94c9b4384184a2bb3810f9a34f9cc40/chrome/browser/ssl/ssl_browser_tests.cc
[rename] https://crrev.com/b4bd1b33a94c9b4384184a2bb3810f9a34f9cc40/chrome/test/data/ssl/same_document_navigation_during_load.html

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7cc259dcc527e59251c7a97cc0bbdc0deb0d5c21

commit 7cc259dcc527e59251c7a97cc0bbdc0deb0d5c21
Author: Eugene But <eugenebut@google.com>
Date: Mon Oct 09 23:52:49 2017

Renamed IsURLInPageNavigation to IsURLSameDocumentNavigation.

Old name was presumably used to match was_within_same_page IPC, but
SameDocument name better reflects the the type of the navigation
(navigation did not change the document object).

This change will make naming more consistent with the rest of Chromium
code.

Bug:  695189 
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_site_isolation
Change-Id: I1ac9f02a0ae7098d8e962b1cc0c11aa461641983
Reviewed-on: https://chromium-review.googlesource.com/675443
Commit-Queue: Eugene But <eugenebut@chromium.org>
Reviewed-by: Charlie Reis <creis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#507539}
[modify] https://crrev.com/7cc259dcc527e59251c7a97cc0bbdc0deb0d5c21/content/browser/frame_host/navigation_controller_impl.cc
[modify] https://crrev.com/7cc259dcc527e59251c7a97cc0bbdc0deb0d5c21/content/browser/frame_host/navigation_controller_impl.h
[modify] https://crrev.com/7cc259dcc527e59251c7a97cc0bbdc0deb0d5c21/content/browser/frame_host/navigation_controller_impl_unittest.cc
[modify] https://crrev.com/7cc259dcc527e59251c7a97cc0bbdc0deb0d5c21/content/browser/frame_host/navigator_impl.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/be3da51753054798168076d71f9c77d4c74ec598

commit be3da51753054798168076d71f9c77d4c74ec598
Author: Eugene But <eugenebut@chromium.org>
Date: Mon Oct 23 15:34:03 2017

Use SameDocument term instead of InPage in ActiveTabTest.

Old name was presumably used to match was_within_same_page IPC, but
SameDocument name better reflects the the type of the navigation
(navigation did not change the document object).

This change will make naming more consistent with the rest of Chromium
code.


Bug:  695189 
Change-Id: Iedd6198060a1107b4cb251af547a3364bef9a88e
Reviewed-on: https://chromium-review.googlesource.com/731681
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Commit-Queue: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510801}
[modify] https://crrev.com/be3da51753054798168076d71f9c77d4c74ec598/chrome/browser/extensions/active_tab_unittest.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cb685d6b5e274133a2310b618a0e8498540bac72

commit cb685d6b5e274133a2310b618a0e8498540bac72
Author: Eugene But <eugenebut@chromium.org>
Date: Fri Oct 27 17:03:15 2017

Corrected comment for WebNavigationTabObserver::IsReferenceFragmentNavigation.

s/IsURLInPageNavigation/IsURLSameDocumentNavigation because that's the actual
name of the method.

TBR=nasko@chromium.org

Bug:  695189 
Change-Id: Id3c3c8239644f6da4d6907414f4e4d949f638761
Reviewed-on: https://chromium-review.googlesource.com/734810
Reviewed-by: Eugene But <eugenebut@chromium.org>
Commit-Queue: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#512216}
[modify] https://crrev.com/cb685d6b5e274133a2310b618a0e8498540bac72/chrome/browser/extensions/api/web_navigation/web_navigation_api.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1e62d55d6dac70f1ba43880e89dae7968b09331e

commit 1e62d55d6dac70f1ba43880e89dae7968b09331e
Author: Eugene But <eugenebut@chromium.org>
Date: Sat Feb 10 16:02:00 2018

Rename TestPreClassificationCheckInPageNavigation to TestPreClassificationCheckSameDocumentNavigation.

Old name was presumably used to match was_within_same_page IPC, but
SameDocument name better reflects the the type of the navigation
(navigation did not change the document object).

This change will make naming more consistent with the rest of Chromium
code.

Bug:  695189 
Change-Id: Ib0e1229d1730d6ac01038aed112a47d9eea78015
Reviewed-on: https://chromium-review.googlesource.com/912451
Reviewed-by: Nathan Parker <nparker@chromium.org>
Commit-Queue: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#535978}
[modify] https://crrev.com/1e62d55d6dac70f1ba43880e89dae7968b09331e/chrome/browser/safe_browsing/client_side_detection_host_unittest.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a5d8c00164f40a069e6226a010a06a3208c9505b

commit a5d8c00164f40a069e6226a010a06a3208c9505b
Author: Eugene But <eugenebut@chromium.org>
Date: Mon Feb 12 17:00:29 2018

Rename PermissionRequestManagerBrowserTest.InPageNavigation to SameDocumentNavigation.

Old name was presumably used to match was_within_same_page IPC, but
SameDocument name better reflects the the type of the navigation
(navigation did not change the document object).

This change will make naming more consistent with the rest of Chromium
code.

Bug:  695189 
Change-Id: Ie6bbc01e33a1d5045754a798a5a6c3d853fccf0f
Reviewed-on: https://chromium-review.googlesource.com/912106
Reviewed-by: Timothy Loh <timloh@chromium.org>
Commit-Queue: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#536110}
[modify] https://crrev.com/a5d8c00164f40a069e6226a010a06a3208c9505b/chrome/browser/permissions/permission_request_manager_browsertest.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bef56b40a4aa9461aa8565e1d4c5311495fa42fb

commit bef56b40a4aa9461aa8565e1d4c5311495fa42fb
Author: Eugene But <eugenebut@chromium.org>
Date: Mon Feb 12 17:07:58 2018

s/InPage/SameDocument in TranslateManagerRenderViewHostTest.

Old name was presumably used to match was_within_same_page IPC, but
SameDocument name better reflects the the type of the navigation
(navigation did not change the document object).

This change will make naming more consistent with the rest of Chromium
code.

TBR=napper@chromium.org

Bug:  695189 
Change-Id: Ide52dfb417b62b35ea225e4b2b9b1f28ba792de6
Reviewed-on: https://chromium-review.googlesource.com/912455
Commit-Queue: Eugene But <eugenebut@chromium.org>
Reviewed-by: Jia Meng <jiameng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#536113}
[modify] https://crrev.com/bef56b40a4aa9461aa8565e1d4c5311495fa42fb/chrome/browser/translate/translate_manager_render_view_host_unittest.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bac67e8bd478deb852a6b7c3a4ae3cc14b162e75

commit bac67e8bd478deb852a6b7c3a4ae3cc14b162e75
Author: Eugene But <eugenebut@chromium.org>
Date: Wed Feb 14 18:20:41 2018

Rename PageActionInPageNavigation to PageActionSameDocumentNavigation.

Old name was presumably used to match was_within_same_page IPC, but
SameDocument name better reflects the the type of the navigation
(navigation did not change the document object).

This change will make naming more consistent with the rest of Chromium
code.

Bug:  695189 
Change-Id: If70aa7b7b315773a496db08fc2b7878465b5c5b4
Reviewed-on: https://chromium-review.googlesource.com/912104
Reviewed-by: Ken Rockot <rockot@chromium.org>
Commit-Queue: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#536757}
[modify] https://crrev.com/bac67e8bd478deb852a6b7c3a4ae3cc14b162e75/chrome/browser/extensions/page_action_browsertest.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0199f0ae9361afc725f620102578a31c3986a437

commit 0199f0ae9361afc725f620102578a31c3986a437
Author: Eugene But <eugenebut@chromium.org>
Date: Wed Feb 14 21:47:06 2018

s/InPage/SameDocument in WebContentsMainFrameObserverTest.

Old name was presumably used to match was_within_same_page IPC, but
SameDocument name better reflects the the type of the navigation
(navigation did not change the document object).

This change will make naming more consistent with the rest of Chromium
code.

Bug:  695189 
Change-Id: I68243398f161d9c6b139957bb97f95f55b5e3175
Reviewed-on: https://chromium-review.googlesource.com/912456
Reviewed-by: Ben Greenstein <bengr@chromium.org>
Commit-Queue: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#536829}
[modify] https://crrev.com/0199f0ae9361afc725f620102578a31c3986a437/components/dom_distiller/content/browser/web_contents_main_frame_observer_unittest.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9818a0721d40f6f82c9d8704989c6eee5c01b621

commit 9818a0721d40f6f82c9d8704989c6eee5c01b621
Author: Eugene But <eugenebut@chromium.org>
Date: Wed Feb 14 23:40:41 2018

Rename InPageNavigationsAndReload to SameDocumentNavigationsAndReload.

Old name was presumably used to match was_within_same_page IPC, but
SameDocument name better reflects the the type of the navigation
(navigation did not change the document object).

This change will make naming more consistent with the rest of Chromium
code.

Bug:  695189 
Change-Id: Icebfcf14b4f57041b93268116748405b7628e685
Reviewed-on: https://chromium-review.googlesource.com/912203
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#536886}
[modify] https://crrev.com/9818a0721d40f6f82c9d8704989c6eee5c01b621/chrome/browser/ui/webui/webui_browsertest.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/712f03dc41664a3ad8ad93cc303af225d82b32ea

commit 712f03dc41664a3ad8ad93cc303af225d82b32ea
Author: Eugene But <eugenebut@google.com>
Date: Tue May 22 16:03:44 2018

Rename is_navigation_within_page to is_same_document_navigation.

Old name was presumably used to match was_within_same_page IPC, but
SameDocument name better reflects the the type of the navigation
(navigation did not change the document object).

This change will make naming more consistent with the rest of Chromium
code.

Bug:  695189 
Change-Id: I448c9a96c3a19b9ebbf3956c48e820bf432a40d3
Reviewed-on: https://chromium-review.googlesource.com/1067877
Reviewed-by: Camille Lamy <clamy@chromium.org>
Commit-Queue: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560619}
[modify] https://crrev.com/712f03dc41664a3ad8ad93cc303af225d82b32ea/content/browser/frame_host/navigation_controller_impl.cc
[modify] https://crrev.com/712f03dc41664a3ad8ad93cc303af225d82b32ea/content/browser/frame_host/navigation_controller_impl.h

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c3bc0e04396b00f239b0644ce520ad18c461b10b

commit c3bc0e04396b00f239b0644ce520ad18c461b10b
Author: Eugene But <eugenebut@google.com>
Date: Tue May 22 16:04:52 2018

Rename ClientRedirectAfterInPageNavigation to ClientRedirectAfterSameDocumentNavigation.

Old name was presumably used to match was_within_same_page IPC, but
SameDocument name better reflects the the type of the navigation
(navigation did not change the document object).

This change will make naming more consistent with the rest of Chromium
code.

Bug:  695189 
Change-Id: If6d01313248df8cfb8003ce5a9964da04d61f4e4
Reviewed-on: https://chromium-review.googlesource.com/1067841
Reviewed-by: Camille Lamy <clamy@chromium.org>
Commit-Queue: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560621}
[modify] https://crrev.com/c3bc0e04396b00f239b0644ce520ad18c461b10b/content/browser/frame_host/navigation_controller_impl_unittest.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0579ec8f4b8adf49540e98d96f19d9c2c8f54942

commit 0579ec8f4b8adf49540e98d96f19d9c2c8f54942
Author: Eugene But <eugenebut@google.com>
Date: Tue May 22 17:18:17 2018

Rename DidNavigateWithinPage to DidFinishSameDocumentNavigation.

SameDocumentNavigation name better reflects the the type of the
navigation (navigation did not change the document object).

This change will make naming more consistent with the rest of Chromium
code.

Bug:  695189 
Change-Id: Ifcebdb8e7089cb29a3ecda5413ff882dc8b34082
Reviewed-on: https://chromium-review.googlesource.com/1067893
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Camille Lamy <clamy@chromium.org>
Reviewed-by: Charlie Reis <creis@chromium.org>
Commit-Queue: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560671}
[modify] https://crrev.com/0579ec8f4b8adf49540e98d96f19d9c2c8f54942/content/public/test/render_view_test.cc
[modify] https://crrev.com/0579ec8f4b8adf49540e98d96f19d9c2c8f54942/content/renderer/render_frame_impl.cc
[modify] https://crrev.com/0579ec8f4b8adf49540e98d96f19d9c2c8f54942/content/renderer/render_frame_impl.h
[modify] https://crrev.com/0579ec8f4b8adf49540e98d96f19d9c2c8f54942/content/renderer/render_frame_impl_browsertest.cc
[modify] https://crrev.com/0579ec8f4b8adf49540e98d96f19d9c2c8f54942/content/shell/test_runner/web_frame_test_client.cc
[modify] https://crrev.com/0579ec8f4b8adf49540e98d96f19d9c2c8f54942/content/shell/test_runner/web_frame_test_client.h
[modify] https://crrev.com/0579ec8f4b8adf49540e98d96f19d9c2c8f54942/content/shell/test_runner/web_frame_test_proxy.h
[modify] https://crrev.com/0579ec8f4b8adf49540e98d96f19d9c2c8f54942/third_party/blink/public/web/web_frame_client.h
[modify] https://crrev.com/0579ec8f4b8adf49540e98d96f19d9c2c8f54942/third_party/blink/renderer/core/exported/local_frame_client_impl.cc
[modify] https://crrev.com/0579ec8f4b8adf49540e98d96f19d9c2c8f54942/third_party/blink/renderer/core/exported/local_frame_client_impl.h
[modify] https://crrev.com/0579ec8f4b8adf49540e98d96f19d9c2c8f54942/third_party/blink/renderer/core/exported/web_frame_test.cc
[modify] https://crrev.com/0579ec8f4b8adf49540e98d96f19d9c2c8f54942/third_party/blink/renderer/core/frame/local_frame_client.h
[modify] https://crrev.com/0579ec8f4b8adf49540e98d96f19d9c2c8f54942/third_party/blink/renderer/core/loader/document_loader.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9fb98d15b5984dadb15ffa2475cc536ab539f62e

commit 9fb98d15b5984dadb15ffa2475cc536ab539f62e
Author: Eugene But <eugenebut@google.com>
Date: Tue May 22 18:28:33 2018

Renamed IsURLInPageNavigation to IsURLSameDocumentNavigation

This fixes the comment. The function was renamed here:
https://chromium-review.googlesource.com/675443

Bug:  695189 
Change-Id: I58854785604b549d741c1a6287f66a767f749c12
Reviewed-on: https://chromium-review.googlesource.com/1067848
Reviewed-by: Charlie Reis <creis@chromium.org>
Commit-Queue: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560710}
[modify] https://crrev.com/9fb98d15b5984dadb15ffa2475cc536ab539f62e/content/browser/frame_host/navigation_controller_impl.cc

I think at this point 99% of same-document navigation code uses consistent terminology.  Finding and fixing remaining code which is not consistent would be too much efforts.

Thanks a ton for your persistence on this!