New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 695185 link

Starred by 1 user
Status: Assigned
Owner:
█ yolandyan@chromium.org
not available
Cc:
boliu@chromium.org
█ aber...@chromium.org
jbudorick@chromium.org
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocked on:
issue 640116
issue 673092


Sign in to add a comment

Refactor content instrumentation test to use JUnit4 Parameterized test

Project Member Reported by yolandyan@chromium.org, Feb 22 2017 
Currently, each content/ java instrumentation test runs twice with two configurations (latter replaces the containerView), The current implementation makes it hard to distinguish two runs or when a test fails which configuration is it under.

This should refactored using parameterized test once it is landed.

Code: https://cs.chromium.org/chromium/src/content/shell/android/javatests/src/org/chromium/content_shell_apk/ContentShellTestBase.java

Comment 1 by dgn@chromium.org, Mar 21 2017

Cc: aber...@chromium.org
Junit5 has a feature for Nested tests, that should allow for more control than parameterized tests: https://blog.stylingandroid.com/junit-5-nestedtests/

Could we move straight up to that?

Comment 2 by yolandyan@chromium.org, Mar 21 2017 

I don't think it's worth the effort yet.

JUnit5 is not currently support for Android instrumentation and probably won't be for a long while (consider the first official junit5 release was last year).

If we want to write test using JUnit5, we would have to add support on interaction with activities which might differ from what Android. 

Also robolectric/junit tests are completely implemented on top of JUnit4, that is probably not gonna change anytime soon.

Comment 3 by benhenry@chromium.org, Aug 1

Status: Assigned (was: Untriaged)
►

Sign in to add a comment