New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 695181 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner: ----
Closed: Aug 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Use sk_malloc in SkArenaAlloc and SkData

Project Member Reported by dskiba@chromium.org, Feb 22 2017

Issue description

While Skia allocates majority of its memory via sk_malloc_ API (implemented by Chrome), there are two places that allocate sizeable amounts via operator new: SkArenaAlloc and SkData. For example loading / scrolling TheVerge to the bottom reveals (see http://go/stsjt) that:

1. sk_malloc_ API allocated 5.9 MiB
2. SkData::PrivateNewWithCopy allocated 544 KiB with operator new()
3. SkArenaAlloc::ensureSpace allocated 467 KiB with new char[]

Can we change SkData and SkArenaAlloc to also use sk_malloc_ API?

We have plans to (somehow) instrument sk_malloc_ and report totals to the tracing infrastructure, so fixing these two would give us better picture.


 
Ping. Guys, what do you think?

Comment 2 by herb@chromium.org, Aug 22 2017

Status: WontFix (was: Untriaged)
Works as intended.

Comment 3 by dskiba@chromium.org, Aug 22 2017

What was the intention behind #2 (SkData::PrivateNewWithCopy) and #3 (SkArenaAlloc::ensureSpace)?

Sign in to add a comment