Use sk_malloc in SkArenaAlloc and SkData |
||
Issue descriptionWhile Skia allocates majority of its memory via sk_malloc_ API (implemented by Chrome), there are two places that allocate sizeable amounts via operator new: SkArenaAlloc and SkData. For example loading / scrolling TheVerge to the bottom reveals (see http://go/stsjt) that: 1. sk_malloc_ API allocated 5.9 MiB 2. SkData::PrivateNewWithCopy allocated 544 KiB with operator new() 3. SkArenaAlloc::ensureSpace allocated 467 KiB with new char[] Can we change SkData and SkArenaAlloc to also use sk_malloc_ API? We have plans to (somehow) instrument sk_malloc_ and report totals to the tracing infrastructure, so fixing these two would give us better picture.
,
Aug 22 2017
Works as intended.
,
Aug 22 2017
What was the intention behind #2 (SkData::PrivateNewWithCopy) and #3 (SkArenaAlloc::ensureSpace)? |
||
►
Sign in to add a comment |
||
Comment 1 by dskiba@chromium.org
, Mar 2 2017