resource_sizes.py should sanity check native library within output directory matches |
|||
Issue descriptionRight now resource_sizes.py uses the libchrome.so within out/Default/lib.unstripped in order to perform some of its measurements. When doing so, it should check the buildid of the .so to ensure it matches the one stored within the apk.
,
Feb 23 2017
Should we just use the actual .so in the APK or is the point here to make sure these two versions match?
,
Feb 23 2017
Hmm, good point. Looking more closely, I think we just need the unstripped version for: GetStaticInitializers() We should be using the apk copy for: CountStaticInitializers() We'll also need the unstripped one if we add native code breakdowns ( bug 681694 )
,
Feb 28 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/636c61da146a7294fa65857a6d5c0ed04f99c586 commit 636c61da146a7294fa65857a6d5c0ed04f99c586 Author: estevenson <estevenson@chromium.org> Date: Tue Feb 28 21:01:37 2017 Android: improve static initializer counting in resource_sizes.py. This CL also includes some other cleanup items: * Add a helper function for reading a single file from a zip archive * Ensure stale output dirs aren't used by checking the build id of .so files * Use the APK version of .so files instead of the output-dir version when possible * Remove obsolete args * Use argparse instead of optparse * Use toolchain specific binary utilities BUG= 695177 Review-Url: https://codereview.chromium.org/2706243013 Cr-Commit-Position: refs/heads/master@{#453698} [modify] https://crrev.com/636c61da146a7294fa65857a6d5c0ed04f99c586/build/android/BUILD.gn [modify] https://crrev.com/636c61da146a7294fa65857a6d5c0ed04f99c586/build/android/gyp/util/build_utils.py [modify] https://crrev.com/636c61da146a7294fa65857a6d5c0ed04f99c586/build/android/resource_sizes.py
,
Mar 2 2017
,
May 9 2017
|
|||
►
Sign in to add a comment |
|||
Comment 1 by estevenson@chromium.org
, Feb 23 2017Owner: estevenson@chromium.org
Status: Assigned (was: Available)