Remove the gn_only, both_gn_and_gyp groups |
|||
Issue descriptionWe still have separate gn_only and both_gn_and_gyp groups, and associated comments, in the top-level BUILD.gn. We should be able to coalesce those now.
,
Mar 7 2017
Yes, your help would be welcome :).
,
Mar 8 2017
,
Mar 8 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fbc99249d5d02c81d0f42ffb9f6af28b1451f442 commit fbc99249d5d02c81d0f42ffb9f6af28b1451f442 Author: tfarina <tfarina@chromium.org> Date: Wed Mar 08 22:44:04 2017 fold both_gn_and_gyp and gn_only groups into gn_all It is not necessary to have them anymore now that GYP build is gone. BUG= 695174 R=dpranke@chromium.org Review-Url: https://codereview.chromium.org/2734303002 Cr-Commit-Position: refs/heads/master@{#455566} [modify] https://crrev.com/fbc99249d5d02c81d0f42ffb9f6af28b1451f442/BUILD.gn
,
May 10 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/79acccf6d5f88dfe4c2b00f842c9decbc5ac958a commit 79acccf6d5f88dfe4c2b00f842c9decbc5ac958a Author: tfarina <tfarina@chromium.org> Date: Wed May 10 13:04:16 2017 merge some duplicated conditions in gn_all https://codereview.chromium.org/2734303002/diff/1/BUILD.gn#newcode584 BUG= 695174 R=dpranke@chromium.org Review-Url: https://codereview.chromium.org/2871033002 Cr-Commit-Position: refs/heads/master@{#470547} [modify] https://crrev.com/79acccf6d5f88dfe4c2b00f842c9decbc5ac958a/BUILD.gn
,
May 11 2017
|
|||
►
Sign in to add a comment |
|||
Comment 1 by tfarina@chromium.org
, Mar 7 2017