Regression: cursor_loader_x11.cc breaks MiddleClickAutoscroll on Linux |
|||
Issue descriptionOS: Linux What steps will reproduce the problem? (1)Run Chromium from command line and enable MiddleClickAutoscroll by --enable-blink-features=MiddleClickAutoscroll (2)Open a web page that can be scrolled (3)Click with the middle button What is the expected result? MiddleClickAutoscroll should be triggered and the cursor should be changed to an arrow indicating the scrolling direction. What happens instead? The browser crashed [980:980:0222/150735.644408:FATAL:cursor_loader_x11.cc(39)] Check failed: false. There's no middle-click panning on Linux or ChromeOS #0 0x7f422036677b base::debug::StackTrace::StackTrace() #1 0x7f4220364dbc base::debug::StackTrace::StackTrace() #2 0x7f42203d2faf logging::LogMessage::~LogMessage() #3 0x7f421d3e9096 (anonymous namespace)::CursorCssNameFromId() #4 0x7f421d3e894e ui::CursorLoaderX11::CursorFromId() #5 0x7f421d3e88d0 ui::CursorLoaderX11::SetPlatformCursor() #6 0x7f4214e47c17 views::DesktopNativeCursorManager::SetCursor() #7 0x7f421303fe6f wm::CursorManager::SetCursor() #8 0x7f421a10e3c7 content::RenderWidgetHostViewAura::UpdateCursorIfOverSelf() #9 0x7f421a10e0a5 content::RenderWidgetHostViewAura::UpdateCursor() #10 0x7f421a0e189c content::RenderWidgetHostImpl::SetCursor() #11 0x7f421a0dcc52 content::RenderWidgetHostImpl::OnSetCursor() As I go through the crash log, I found this line(https://cs.chromium.org/chromium/src/ui/base/cursor/cursor_loader_x11.cc?l=39) breaks the feature. It's from the patch(https://codereview.chromium.org/2504743002). thomasanderson@, could you please take a look at it? We've enabled the MiddleClickAutoscroll on Linux so it should no longer be blocked. Thanks!
,
Feb 22 2017
If I middle-click in a textarea with text selected and the window is scrollable, then the selected text is pasted, but the window also scrolls. We should fix this before enabling middle-click scrolling. +pkasting@ Do you think we should enable middle-click scrolling on Linux at all? I'm sort of against it. No other Linux apps have this type of scrolling, including firefox. I think middle-click scrolling is mainly a Windows-ism.
,
Feb 22 2017
I didn't know middle-mouse autoscroll wasn't enabled on Linux, or that there was an effort to enable it now. Without context of that discussion, it's hard for me to speak definitively. I'm less worried about whether other Linux apps have this than whether it feels actively wrong for the platform. I'd like to maintain parity with our other platforms if we can and it doesn't break things, but I'm willing to live with not having this if it feels lousy.
,
Feb 23 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7c9f614166029371f91aa336d3154ed0cf4d224e commit 7c9f614166029371f91aa336d3154ed0cf4d224e Author: thomasanderson <thomasanderson@google.com> Date: Thu Feb 23 05:18:20 2017 Add MiddleClickAutoscroll cursors back on X11 Middle click autoscroll is usable on Linux with --enable-blink-features=MiddleClickAutoscroll, so add the appropriate X11 cursors. BUG= 695163 R=sadrul@chromium.org Review-Url: https://codereview.chromium.org/2705293009 Cr-Commit-Position: refs/heads/master@{#452404} [modify] https://crrev.com/7c9f614166029371f91aa336d3154ed0cf4d224e/ui/base/cursor/cursor_loader_x11.cc
,
Feb 23 2017
|
|||
►
Sign in to add a comment |
|||
Comment 1 by thomasanderson@chromium.org
, Feb 22 2017