There should be a presubmit to verify that testing/buildbot/chomium.perf(.fyi)?.json is up to date |
||||||
Issue descriptionI made the mistake earlier today of not rerunning tools/perf/generate_perf_json.py after deleting a benchmark, which resulted in bug 695156 . We should create a presubmit to ensure this doesn't happen again.
,
Feb 22 2017
Yes. I've been planning on doing this. Not sure when I'll get to this. Not for the next one or two weeks, I think (doing perf).
,
Feb 22 2017
SGTM
,
Feb 23 2017
This is actually should be P1 since it's very easy to forget to sync the file (e.g: https://codereview.chromium.org/2711143002/)
,
Feb 23 2017
I will take this as Stephen is swarmed this week & next week.
,
Feb 23 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/292aea8a39a41d3d01cf754680d814ebc0d72b30 commit 292aea8a39a41d3d01cf754680d814ebc0d72b30 Author: nednguyen <nednguyen@google.com> Date: Thu Feb 23 19:06:00 2017 Add PRESUBMIT to make sure that perf JSON configs are always up-to-date BUG= 695162 Review-Url: https://codereview.chromium.org/2713553008 Cr-Commit-Position: refs/heads/master@{#452573} [modify] https://crrev.com/292aea8a39a41d3d01cf754680d814ebc0d72b30/tools/perf/PRESUBMIT.py [modify] https://crrev.com/292aea8a39a41d3d01cf754680d814ebc0d72b30/tools/perf/generate_perf_json.py
,
Feb 23 2017
,
Feb 23 2017
W00t! Thanks Ned! |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by nedngu...@google.com
, Feb 22 2017