New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 695133 link

Starred by 1 user

Issue metadata

Status: Archived
Owner:
Closed: Feb 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

Reset target version prefix to empty string should be reflected in omaha request as well.

Project Member Reported by xiy...@chromium.org, Feb 22 2017

Issue description

Repro steps:
1. Set up an OS pin (either general os pin or kiosk app pin);
2. Resets the OS pin;

After step 1, observe update_engine has the pinned OS version as target version prefix in omaha request params;

After step 2, refresh policy and without rebooting the device, observe update_engine and the target version prefix in omaha request params should be removed.
 
Cc: mnilsson@chromium.org
Project Member

Comment 2 by bugdroid1@chromium.org, Feb 27 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/aosp/platform/system/update_engine/+/4d34c18e5ce29d138c7946cc817dee8b3fce7cf0

commit 4d34c18e5ce29d138c7946cc817dee8b3fce7cf0
Author: Xiyuan Xia <xiyuan@google.com>
Date: Mon Feb 27 20:03:24 2017

Always update target version prefix

When UpdateAttempter::Update is called, the cached target version
prefix in its |omaha_request_params_| should always be updated with
the one passed in.

Also fix the target version LOG lines in kiosk app pin policy code.

BUG= chromium:695133 
TEST=UpdateAttempterTest.TargetVersionPrefixSetAndReset

Change-Id: I873a9ad9151f47414aac9273bb3b85d4f9f73f32
Reviewed-on: https://chromium-review.googlesource.com/446657
Commit-Ready: Xiyuan Xia <xiyuan@chromium.org>
Tested-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Alex Deymo <deymo@chromium.org>
Reviewed-by: Ben Chan <benchan@chromium.org>

[modify] https://crrev.com/4d34c18e5ce29d138c7946cc817dee8b3fce7cf0/update_manager/chromeos_policy.cc
[modify] https://crrev.com/4d34c18e5ce29d138c7946cc817dee8b3fce7cf0/update_attempter_unittest.cc
[modify] https://crrev.com/4d34c18e5ce29d138c7946cc817dee8b3fce7cf0/update_attempter.h
[modify] https://crrev.com/4d34c18e5ce29d138c7946cc817dee8b3fce7cf0/update_attempter.cc

Comment 3 by xiy...@chromium.org, Feb 27 2017

Labels: M-58
Status: Fixed (was: Assigned)

Comment 4 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Sign in to add a comment