chasej@ pointed out that Origin Trials are only allowed in secure contexts (I haven't verified that this logic is functional but I will believe it) so it looks like the problem is actually in the generated code for Origin Trials where it checks RuntimeEnabledFeatures::fooEnabled() before performing the trial check that I assume will fail in an insecure context.

 Issue 706260  has been merged into this issue.

I just went through a debugging session and ended up finding this one...

I think we should as a quick fix report an error if we see these two, linking to this bug (like we do if OriginTrialEnabled and RuntimeEnabled are mixed). I can do that.

CL to add that check and error: https://codereview.chromium.org/2780093003

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/eb6e06daaefc9d173132724d905ce77a3ece95d3

commit eb6e06daaefc9d173132724d905ce77a3ece95d3
Author: mgiuca <mgiuca@chromium.org>
Date: Tue Apr 04 07:22:37 2017

V8 bindings gen: Error if OriginTrialEnabled and SecureContext together.

If these are found together, they currently generate completely broken
code (the origin trial is not checked). Therefore, throw an error at
compile time and point the unlucky developer to a workaround.

BUG= 695123 

Review-Url: https://codereview.chromium.org/2780093003
Cr-Commit-Position: refs/heads/master@{#461653}

[modify] https://crrev.com/eb6e06daaefc9d173132724d905ce77a3ece95d3/third_party/WebKit/Source/bindings/modules/v8/ConditionalFeaturesForModules.cpp
[modify] https://crrev.com/eb6e06daaefc9d173132724d905ce77a3ece95d3/third_party/WebKit/Source/bindings/scripts/v8_utilities.py
[modify] https://crrev.com/eb6e06daaefc9d173132724d905ce77a3ece95d3/third_party/WebKit/Source/modules/serviceworkers/NavigationPreloadManager.idl

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4dbfdb063d396295597734d850b8f41c20aa50f1

commit 4dbfdb063d396295597734d850b8f41c20aa50f1
Author: mgiuca <mgiuca@chromium.org>
Date: Fri Apr 07 01:20:50 2017

V8 bindings gen: Error if FeaturePolicy and SecureContext together.

This check was previously added for OriginTrialEnabled and SecureContext
(r461653). This applies the same check to FeaturePolicy which has the
same limitation (i.e., this *should* work but currently generates broken
code where FeaturePolicy is totally ignored, and therefore must be a
compile-time error for now.

BUG= 695123 

Review-Url: https://codereview.chromium.org/2802873003
Cr-Commit-Position: refs/heads/master@{#462730}

[modify] https://crrev.com/4dbfdb063d396295597734d850b8f41c20aa50f1/third_party/WebKit/Source/bindings/scripts/v8_utilities.py

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/61358d56517577686b5003b89146cc2071f79ed1

commit 61358d56517577686b5003b89146cc2071f79ed1
Author: chasej <chasej@chromium.org>
Date: Tue Apr 11 04:03:52 2017

Cleanup expected.txt files for layout tests

Rework the layout tests for origin trials so the expected.txt files are
no longer needed. This was addressing the harness error about duplicate
test names. Due to tests being run in multiple workers, the structure
was reworked to make it easier to create unique test names.

Also, remove the expectation for a flaky test, since the expected.txt
files were forcing the flaky results (see  crbug.com/705953 ).

This is a precursor so later changes to the layout tests do not require
changing multiple expected.txt files.

BUG= 695123 ,  705953 

Review-Url: https://codereview.chromium.org/2808543002
Cr-Commit-Position: refs/heads/master@{#463525}

[modify] https://crrev.com/61358d56517577686b5003b89146cc2071f79ed1/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/61358d56517577686b5003b89146cc2071f79ed1/third_party/WebKit/LayoutTests/http/tests/origin_trials/resources/disabled-worker.js
[modify] https://crrev.com/61358d56517577686b5003b89146cc2071f79ed1/third_party/WebKit/LayoutTests/http/tests/origin_trials/resources/enabled-worker.js
[add] https://crrev.com/61358d56517577686b5003b89146cc2071f79ed1/third_party/WebKit/LayoutTests/http/tests/origin_trials/resources/origintrials-worker.js
[rename] https://crrev.com/61358d56517577686b5003b89146cc2071f79ed1/third_party/WebKit/LayoutTests/http/tests/origin_trials/resources/origintrials.js
[modify] https://crrev.com/61358d56517577686b5003b89146cc2071f79ed1/third_party/WebKit/LayoutTests/http/tests/origin_trials/resources/sample-api-enabled-worker.php
[modify] https://crrev.com/61358d56517577686b5003b89146cc2071f79ed1/third_party/WebKit/LayoutTests/http/tests/origin_trials/sample-api-broken.html
[modify] https://crrev.com/61358d56517577686b5003b89146cc2071f79ed1/third_party/WebKit/LayoutTests/http/tests/origin_trials/sample-api-disabled.html
[delete] https://crrev.com/fb21662ee5c04e2bfa9de9e4b9a86e5f101c524e/third_party/WebKit/LayoutTests/http/tests/origin_trials/sample-api-enabled-expected.txt
[delete] https://crrev.com/fb21662ee5c04e2bfa9de9e4b9a86e5f101c524e/third_party/WebKit/LayoutTests/http/tests/origin_trials/sample-api-enabled-header-expected.txt
[modify] https://crrev.com/61358d56517577686b5003b89146cc2071f79ed1/third_party/WebKit/LayoutTests/http/tests/origin_trials/sample-api-enabled-header.php
[modify] https://crrev.com/61358d56517577686b5003b89146cc2071f79ed1/third_party/WebKit/LayoutTests/http/tests/origin_trials/sample-api-enabled.html
[modify] https://crrev.com/61358d56517577686b5003b89146cc2071f79ed1/third_party/WebKit/LayoutTests/http/tests/origin_trials/sample-api-expired.html
[delete] https://crrev.com/fb21662ee5c04e2bfa9de9e4b9a86e5f101c524e/third_party/WebKit/LayoutTests/http/tests/origin_trials/sample-api-multiple-tokens-expected.txt
[delete] https://crrev.com/fb21662ee5c04e2bfa9de9e4b9a86e5f101c524e/third_party/WebKit/LayoutTests/http/tests/origin_trials/sample-api-multiple-tokens-header-expected.txt
[modify] https://crrev.com/61358d56517577686b5003b89146cc2071f79ed1/third_party/WebKit/LayoutTests/http/tests/origin_trials/sample-api-multiple-tokens-header.php
[modify] https://crrev.com/61358d56517577686b5003b89146cc2071f79ed1/third_party/WebKit/LayoutTests/http/tests/origin_trials/sample-api-multiple-tokens.html
[delete] https://crrev.com/fb21662ee5c04e2bfa9de9e4b9a86e5f101c524e/third_party/WebKit/LayoutTests/http/tests/origin_trials/sample-api-script-added-before-access-expected.txt
[modify] https://crrev.com/61358d56517577686b5003b89146cc2071f79ed1/third_party/WebKit/LayoutTests/http/tests/origin_trials/sample-api-script-added-before-access.html
[delete] https://crrev.com/fb21662ee5c04e2bfa9de9e4b9a86e5f101c524e/third_party/WebKit/LayoutTests/http/tests/origin_trials/sample-api-script-added-expected.txt
[modify] https://crrev.com/61358d56517577686b5003b89146cc2071f79ed1/third_party/WebKit/LayoutTests/http/tests/origin_trials/sample-api-script-added.html
[modify] https://crrev.com/61358d56517577686b5003b89146cc2071f79ed1/third_party/WebKit/LayoutTests/http/tests/origin_trials/sample-api-stolen.html
[delete] https://crrev.com/fb21662ee5c04e2bfa9de9e4b9a86e5f101c524e/third_party/WebKit/LayoutTests/http/tests/origin_trials/sample-api-workers-expected.txt
[delete] https://crrev.com/fb21662ee5c04e2bfa9de9e4b9a86e5f101c524e/third_party/WebKit/LayoutTests/platform/linux/virtual/mojo-loading/http/tests/origin_trials/sample-api-workers-expected.txt

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fbd04b8d08a73374d9720de6c01ff36dd13428a1

commit fbd04b8d08a73374d9720de6c01ff36dd13428a1
Author: chasej <chasej@chromium.org>
Date: Sat May 06 19:03:54 2017

Add Origin Trial layout tests for IDL bindings

The existing layout tests for Origin Trials cover both various enabling
scenarios, as well as bindings for [OriginTrialEnabled].

As shown by  bug 695123 , there isn't comprehensive coverage for all the
bindings possibilities.

This CL adds a separate set of layout tests explicitly for bindings,
in preparation for fixing  bug 695123 .

BUG= 695123 

Review-Url: https://codereview.chromium.org/2861673007
Cr-Commit-Position: refs/heads/master@{#469862}

[modify] https://crrev.com/fbd04b8d08a73374d9720de6c01ff36dd13428a1/third_party/WebKit/LayoutTests/http/tests/origin_trials/resources/origintrials.js
[add] https://crrev.com/fbd04b8d08a73374d9720de6c01ff36dd13428a1/third_party/WebKit/LayoutTests/http/tests/origin_trials/sample-api-disabled-insecure-context.html
[modify] https://crrev.com/fbd04b8d08a73374d9720de6c01ff36dd13428a1/third_party/WebKit/LayoutTests/http/tests/origin_trials/sample-api-disabled.html
[add] https://crrev.com/fbd04b8d08a73374d9720de6c01ff36dd13428a1/third_party/WebKit/LayoutTests/http/tests/origin_trials/sample-api-enabled-insecure-context.html
[modify] https://crrev.com/fbd04b8d08a73374d9720de6c01ff36dd13428a1/third_party/WebKit/LayoutTests/http/tests/origin_trials/sample-api-enabled.html
[modify] https://crrev.com/fbd04b8d08a73374d9720de6c01ff36dd13428a1/third_party/WebKit/LayoutTests/http/tests/origin_trials/sample-api-script-added.html
[modify] https://crrev.com/fbd04b8d08a73374d9720de6c01ff36dd13428a1/third_party/WebKit/Source/core/testing/OriginTrialsTest.cpp
[modify] https://crrev.com/fbd04b8d08a73374d9720de6c01ff36dd13428a1/third_party/WebKit/Source/core/testing/OriginTrialsTest.h
[modify] https://crrev.com/fbd04b8d08a73374d9720de6c01ff36dd13428a1/third_party/WebKit/Source/core/testing/OriginTrialsTest.idl
[modify] https://crrev.com/fbd04b8d08a73374d9720de6c01ff36dd13428a1/third_party/WebKit/Source/core/testing/OriginTrialsTestPartial.h
[modify] https://crrev.com/fbd04b8d08a73374d9720de6c01ff36dd13428a1/third_party/WebKit/Source/core/testing/OriginTrialsTestPartial.idl

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bf4fc3116e4ddc3bc718b95c571a87c143211f0a

commit bf4fc3116e4ddc3bc718b95c571a87c143211f0a
Author: chasej <chasej@chromium.org>
Date: Mon May 15 23:36:52 2017

A continuation from: https://codereview.chromium.org/2861673007/

This moves existing tests for enabling/disabling to be explicit
bindings tests. When testing changes for bindings, many of the
layout test files would fail, all for the same reason. Now, there
is separation for token handling vs bindings. That is, testing
that trials are enabled/disabled correctly, vs that IDL members
are exposed correctly for a trial.

As well, cleaned up the existing tests to use the helper methods
introduced in the previous CL. Two separate CLs to make it easier
to diff all changes.

BUG= 695123 

Review-Url: https://codereview.chromium.org/2863593003
Cr-Commit-Position: refs/heads/master@{#471944}

[modify] https://crrev.com/bf4fc3116e4ddc3bc718b95c571a87c143211f0a/third_party/WebKit/LayoutTests/http/tests/origin_trials/resources/origintrials.js
[modify] https://crrev.com/bf4fc3116e4ddc3bc718b95c571a87c143211f0a/third_party/WebKit/LayoutTests/http/tests/origin_trials/sample-api-enabled-header.php
[modify] https://crrev.com/bf4fc3116e4ddc3bc718b95c571a87c143211f0a/third_party/WebKit/LayoutTests/http/tests/origin_trials/sample-api-script-added-before-access.html

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3326804ff57fe560d03b1d6b740c272c01082bfe

commit 3326804ff57fe560d03b1d6b740c272c01082bfe
Author: chasej <chasej@chromium.org>
Date: Tue May 16 11:46:41 2017

Support combination of [OriginTrialEnabled] and [SecureContext]

This CL fixes the bindings logic to allow the [OriginTrialEnabled] and
[SecureContext] to be used together on the same IDL members.

The bug was found when trying to use [SecureContext] for WebUSB.
The IDL definition for WebUSB is corrected to use [SecureContext]
as well.

Other cleanups in this CL:
- Remove unused check_origin_trial macro
- Remove obsolete attribute variable, and fix reference for generating include
- Apply some consistency to attribute and method helper functions

BUG= 695123 

Review-Url: https://codereview.chromium.org/2880713002
Cr-Commit-Position: refs/heads/master@{#472062}

[modify] https://crrev.com/3326804ff57fe560d03b1d6b740c272c01082bfe/third_party/WebKit/LayoutTests/http/tests/origin_trials/resources/origintrials.js
[modify] https://crrev.com/3326804ff57fe560d03b1d6b740c272c01082bfe/third_party/WebKit/Source/bindings/modules/v8/ConditionalFeaturesForModules.cpp
[modify] https://crrev.com/3326804ff57fe560d03b1d6b740c272c01082bfe/third_party/WebKit/Source/bindings/scripts/code_generator.py
[modify] https://crrev.com/3326804ff57fe560d03b1d6b740c272c01082bfe/third_party/WebKit/Source/bindings/scripts/v8_attributes.py
[modify] https://crrev.com/3326804ff57fe560d03b1d6b740c272c01082bfe/third_party/WebKit/Source/bindings/scripts/v8_interface.py
[modify] https://crrev.com/3326804ff57fe560d03b1d6b740c272c01082bfe/third_party/WebKit/Source/bindings/scripts/v8_methods.py
[modify] https://crrev.com/3326804ff57fe560d03b1d6b740c272c01082bfe/third_party/WebKit/Source/bindings/scripts/v8_utilities.py
[modify] https://crrev.com/3326804ff57fe560d03b1d6b740c272c01082bfe/third_party/WebKit/Source/bindings/templates/attributes.cpp.tmpl
[modify] https://crrev.com/3326804ff57fe560d03b1d6b740c272c01082bfe/third_party/WebKit/Source/bindings/templates/interface.h.tmpl
[modify] https://crrev.com/3326804ff57fe560d03b1d6b740c272c01082bfe/third_party/WebKit/Source/bindings/templates/interface_base.cpp.tmpl
[modify] https://crrev.com/3326804ff57fe560d03b1d6b740c272c01082bfe/third_party/WebKit/Source/bindings/templates/methods.cpp.tmpl
[modify] https://crrev.com/3326804ff57fe560d03b1d6b740c272c01082bfe/third_party/WebKit/Source/bindings/templates/partial_interface.h.tmpl
[modify] https://crrev.com/3326804ff57fe560d03b1d6b740c272c01082bfe/third_party/WebKit/Source/bindings/templates/utilities.cpp.tmpl
[modify] https://crrev.com/3326804ff57fe560d03b1d6b740c272c01082bfe/third_party/WebKit/Source/bindings/tests/results/core/V8TestConstants.h
[modify] https://crrev.com/3326804ff57fe560d03b1d6b740c272c01082bfe/third_party/WebKit/Source/core/testing/OriginTrialsTest.idl
[modify] https://crrev.com/3326804ff57fe560d03b1d6b740c272c01082bfe/third_party/WebKit/Source/core/testing/OriginTrialsTestPartial.idl
[modify] https://crrev.com/3326804ff57fe560d03b1d6b740c272c01082bfe/third_party/WebKit/Source/modules/installedapp/NavigatorInstalledApp.idl
[modify] https://crrev.com/3326804ff57fe560d03b1d6b740c272c01082bfe/third_party/WebKit/Source/modules/webusb/NavigatorUSB.idl

Note that there's additional work required to fully support WebUSB. The WebUSB spec needs to be updated, but the intent is that none of the USB* IDL is exposed to non-secure contexts. Currently this is implemented by a combination of [SecureContext] applied to navigator.usb, and a remaining workaround in ConditionalFeaturesForModules.cpp.

Is this actually blocked on the spec changing? Or can we add [SecureContext] to the interface IDL files and remove the remaining workaround?

Feel free to update our IDL files and I'll update the spec to match. I didn't add [SecureContext] to the other WebUSB IDL files because I didn't think it mattered at the time but I understand things better now. navigator.usb is the only place where it matters in practice but for consistency we should put it on all the other interfaces as well.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8e7aa98860b23dc0d395b8b8306b7cc382b2c0ba

commit 8e7aa98860b23dc0d395b8b8306b7cc382b2c0ba
Author: Jason Chase <chasej@chromium.org>
Date: Thu Jul 27 23:48:56 2017

Fix exposure of interfaces with [SecureContext]

IDL interfaces with [SecureContext] applied are still visible in
insecure contexts. This was found when fixing [OriginTrialEnabled] and
[SecureContext] to work together correctly ( crbug.com/695123 ). Specifically,
with [SecureContext] in the IDL, the interface is still exposed as a
constructor attribute on Window.

When encountered on previous CLs, the solution was to run layout tests
in secure contexts:
https://codereview.chromium.org/2832813002
https://chromium-review.googlesource.com/c/506292/

This CL fixes the bindings logic so that [SecureContext] attribute is
flagged on the generated constructor attributes. The result is that the
existing bindings templates will generate the appropriate checks for
secure context.

Bug:  695123 ,  634270 
Change-Id: If6d37d4441ba06d4f2e04f4360ed28990a0e2547
Reviewed-on: https://chromium-review.googlesource.com/508328
Commit-Queue: Jason Chase <chasej@chromium.org>
Reviewed-by: Mike West <mkwst@chromium.org>
Reviewed-by: Ian Clelland <iclelland@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Yuki Shiino <yukishiino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#490132}
[modify] https://crrev.com/8e7aa98860b23dc0d395b8b8306b7cc382b2c0ba/third_party/WebKit/LayoutTests/http/tests/credentialmanager/passwordcredential-fetch-registrabledomain.html
[modify] https://crrev.com/8e7aa98860b23dc0d395b8b8306b7cc382b2c0ba/third_party/WebKit/Source/bindings/core/v8/LocalWindowProxy.cpp
[modify] https://crrev.com/8e7aa98860b23dc0d395b8b8306b7cc382b2c0ba/third_party/WebKit/Source/bindings/core/v8/WorkerOrWorkletScriptController.cpp
[modify] https://crrev.com/8e7aa98860b23dc0d395b8b8306b7cc382b2c0ba/third_party/WebKit/Source/bindings/scripts/generate_global_constructors.py
[modify] https://crrev.com/8e7aa98860b23dc0d395b8b8306b7cc382b2c0ba/third_party/WebKit/Source/bindings/scripts/v8_attributes.py
[modify] https://crrev.com/8e7aa98860b23dc0d395b8b8306b7cc382b2c0ba/third_party/WebKit/Source/bindings/scripts/v8_interface.py
[modify] https://crrev.com/8e7aa98860b23dc0d395b8b8306b7cc382b2c0ba/third_party/WebKit/Source/bindings/scripts/v8_methods.py
[modify] https://crrev.com/8e7aa98860b23dc0d395b8b8306b7cc382b2c0ba/third_party/WebKit/Source/bindings/templates/ConditionalFeaturesForCore.cpp.tmpl
[modify] https://crrev.com/8e7aa98860b23dc0d395b8b8306b7cc382b2c0ba/third_party/WebKit/Source/bindings/templates/ConditionalFeaturesForCore.h.tmpl
[modify] https://crrev.com/8e7aa98860b23dc0d395b8b8306b7cc382b2c0ba/third_party/WebKit/Source/bindings/templates/ConditionalFeaturesForModules.cpp.tmpl
[modify] https://crrev.com/8e7aa98860b23dc0d395b8b8306b7cc382b2c0ba/third_party/WebKit/Source/bindings/templates/attributes.cpp.tmpl
[modify] https://crrev.com/8e7aa98860b23dc0d395b8b8306b7cc382b2c0ba/third_party/WebKit/Source/bindings/templates/interface.h.tmpl
[modify] https://crrev.com/8e7aa98860b23dc0d395b8b8306b7cc382b2c0ba/third_party/WebKit/Source/bindings/templates/interface_base.cpp.tmpl
[modify] https://crrev.com/8e7aa98860b23dc0d395b8b8306b7cc382b2c0ba/third_party/WebKit/Source/bindings/templates/methods.cpp.tmpl
[modify] https://crrev.com/8e7aa98860b23dc0d395b8b8306b7cc382b2c0ba/third_party/WebKit/Source/bindings/templates/partial_interface.h.tmpl
[modify] https://crrev.com/8e7aa98860b23dc0d395b8b8306b7cc382b2c0ba/third_party/WebKit/Source/bindings/tests/results/core/ConditionalFeaturesForCore.cpp
[modify] https://crrev.com/8e7aa98860b23dc0d395b8b8306b7cc382b2c0ba/third_party/WebKit/Source/bindings/tests/results/core/ConditionalFeaturesForCore.h
[modify] https://crrev.com/8e7aa98860b23dc0d395b8b8306b7cc382b2c0ba/third_party/WebKit/Source/bindings/tests/results/core/V8TestInterface.cpp
[modify] https://crrev.com/8e7aa98860b23dc0d395b8b8306b7cc382b2c0ba/third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceSecureContext.cpp
[modify] https://crrev.com/8e7aa98860b23dc0d395b8b8306b7cc382b2c0ba/third_party/WebKit/Source/bindings/tests/results/modules/ConditionalFeaturesForModules.cpp
[modify] https://crrev.com/8e7aa98860b23dc0d395b8b8306b7cc382b2c0ba/third_party/WebKit/Source/bindings/tests/results/modules/V8TestInterface5.cpp
[modify] https://crrev.com/8e7aa98860b23dc0d395b8b8306b7cc382b2c0ba/third_party/WebKit/Source/platform/bindings/ConditionalFeatures.cpp
[modify] https://crrev.com/8e7aa98860b23dc0d395b8b8306b7cc382b2c0ba/third_party/WebKit/Source/platform/bindings/ConditionalFeatures.h

Should have marked this fixed a while ago.