New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 695110 link

Starred by 1 user

Issue metadata

Status: Duplicate
Owner:
Closed: Apr 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Chrome
Pri: 2
Type: Bug



Sign in to add a comment

External/InstalledByDefault extension data overwritten by legacy sync data on merge

Project Member Reported by s...@chromium.org, Feb 22 2017

Issue description

It seems we have a concept of external/default extensions that are not supposed to be synced. See https://cs.chromium.org/chromium/src/chrome/common/extensions/sync_helper.cc?l=36 . The following repro steps use how by having the Google Drive app installed, we set Google Docs Offline extension to having been installed by default.

1. Use a clean-ish profile/account that doesn't currently have either of these apps/extensions installed.
2. Sign in and start syncing everything.
3. Install extension https://chrome.google.com/webstore/detail/google-docs-offline/ghbmnnjooekpmoecnnnilnnbdlolhkhi . At this point, sync will record that the extension is installed and various state about it (most interesting if it is enabled or not). You can view this at chrome://sync-internals > Sync Node Browser > Extensions. Toggling the enabled status at chrome://extensions/ will cause sync to send out commits which can be seen on sync-internals.
4. Install app https://chrome.google.com/webstore/detail/google-drive/apdfllckaahabafndbhieahigkjlhalf
5. Restart Chrome. On restart it will set Google Docs Offline to think it is installed by default. This will cause extensions/sync integration to stop writing changes.
6. Toggling enabled status no longer causes commits. Go to chrome://extensions/ and disable Google Docs Offline.
7. Restart chrome and notice that Google Docs Offline is enabled again. This is because MergeDataAndStartSyncing still writes sync data into extensions on startup.
 

Comment 1 by zea@chromium.org, Feb 22 2017

Owner: rdevlin....@chromium.org
Status: Assigned (was: Untriaged)
Devlin, could someone on your team take this on?

Comment 2 by xiy...@chromium.org, Feb 22 2017

Cc: -xiy...@chromium.org
Owner: xiy...@chromium.org
The Docs offline extension should be part of the default apps (or will be in default apps soon for ChromeOS, issue 503262). And the migrator code should eventually go away.

So think we are fixing a more general case with this issue. That is, an app/extension was not part of default extensions/apps and has sync data before, and it becomes part of default extensions/apps later. What are the expected behavior?

IMHO, since we are not syncing default extenions/apps, we should not apply the sync data for them locally as well. 

Comment 3 by zea@chromium.org, Jan 17 2018

Labels: SyncHandoff2018

Comment 4 by treib@chromium.org, Feb 1 2018

I think this is the same as bug 537851. tl;dr syncing of default apps/extensions is completely broken.

Comment 5 by treib@chromium.org, Apr 30 2018

Mergedinto: 537851
Status: Duplicate (was: Assigned)

Sign in to add a comment