ipc_fuzzer_replay build broken on Windows |
||
Issue descriptionhttps://build.chromium.org/p/chromium.fyi/builders/CrWinAsan/builds/4572/steps/compile/logs/stdio FAILED: obj/tools/ipc_fuzzer/message_replay/ipc_fuzzer_replay/replay_process.obj ../../third_party/llvm-build/Release+Asserts/bin/clang-cl.exe /nologo /showIncludes /FC @obj/tools/ipc_fuzzer/message_replay/ipc_fuzzer_replay/replay_process.obj.rsp /c ../../tools/ipc_fuzzer/message_replay/replay_process.cc /Foobj/tools/ipc_fuzzer/message_replay/ipc_fuzzer_replay/replay_process.obj /Fd"obj/tools/ipc_fuzzer/message_replay/ipc_fuzzer_replay_cc.pdb" In file included from ../../tools/ipc_fuzzer/message_replay/replay_process.cc:14: C:\b\c\b\CrWinAsan\src\base\posix\global_descriptors.h(74,9): error: no type named 'ScopedFD' in namespace 'base' base::ScopedFD TakeFD(Key key, base::MemoryMappedFile::Region* region); ~~~~~~^ 1 error generated. Trigger is probably https://codereview.chromium.org/2684433003 which made global_descriptors.h use base::ScopedFD (https://codereview.chromium.org/2684433003/diff/400001/base/posix/global_descriptors.h). However, replay_process.cc probably shouldn't try to include a posix file on windows?
,
Feb 22 2017
,
Feb 22 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1e2e7468de78ac86ec9c62f37fdaa423121d3240 commit 1e2e7468de78ac86ec9c62f37fdaa423121d3240 Author: thakis <thakis@chromium.org> Date: Wed Feb 22 19:07:21 2017 Try to unbreak win/asan build BUG= 695101 Review-Url: https://codereview.chromium.org/2705333004 Cr-Commit-Position: refs/heads/master@{#452153} [modify] https://crrev.com/1e2e7468de78ac86ec9c62f37fdaa423121d3240/tools/ipc_fuzzer/message_replay/replay_process.cc
,
Mar 6 2017
|
||
►
Sign in to add a comment |
||
Comment 1 by thakis@chromium.org
, Feb 22 2017Status: Started (was: Untriaged)