I found this on my dev-channel data dir: Safe Browsing/AnyIpMalware.store I was replaced with IpMalware.store. We should add code to delete it, and leave it in place for a few releases.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9beab1bc3f81c365aa45ea5e23c6f11bfa76676b commit 9beab1bc3f81c365aa45ea5e23c6f11bfa76676b Author: Varun Khaneja <vakh@chromium.org> Date: Mon Jun 05 18:09:10 2017 Fix TODO: Delete unused .store files BUG=695081 Change-Id: I6497f623d4e76bd079d462d576dfa21546cca2d8 Reviewed-on: https://chromium-review.googlesource.com/522861 Commit-Queue: Varun Khaneja <vakh@chromium.org> Reviewed-by: Nathan Parker <nparker@chromium.org> Reviewed-by: Jialiu Lin <jialiul@chromium.org> Reviewed-by: Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#477029} [modify] https://crrev.com/9beab1bc3f81c365aa45ea5e23c6f11bfa76676b/components/safe_browsing_db/v4_database_unittest.cc [modify] https://crrev.com/9beab1bc3f81c365aa45ea5e23c6f11bfa76676b/components/safe_browsing_db/v4_local_database_manager.cc [modify] https://crrev.com/9beab1bc3f81c365aa45ea5e23c6f11bfa76676b/components/safe_browsing_db/v4_local_database_manager.h [modify] https://crrev.com/9beab1bc3f81c365aa45ea5e23c6f11bfa76676b/components/safe_browsing_db/v4_local_database_manager_unittest.cc [modify] https://crrev.com/9beab1bc3f81c365aa45ea5e23c6f11bfa76676b/components/safe_browsing_db/v4_protocol_manager_util.cc [modify] https://crrev.com/9beab1bc3f81c365aa45ea5e23c6f11bfa76676b/components/safe_browsing_db/v4_protocol_manager_util.h [modify] https://crrev.com/9beab1bc3f81c365aa45ea5e23c6f11bfa76676b/components/safe_browsing_db/v4_store.cc [modify] https://crrev.com/9beab1bc3f81c365aa45ea5e23c6f11bfa76676b/tools/metrics/histograms/enums.xml [modify] https://crrev.com/9beab1bc3f81c365aa45ea5e23c6f11bfa76676b/tools/metrics/histograms/histograms.xml
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9420d64ca4599655445ed4e7f85a4c7826555de6 commit 9420d64ca4599655445ed4e7f85a4c7826555de6 Author: Dirk Pranke <dpranke@chromium.org> Date: Mon Jun 05 21:28:07 2017 Revert "Fix TODO: Delete unused .store files" This reverts commit 9beab1bc3f81c365aa45ea5e23c6f11bfa76676b. Reason for revert: This seems to be causing a failure on "Android Tests": https://luci-milo.appspot.com/buildbot/chromium.linux/Android%20Tests/42448 https://chromium-swarm.appspot.com/task?id=3692a1ebc5d04e10&refresh=10&show_raw=1 Original change's description: > Fix TODO: Delete unused .store files > > BUG=695081 > > Change-Id: I6497f623d4e76bd079d462d576dfa21546cca2d8 > Reviewed-on: https://chromium-review.googlesource.com/522861 > Commit-Queue: Varun Khaneja <vakh@chromium.org> > Reviewed-by: Nathan Parker <nparker@chromium.org> > Reviewed-by: Jialiu Lin <jialiul@chromium.org> > Reviewed-by: Alexei Svitkine <asvitkine@chromium.org> > Cr-Commit-Position: refs/heads/master@{#477029} TBR=asvitkine@chromium.org,nparker@chromium.org,vakh@chromium.org,jialiul@chromium.org NOPRESUBMIT=true NOTRY=true NOTREECHECKS=true BUG=695081 Change-Id: Ic923ad2bdeddb1953e877cd65df462cb2b603493 Reviewed-on: https://chromium-review.googlesource.com/524293 Commit-Queue: Dirk Pranke <dpranke@chromium.org> Reviewed-by: Dirk Pranke <dpranke@chromium.org> Cr-Commit-Position: refs/heads/master@{#477088} [modify] https://crrev.com/9420d64ca4599655445ed4e7f85a4c7826555de6/components/safe_browsing_db/v4_database_unittest.cc [modify] https://crrev.com/9420d64ca4599655445ed4e7f85a4c7826555de6/components/safe_browsing_db/v4_local_database_manager.cc [modify] https://crrev.com/9420d64ca4599655445ed4e7f85a4c7826555de6/components/safe_browsing_db/v4_local_database_manager.h [modify] https://crrev.com/9420d64ca4599655445ed4e7f85a4c7826555de6/components/safe_browsing_db/v4_local_database_manager_unittest.cc [modify] https://crrev.com/9420d64ca4599655445ed4e7f85a4c7826555de6/components/safe_browsing_db/v4_protocol_manager_util.cc [modify] https://crrev.com/9420d64ca4599655445ed4e7f85a4c7826555de6/components/safe_browsing_db/v4_protocol_manager_util.h [modify] https://crrev.com/9420d64ca4599655445ed4e7f85a4c7826555de6/components/safe_browsing_db/v4_store.cc [modify] https://crrev.com/9420d64ca4599655445ed4e7f85a4c7826555de6/tools/metrics/histograms/enums.xml [modify] https://crrev.com/9420d64ca4599655445ed4e7f85a4c7826555de6/tools/metrics/histograms/histograms.xml
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/26c9a8b98ef9870bbf65d665193f2a52c5809aec commit 26c9a8b98ef9870bbf65d665193f2a52c5809aec Author: Varun Khaneja <vakh@chromium.org> Date: Tue Jun 13 20:14:20 2017 Reland: Fix TODO: Delete unused .store files Original CL: https://chromium-review.googlesource.com/522861 Revert CL: https://chromium-review.googlesource.com/524293 Reason for revert was that the changes were causing test failures on Android in the V4LocalDatabaseManagerTest class but that file should not have been compiled on Android in the first place. I've since fixed that via CLs: https://chromium-review.googlesource.com/524988 https://chromium-review.googlesource.com/531786 Original change's description: > Revert "Fix TODO: Delete unused .store files" > > This reverts commit 9beab1bc3f81c365aa45ea5e23c6f11bfa76676b. > > Reason for revert: This seems to be causing a failure on "Android Tests": > > https://luci-milo.appspot.com/buildbot/chromium.linux/Android%20Tests/42448 > https://chromium-swarm.appspot.com/task?id=3692a1ebc5d04e10&refresh=10&show_raw=1 > > Original change's description: > > Fix TODO: Delete unused .store files > > > > BUG=695081 > > > > Change-Id: I6497f623d4e76bd079d462d576dfa21546cca2d8 > > Reviewed-on: https://chromium-review.googlesource.com/522861 > > Commit-Queue: Varun Khaneja <vakh@chromium.org> > > Reviewed-by: Nathan Parker <nparker@chromium.org> > > Reviewed-by: Jialiu Lin <jialiul@chromium.org> > > Reviewed-by: Alexei Svitkine <asvitkine@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#477029} > > TBR=asvitkine@chromium.org,nparker@chromium.org,vakh@chromium.org,jialiul@chromium.org > NOPRESUBMIT=true > NOTRY=true > NOTREECHECKS=true > BUG=695081 > > Change-Id: Ic923ad2bdeddb1953e877cd65df462cb2b603493 > Reviewed-on: https://chromium-review.googlesource.com/524293 > Commit-Queue: Dirk Pranke <dpranke@chromium.org> > Reviewed-by: Dirk Pranke <dpranke@chromium.org> > Cr-Commit-Position: refs/heads/master@{#477088} TBR=dpranke@chromium.org,asvitkine@chromium.org,timvolodine@chromium.org,nparker@chromium.org,vakh@chromium.org,jialiul@chromium.org,chromium-reviews@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 695081 Change-Id: Idf3e4ee7c0e79cb325e76963741f9b3807c92147 Reviewed-on: https://chromium-review.googlesource.com/533434 Reviewed-by: Varun Khaneja <vakh@chromium.org> Reviewed-by: Dirk Pranke <dpranke@chromium.org> Commit-Queue: Varun Khaneja <vakh@chromium.org> Cr-Commit-Position: refs/heads/master@{#479118} [modify] https://crrev.com/26c9a8b98ef9870bbf65d665193f2a52c5809aec/components/safe_browsing_db/v4_database_unittest.cc [modify] https://crrev.com/26c9a8b98ef9870bbf65d665193f2a52c5809aec/components/safe_browsing_db/v4_local_database_manager.cc [modify] https://crrev.com/26c9a8b98ef9870bbf65d665193f2a52c5809aec/components/safe_browsing_db/v4_local_database_manager.h [modify] https://crrev.com/26c9a8b98ef9870bbf65d665193f2a52c5809aec/components/safe_browsing_db/v4_local_database_manager_unittest.cc [modify] https://crrev.com/26c9a8b98ef9870bbf65d665193f2a52c5809aec/components/safe_browsing_db/v4_protocol_manager_util.cc [modify] https://crrev.com/26c9a8b98ef9870bbf65d665193f2a52c5809aec/components/safe_browsing_db/v4_protocol_manager_util.h [modify] https://crrev.com/26c9a8b98ef9870bbf65d665193f2a52c5809aec/components/safe_browsing_db/v4_store.cc [modify] https://crrev.com/26c9a8b98ef9870bbf65d665193f2a52c5809aec/tools/metrics/histograms/enums.xml [modify] https://crrev.com/26c9a8b98ef9870bbf65d665193f2a52c5809aec/tools/metrics/histograms/histograms.xml
Comment 1 by vakh@chromium.org
, Feb 24 2017