Some tests in content_browsertests are flaky because they work with window focus |
||
Issue descriptionSome tests in content_browsertests may fail when run in parallel because they deal with window focus and expect to have it under control. At least on windows, they steal the focus from each other. This issue was discussed in https://groups.google.com/a/chromium.org/forum/#!searchin/chromium-dev/content_browsertests/chromium-dev/tswx8HQtsLE/Dz5zltHZDgAJ I tried to get the list of these tests, here it is: DumpAccessibilityEventsTest.AccessibilityEventsListboxFocus DumpAccessibilityEventsTest.AccessibilityEventsMenuListFocus NavigationControllerBrowserTest.EnsureFrameNavigationEntriesClearedOnMismatch RenderFrameHostImplBrowserTest.RemoveFocusedFrame SitePerProcessBrowserTest.CrossProcessFocusChangeFiresBlurEvents SitePerProcessBrowserTest.SubframeWindowFocus This list may be not complete. I just used release build and ran tests that have "Focus" in their name with a lot of repeats, in a lot of concurrent jobs, and with tests in random order.
,
Mar 15 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/901d5088e10ab1149e7e51b94e70949fe20fe67d commit 901d5088e10ab1149e7e51b94e70949fe20fe67d Author: Alexander Semashko <ahest@yandex-team.ru> Date: Thu Mar 15 09:02:56 2018 Ignore window [de]activation in content_browsertests. These events can happen when another test starts or finishes and cause frame/widget focus state changes, breaking some tests. Bug: 695054 Change-Id: I9ab6b3887c00421d4c6f96dd508e912b23706176 Reviewed-on: https://chromium-review.googlesource.com/926368 Reviewed-by: John Abd-El-Malek <jam@chromium.org> Commit-Queue: Alexander Semashko <ahest@yandex-team.ru> Cr-Commit-Position: refs/heads/master@{#543328} [modify] https://crrev.com/901d5088e10ab1149e7e51b94e70949fe20fe67d/content/public/test/DEPS [modify] https://crrev.com/901d5088e10ab1149e7e51b94e70949fe20fe67d/content/public/test/content_browser_test.cc [modify] https://crrev.com/901d5088e10ab1149e7e51b94e70949fe20fe67d/content/test/BUILD.gn [modify] https://crrev.com/901d5088e10ab1149e7e51b94e70949fe20fe67d/ui/views/widget/desktop_aura/desktop_native_widget_aura.cc [modify] https://crrev.com/901d5088e10ab1149e7e51b94e70949fe20fe67d/ui/views/widget/desktop_aura/desktop_native_widget_aura.h
,
Mar 15 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b6160c861fccd1c9623bcbfdf6b444519df79e00 commit b6160c861fccd1c9623bcbfdf6b444519df79e00 Author: Scott Violet <sky@chromium.org> Date: Thu Mar 15 15:49:21 2018 Revert "Ignore window [de]activation in content_browsertests." This reverts commit 901d5088e10ab1149e7e51b94e70949fe20fe67d. Reason for revert: Didn't address concerns of where this API should live. In particular DNWA isn't the right place, it should be on Widget. Original change's description: > Ignore window [de]activation in content_browsertests. > > These events can happen when another test starts or finishes and cause > frame/widget focus state changes, breaking some tests. > > Bug: 695054 > Change-Id: I9ab6b3887c00421d4c6f96dd508e912b23706176 > Reviewed-on: https://chromium-review.googlesource.com/926368 > Reviewed-by: John Abd-El-Malek <jam@chromium.org> > Commit-Queue: Alexander Semashko <ahest@yandex-team.ru> > Cr-Commit-Position: refs/heads/master@{#543328} TBR=sky@chromium.org,dcheng@chromium.org,jam@chromium.org,dpranke@chromium.org,ahest@yandex-team.ru Change-Id: Ia3b8b9eabb4463ddcd22e81cec1f5ee7fffa639e No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 695054 Reviewed-on: https://chromium-review.googlesource.com/963658 Reviewed-by: Scott Violet <sky@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#543378} [modify] https://crrev.com/b6160c861fccd1c9623bcbfdf6b444519df79e00/content/public/test/DEPS [modify] https://crrev.com/b6160c861fccd1c9623bcbfdf6b444519df79e00/content/public/test/content_browser_test.cc [modify] https://crrev.com/b6160c861fccd1c9623bcbfdf6b444519df79e00/content/test/BUILD.gn [modify] https://crrev.com/b6160c861fccd1c9623bcbfdf6b444519df79e00/ui/views/widget/desktop_aura/desktop_native_widget_aura.cc [modify] https://crrev.com/b6160c861fccd1c9623bcbfdf6b444519df79e00/ui/views/widget/desktop_aura/desktop_native_widget_aura.h
,
Mar 28 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/26d48d2a32903e4b5c87d27997343588858bc0a0 commit 26d48d2a32903e4b5c87d27997343588858bc0a0 Author: Alexander Semashko <ahest@yandex-team.ru> Date: Wed Mar 28 09:41:05 2018 Ignore window [de]activation in content_browsertests. These events can happen when another test starts or finishes and cause frame/widget focus state changes, breaking some tests. Bug: 695054 Change-Id: I7fc856cebc32cd9f8df2b11c6df6e3b2c4a54114 Reviewed-on: https://chromium-review.googlesource.com/964843 Commit-Queue: Alexander Semashko <ahest@yandex-team.ru> Reviewed-by: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#546445} [modify] https://crrev.com/26d48d2a32903e4b5c87d27997343588858bc0a0/ash/system/status_area_widget.cc [modify] https://crrev.com/26d48d2a32903e4b5c87d27997343588858bc0a0/ash/system/status_area_widget.h [modify] https://crrev.com/26d48d2a32903e4b5c87d27997343588858bc0a0/content/public/test/DEPS [modify] https://crrev.com/26d48d2a32903e4b5c87d27997343588858bc0a0/content/public/test/content_browser_test.cc [modify] https://crrev.com/26d48d2a32903e4b5c87d27997343588858bc0a0/content/test/BUILD.gn [modify] https://crrev.com/26d48d2a32903e4b5c87d27997343588858bc0a0/ui/views/BUILD.gn [modify] https://crrev.com/26d48d2a32903e4b5c87d27997343588858bc0a0/ui/views/cocoa/bridged_native_widget.mm [add] https://crrev.com/26d48d2a32903e4b5c87d27997343588858bc0a0/ui/views/test/widget_test_api.cc [add] https://crrev.com/26d48d2a32903e4b5c87d27997343588858bc0a0/ui/views/test/widget_test_api.h [modify] https://crrev.com/26d48d2a32903e4b5c87d27997343588858bc0a0/ui/views/widget/desktop_aura/desktop_native_widget_aura.cc [modify] https://crrev.com/26d48d2a32903e4b5c87d27997343588858bc0a0/ui/views/widget/native_widget_delegate.h [modify] https://crrev.com/26d48d2a32903e4b5c87d27997343588858bc0a0/ui/views/widget/widget.cc [modify] https://crrev.com/26d48d2a32903e4b5c87d27997343588858bc0a0/ui/views/widget/widget.h [modify] https://crrev.com/26d48d2a32903e4b5c87d27997343588858bc0a0/ui/views/widget/widget_interactive_uitest.cc
,
Apr 17 2018
|
||
►
Sign in to add a comment |
||
Comment 1 by ah...@yandex-team.ru
, Feb 22 2017