Tentatively assigning to yhirano. yhirano: feel free to unassign or reassign it.

dmurph@, can you take a look?

huh. Got it. So we should be grabbing the blob right away.

Note that while currently XHR is the only place where it is observable that we don't resolve Blob URLs until we actually start fetching, with mojo blobs and/or mojo network service this becomes potentially observable for any fetch/navigation/download. Currently our revokeObjectURL IPCs are sequenced with the actual fetch/navigation/download IPCs (at least as far as I can tell), so the blob URL is still around by the time the browser process tries to resolve it, but when either half of that equation moves to mojo this will no longer be the case. So it's not just our XHR code we'd need to update to resolve the blob URLs at URL parsing time, navigations, downloads and other fetches all will need to be updated as well.

(even today the same problem already exists with Request + fetch, where creating a Request, then revoking the URL, and then starting the fetch should work according to the spec)

(to be fair, maybe fixing this for XHR/fetch and fixing this for mojofication should be separate bugs, but I expect large overlap between the work required for both...)

Apologies, applied the wrong component in bulk.

Setting Internals>Services>Storage to all children of issue 611935

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/20c2e2937980e39373edc4446369c7410aa38585

commit 20c2e2937980e39373edc4446369c7410aa38585
Author: Marijn Kruisselbrink <mek@chromium.org>
Date: Fri Feb 09 22:07:57 2018

[Mojo Blob URLs] Refactor Blob URL loading for subresources.

This changes the XHR and fetch codepaths to resolve blob URLs earlier
(i.e when the request is created rather than when the fetch is made), in
order to fix bugs where the blob URL is revoked after creating a request
but before fetching.

This also addresses race conditions between revoking blob URLs and
fetching them by resolving a blob URL as soon as possible for subresource
requests.

Not addressed yet are navigation and download requests, that will be
done in follow ups.

Bug: 800901, 800898,  695031 , 807435
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: Ifd5eb11abaf04c091c51e607fdaeafa0c89bc1a9
Reviewed-on: https://chromium-review.googlesource.com/893606
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Commit-Queue: Marijn Kruisselbrink <mek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#535845}
[modify] https://crrev.com/20c2e2937980e39373edc4446369c7410aa38585/content/renderer/renderer_blink_platform_impl.cc
[modify] https://crrev.com/20c2e2937980e39373edc4446369c7410aa38585/content/renderer/renderer_blink_platform_impl.h
[modify] https://crrev.com/20c2e2937980e39373edc4446369c7410aa38585/content/renderer/service_worker/service_worker_fetch_context_impl.cc
[modify] https://crrev.com/20c2e2937980e39373edc4446369c7410aa38585/content/renderer/service_worker/service_worker_fetch_context_impl.h
[modify] https://crrev.com/20c2e2937980e39373edc4446369c7410aa38585/content/renderer/service_worker/worker_fetch_context_impl.cc
[modify] https://crrev.com/20c2e2937980e39373edc4446369c7410aa38585/content/renderer/service_worker/worker_fetch_context_impl.h
[modify] https://crrev.com/20c2e2937980e39373edc4446369c7410aa38585/third_party/WebKit/LayoutTests/FlagExpectations/site-per-process
[modify] https://crrev.com/20c2e2937980e39373edc4446369c7410aa38585/third_party/WebKit/LayoutTests/NeverFixTests
[modify] https://crrev.com/20c2e2937980e39373edc4446369c7410aa38585/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/20c2e2937980e39373edc4446369c7410aa38585/third_party/WebKit/LayoutTests/VirtualTestSuites
[add] https://crrev.com/20c2e2937980e39373edc4446369c7410aa38585/third_party/WebKit/LayoutTests/virtual/mojo-blob-urls/external/wpt/FileAPI/url/README.txt
[add] https://crrev.com/20c2e2937980e39373edc4446369c7410aa38585/third_party/WebKit/LayoutTests/virtual/mojo-blob-urls/external/wpt/FileAPI/url/cross-global-revoke.sub-expected.txt
[add] https://crrev.com/20c2e2937980e39373edc4446369c7410aa38585/third_party/WebKit/LayoutTests/virtual/mojo-blob-urls/external/wpt/FileAPI/url/url-with-fetch.any-expected.txt
[add] https://crrev.com/20c2e2937980e39373edc4446369c7410aa38585/third_party/WebKit/LayoutTests/virtual/mojo-blob-urls/external/wpt/FileAPI/url/url-with-xhr.any-expected.txt
[modify] https://crrev.com/20c2e2937980e39373edc4446369c7410aa38585/third_party/WebKit/Source/core/fetch/FetchManager.cpp
[modify] https://crrev.com/20c2e2937980e39373edc4446369c7410aa38585/third_party/WebKit/Source/core/fetch/FetchRequestData.cpp
[modify] https://crrev.com/20c2e2937980e39373edc4446369c7410aa38585/third_party/WebKit/Source/core/fetch/FetchRequestData.h
[modify] https://crrev.com/20c2e2937980e39373edc4446369c7410aa38585/third_party/WebKit/Source/core/fetch/Request.cpp
[modify] https://crrev.com/20c2e2937980e39373edc4446369c7410aa38585/third_party/WebKit/Source/core/fileapi/PublicURLManager.cpp
[modify] https://crrev.com/20c2e2937980e39373edc4446369c7410aa38585/third_party/WebKit/Source/core/fileapi/PublicURLManager.h
[modify] https://crrev.com/20c2e2937980e39373edc4446369c7410aa38585/third_party/WebKit/Source/core/loader/FrameFetchContext.cpp
[modify] https://crrev.com/20c2e2937980e39373edc4446369c7410aa38585/third_party/WebKit/Source/core/loader/FrameFetchContext.h
[modify] https://crrev.com/20c2e2937980e39373edc4446369c7410aa38585/third_party/WebKit/Source/core/loader/ThreadableLoaderTest.cpp
[modify] https://crrev.com/20c2e2937980e39373edc4446369c7410aa38585/third_party/WebKit/Source/core/loader/WorkerFetchContext.cpp
[modify] https://crrev.com/20c2e2937980e39373edc4446369c7410aa38585/third_party/WebKit/Source/core/loader/WorkerFetchContext.h
[modify] https://crrev.com/20c2e2937980e39373edc4446369c7410aa38585/third_party/WebKit/Source/core/xmlhttprequest/XMLHttpRequest.cpp
[modify] https://crrev.com/20c2e2937980e39373edc4446369c7410aa38585/third_party/WebKit/Source/core/xmlhttprequest/XMLHttpRequest.h
[modify] https://crrev.com/20c2e2937980e39373edc4446369c7410aa38585/third_party/WebKit/Source/platform/blob/BUILD.gn
[modify] https://crrev.com/20c2e2937980e39373edc4446369c7410aa38585/third_party/WebKit/Source/platform/loader/BUILD.gn
[modify] https://crrev.com/20c2e2937980e39373edc4446369c7410aa38585/third_party/WebKit/Source/platform/loader/fetch/FetchContext.h
[modify] https://crrev.com/20c2e2937980e39373edc4446369c7410aa38585/third_party/WebKit/Source/platform/loader/fetch/ResourceLoader.cpp
[modify] https://crrev.com/20c2e2937980e39373edc4446369c7410aa38585/third_party/WebKit/Source/platform/loader/fetch/ResourceLoaderOptions.h
[modify] https://crrev.com/20c2e2937980e39373edc4446369c7410aa38585/third_party/WebKit/Source/platform/loader/testing/MockFetchContext.h
[modify] https://crrev.com/20c2e2937980e39373edc4446369c7410aa38585/third_party/WebKit/Tools/Scripts/audit-non-blink-usage.py
[modify] https://crrev.com/20c2e2937980e39373edc4446369c7410aa38585/third_party/WebKit/public/platform/Platform.h
[modify] https://crrev.com/20c2e2937980e39373edc4446369c7410aa38585/third_party/WebKit/public/platform/WebWorkerFetchContext.h

This is fixed with NetworkService enabled. Probably not going to bother fixing this for the non-networkservice case, but I might change my mind...