New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 695013 link

Starred by 1 user
Status: Assigned
Owner:
marq@chromium.org
Cc:
marq@chromium.org
█ lpromero@chromium.org
rohitrao@chromium.org
ios-bugs@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 3
Type: Bug



Sign in to add a comment

Add presubmit to check for -removeChildViewController:

Project Member Reported by justincohen@chromium.org, Feb 22 2017
Project Member

Comment 1 by bugdroid1@chromium.org, Feb 22 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8c112333b3a0eff529b84d80437c3d27c519142f

commit 8c112333b3a0eff529b84d80437c3d27c519142f
Author: justincohen <justincohen@chromium.org>
Date: Wed Feb 22 13:13:50 2017

[ios clean] Rename removeChildViewController -> detachChildViewController

-removeChildViewController is used internally by UIKit.  Without this change,
calling removeChildViewController's leads to an infinite loop.

BUG=695013

Review-Url: https://codereview.chromium.org/2709013002
Cr-Commit-Position: refs/heads/master@{#452024}

[modify] https://crrev.com/8c112333b3a0eff529b84d80437c3d27c519142f/ios/clean/chrome/browser/ui/tab/tab_container_view_controller.mm
[modify] https://crrev.com/8c112333b3a0eff529b84d80437c3d27c519142f/ios/clean/chrome/browser/ui/tab_strip/tab_strip_container_view_controller.mm

Comment 2 by sczs@chromium.org, Feb 22 2017

Owner: marq@chromium.org
Status: Assigned (was: Untriaged)

Comment 3 by cma...@chromium.org, Mar 10 2017

Components: UI>Browser

Comment 4 by eugene...@chromium.org, Apr 20 2017

Components: -UI>Browser Infra

Comment 5 by vadimsh@chromium.org, Apr 24 2017

Components: -Infra Infra>Client>iOS

Comment 6 by sergeybe...@chromium.org, Dec 22 2017

Components: Infra>Client>Chrome

Comment 7 by sergeybe...@chromium.org, Dec 22 2017

Components: -Infra>Client>iOS
Moved all Infra>Client>iOS bugs to Infra>Client>Chrome + OS-iOS.
►

Sign in to add a comment