New issue
Advanced search Search tips

Issue 695012 link

Starred by 2 users
Status: Fixed
Owner:
juncai@chromium.org
Closed: Apr 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocking:
issue 694998



Sign in to add a comment

Move Gamepad Blink headers to be part of the Gamepad client library

Project Member Reported by blundell@chromium.org, Feb 22 2017 
Currently the Gamepad implementation and Blink client share common Blink headers:

third_party/WebKit/public/platform/WebGamepad.h
third_party/WebKit/public/platform/WebGamepads.h

However, the Device Service implementation should not depend on Blink. Thus, to complete the servicification of Gamepad, the structs and types in these headers should be moved to be defined in mojom rather than being C++ headers in Blink.

Comment 1 by dtapu...@chromium.org, Mar 2 2017

Components: Blink>GamepadAPI

Comment 2 by blundell@chromium.org, Apr 4 2017

Summary: Move Gamepad Blink headers to be part of the Gamepad client library (was: Convert the Gamepad Blink headers to be defined in mojom)
Update: We're taking a different (and easier) approach to this problem. We'll follow the approach of https://codereview.chromium.org/2415083002 and move these headers into the Gamepad client library, putting them in a special target to indicate that they're shared with Blink (see that CL for an example to follow).

Comment 3 by juncai@chromium.org, Apr 11 2017

Owner: juncai@chromium.org
Status: Started (was: Available)
Project Member

Comment 4 by bugdroid1@chromium.org, Apr 18 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2f298a80296e8510f74632faa55e825cfe41ec4f

commit 2f298a80296e8510f74632faa55e825cfe41ec4f
Author: juncai <juncai@chromium.org>
Date: Tue Apr 18 03:51:39 2017

[Device Service] Move Gamepad Blink headers to be part of the Gamepad client library

This CL follows the approach of
https://codereview.chromium.org/2415083002
and moves
//third_party/WebKit/public/platform/WebGamepad.h
//third_party/WebKit/public/platform/WebGamepads.h
to
//device/gamepad/public/cpp/
and puts them in a special target to indicate that they're shared with
Blink

BUG= 695012 

Review-Url: https://codereview.chromium.org/2808093006
Cr-Commit-Position: refs/heads/master@{#465129}

[modify] https://crrev.com/2f298a80296e8510f74632faa55e825cfe41ec4f/components/exo/BUILD.gn
[modify] https://crrev.com/2f298a80296e8510f74632faa55e825cfe41ec4f/components/exo/gaming_seat.cc
[modify] https://crrev.com/2f298a80296e8510f74632faa55e825cfe41ec4f/components/exo/gaming_seat.h
[modify] https://crrev.com/2f298a80296e8510f74632faa55e825cfe41ec4f/components/exo/gaming_seat_unittest.cc
[modify] https://crrev.com/2f298a80296e8510f74632faa55e825cfe41ec4f/content/browser/DEPS
[modify] https://crrev.com/2f298a80296e8510f74632faa55e825cfe41ec4f/content/browser/renderer_host/pepper/pepper_gamepad_host.h
[modify] https://crrev.com/2f298a80296e8510f74632faa55e825cfe41ec4f/content/browser/renderer_host/pepper/pepper_gamepad_host_unittest.cc
[modify] https://crrev.com/2f298a80296e8510f74632faa55e825cfe41ec4f/content/common/DEPS
[modify] https://crrev.com/2f298a80296e8510f74632faa55e825cfe41ec4f/content/public/renderer/renderer_gamepad_provider.h
[modify] https://crrev.com/2f298a80296e8510f74632faa55e825cfe41ec4f/content/renderer/BUILD.gn
[modify] https://crrev.com/2f298a80296e8510f74632faa55e825cfe41ec4f/content/renderer/DEPS
[modify] https://crrev.com/2f298a80296e8510f74632faa55e825cfe41ec4f/content/renderer/gamepad_shared_memory_reader.cc
[modify] https://crrev.com/2f298a80296e8510f74632faa55e825cfe41ec4f/content/renderer/gamepad_shared_memory_reader.h
[modify] https://crrev.com/2f298a80296e8510f74632faa55e825cfe41ec4f/content/renderer/pepper/event_conversion.cc
[modify] https://crrev.com/2f298a80296e8510f74632faa55e825cfe41ec4f/content/renderer/pepper/pepper_plugin_instance_impl.cc
[modify] https://crrev.com/2f298a80296e8510f74632faa55e825cfe41ec4f/content/renderer/render_thread_impl.cc
[modify] https://crrev.com/2f298a80296e8510f74632faa55e825cfe41ec4f/content/renderer/render_thread_impl.h
[modify] https://crrev.com/2f298a80296e8510f74632faa55e825cfe41ec4f/content/renderer/renderer_blink_platform_impl.cc
[modify] https://crrev.com/2f298a80296e8510f74632faa55e825cfe41ec4f/content/renderer/renderer_blink_platform_impl.h
[modify] https://crrev.com/2f298a80296e8510f74632faa55e825cfe41ec4f/content/shell/renderer/layout_test/blink_test_runner.cc
[modify] https://crrev.com/2f298a80296e8510f74632faa55e825cfe41ec4f/content/shell/test_runner/BUILD.gn
[modify] https://crrev.com/2f298a80296e8510f74632faa55e825cfe41ec4f/content/shell/test_runner/DEPS
[modify] https://crrev.com/2f298a80296e8510f74632faa55e825cfe41ec4f/content/shell/test_runner/gamepad_controller.cc
[modify] https://crrev.com/2f298a80296e8510f74632faa55e825cfe41ec4f/content/shell/test_runner/gamepad_controller.h
[modify] https://crrev.com/2f298a80296e8510f74632faa55e825cfe41ec4f/content/test/BUILD.gn
[modify] https://crrev.com/2f298a80296e8510f74632faa55e825cfe41ec4f/content/test/DEPS
[modify] https://crrev.com/2f298a80296e8510f74632faa55e825cfe41ec4f/content/test/layouttest_support.cc
[modify] https://crrev.com/2f298a80296e8510f74632faa55e825cfe41ec4f/device/BUILD.gn
[modify] https://crrev.com/2f298a80296e8510f74632faa55e825cfe41ec4f/device/gamepad/BUILD.gn
[modify] https://crrev.com/2f298a80296e8510f74632faa55e825cfe41ec4f/device/gamepad/DEPS
[modify] https://crrev.com/2f298a80296e8510f74632faa55e825cfe41ec4f/device/gamepad/game_controller_data_fetcher_mac.mm
[modify] https://crrev.com/2f298a80296e8510f74632faa55e825cfe41ec4f/device/gamepad/gamepad_consumer.h
[modify] https://crrev.com/2f298a80296e8510f74632faa55e825cfe41ec4f/device/gamepad/gamepad_monitor.cc
[modify] https://crrev.com/2f298a80296e8510f74632faa55e825cfe41ec4f/device/gamepad/gamepad_monitor.h
[modify] https://crrev.com/2f298a80296e8510f74632faa55e825cfe41ec4f/device/gamepad/gamepad_pad_state_provider.cc
[modify] https://crrev.com/2f298a80296e8510f74632faa55e825cfe41ec4f/device/gamepad/gamepad_pad_state_provider.h
[modify] https://crrev.com/2f298a80296e8510f74632faa55e825cfe41ec4f/device/gamepad/gamepad_platform_data_fetcher_android.cc
[modify] https://crrev.com/2f298a80296e8510f74632faa55e825cfe41ec4f/device/gamepad/gamepad_platform_data_fetcher_android.h
[modify] https://crrev.com/2f298a80296e8510f74632faa55e825cfe41ec4f/device/gamepad/gamepad_platform_data_fetcher_linux.cc
[modify] https://crrev.com/2f298a80296e8510f74632faa55e825cfe41ec4f/device/gamepad/gamepad_platform_data_fetcher_linux.h
[modify] https://crrev.com/2f298a80296e8510f74632faa55e825cfe41ec4f/device/gamepad/gamepad_platform_data_fetcher_mac.h
[modify] https://crrev.com/2f298a80296e8510f74632faa55e825cfe41ec4f/device/gamepad/gamepad_platform_data_fetcher_mac.mm
[modify] https://crrev.com/2f298a80296e8510f74632faa55e825cfe41ec4f/device/gamepad/gamepad_platform_data_fetcher_win.cc
[modify] https://crrev.com/2f298a80296e8510f74632faa55e825cfe41ec4f/device/gamepad/gamepad_platform_data_fetcher_win.h
[modify] https://crrev.com/2f298a80296e8510f74632faa55e825cfe41ec4f/device/gamepad/gamepad_provider.cc
[modify] https://crrev.com/2f298a80296e8510f74632faa55e825cfe41ec4f/device/gamepad/gamepad_provider.h
[modify] https://crrev.com/2f298a80296e8510f74632faa55e825cfe41ec4f/device/gamepad/gamepad_provider_unittest.cc
[modify] https://crrev.com/2f298a80296e8510f74632faa55e825cfe41ec4f/device/gamepad/gamepad_service.cc
[modify] https://crrev.com/2f298a80296e8510f74632faa55e825cfe41ec4f/device/gamepad/gamepad_service.h
[modify] https://crrev.com/2f298a80296e8510f74632faa55e825cfe41ec4f/device/gamepad/gamepad_service_unittest.cc
[modify] https://crrev.com/2f298a80296e8510f74632faa55e825cfe41ec4f/device/gamepad/gamepad_shared_buffer.cc
[modify] https://crrev.com/2f298a80296e8510f74632faa55e825cfe41ec4f/device/gamepad/gamepad_shared_buffer.h
[modify] https://crrev.com/2f298a80296e8510f74632faa55e825cfe41ec4f/device/gamepad/gamepad_standard_mappings.cc
[modify] https://crrev.com/2f298a80296e8510f74632faa55e825cfe41ec4f/device/gamepad/gamepad_standard_mappings.h
[modify] https://crrev.com/2f298a80296e8510f74632faa55e825cfe41ec4f/device/gamepad/gamepad_standard_mappings_linux.cc
[modify] https://crrev.com/2f298a80296e8510f74632faa55e825cfe41ec4f/device/gamepad/gamepad_standard_mappings_mac.mm
[modify] https://crrev.com/2f298a80296e8510f74632faa55e825cfe41ec4f/device/gamepad/gamepad_standard_mappings_win.cc
[modify] https://crrev.com/2f298a80296e8510f74632faa55e825cfe41ec4f/device/gamepad/gamepad_test_helpers.cc
[modify] https://crrev.com/2f298a80296e8510f74632faa55e825cfe41ec4f/device/gamepad/gamepad_test_helpers.h
[modify] https://crrev.com/2f298a80296e8510f74632faa55e825cfe41ec4f/device/gamepad/gamepad_user_gesture.cc
[modify] https://crrev.com/2f298a80296e8510f74632faa55e825cfe41ec4f/device/gamepad/gamepad_user_gesture.h
[add] https://crrev.com/2f298a80296e8510f74632faa55e825cfe41ec4f/device/gamepad/public/cpp/BUILD.gn
[add] https://crrev.com/2f298a80296e8510f74632faa55e825cfe41ec4f/device/gamepad/public/cpp/gamepad.cc
[add] https://crrev.com/2f298a80296e8510f74632faa55e825cfe41ec4f/device/gamepad/public/cpp/gamepad.h
[add] https://crrev.com/2f298a80296e8510f74632faa55e825cfe41ec4f/device/gamepad/public/cpp/gamepads.h
[modify] https://crrev.com/2f298a80296e8510f74632faa55e825cfe41ec4f/device/gamepad/public/interfaces/OWNERS
[modify] https://crrev.com/2f298a80296e8510f74632faa55e825cfe41ec4f/device/gamepad/public/interfaces/gamepad.typemap
[modify] https://crrev.com/2f298a80296e8510f74632faa55e825cfe41ec4f/device/gamepad/public/interfaces/gamepad_struct_traits.cc
[modify] https://crrev.com/2f298a80296e8510f74632faa55e825cfe41ec4f/device/gamepad/public/interfaces/gamepad_struct_traits.h
[modify] https://crrev.com/2f298a80296e8510f74632faa55e825cfe41ec4f/device/gamepad/public/interfaces/gamepad_struct_traits_unittest.cc
[modify] https://crrev.com/2f298a80296e8510f74632faa55e825cfe41ec4f/device/gamepad/raw_input_data_fetcher_win.cc
[modify] https://crrev.com/2f298a80296e8510f74632faa55e825cfe41ec4f/device/gamepad/raw_input_data_fetcher_win.h
[modify] https://crrev.com/2f298a80296e8510f74632faa55e825cfe41ec4f/device/gamepad/xbox_data_fetcher_mac.mm
[modify] https://crrev.com/2f298a80296e8510f74632faa55e825cfe41ec4f/device/vr/BUILD.gn
[modify] https://crrev.com/2f298a80296e8510f74632faa55e825cfe41ec4f/device/vr/DEPS
[modify] https://crrev.com/2f298a80296e8510f74632faa55e825cfe41ec4f/device/vr/android/gvr/gvr_gamepad_data_fetcher.cc
[modify] https://crrev.com/2f298a80296e8510f74632faa55e825cfe41ec4f/ppapi/shared_impl/DEPS
[modify] https://crrev.com/2f298a80296e8510f74632faa55e825cfe41ec4f/ppapi/shared_impl/ppb_gamepad_shared.cc
[modify] https://crrev.com/2f298a80296e8510f74632faa55e825cfe41ec4f/ppapi/shared_impl/ppb_gamepad_shared.h
[modify] https://crrev.com/2f298a80296e8510f74632faa55e825cfe41ec4f/third_party/WebKit/Source/modules/gamepad/BUILD.gn
[modify] https://crrev.com/2f298a80296e8510f74632faa55e825cfe41ec4f/third_party/WebKit/Source/modules/gamepad/DEPS
[modify] https://crrev.com/2f298a80296e8510f74632faa55e825cfe41ec4f/third_party/WebKit/Source/modules/gamepad/Gamepad.cpp
[modify] https://crrev.com/2f298a80296e8510f74632faa55e825cfe41ec4f/third_party/WebKit/Source/modules/gamepad/Gamepad.h
[modify] https://crrev.com/2f298a80296e8510f74632faa55e825cfe41ec4f/third_party/WebKit/Source/modules/gamepad/GamepadDispatcher.cpp
[modify] https://crrev.com/2f298a80296e8510f74632faa55e825cfe41ec4f/third_party/WebKit/Source/modules/gamepad/GamepadDispatcher.h
[modify] https://crrev.com/2f298a80296e8510f74632faa55e825cfe41ec4f/third_party/WebKit/Source/modules/gamepad/GamepadList.cpp
[modify] https://crrev.com/2f298a80296e8510f74632faa55e825cfe41ec4f/third_party/WebKit/Source/modules/gamepad/GamepadList.h
[modify] https://crrev.com/2f298a80296e8510f74632faa55e825cfe41ec4f/third_party/WebKit/Source/modules/gamepad/GamepadPose.cpp
[modify] https://crrev.com/2f298a80296e8510f74632faa55e825cfe41ec4f/third_party/WebKit/Source/modules/gamepad/GamepadPose.h
[modify] https://crrev.com/2f298a80296e8510f74632faa55e825cfe41ec4f/third_party/WebKit/Source/modules/gamepad/NavigatorGamepad.cpp
[modify] https://crrev.com/2f298a80296e8510f74632faa55e825cfe41ec4f/third_party/WebKit/Source/modules/gamepad/NavigatorGamepad.h
[modify] https://crrev.com/2f298a80296e8510f74632faa55e825cfe41ec4f/third_party/WebKit/public/BUILD.gn
[modify] https://crrev.com/2f298a80296e8510f74632faa55e825cfe41ec4f/third_party/WebKit/public/platform/Platform.h
[delete] https://crrev.com/130cfd0cd29bdf5edba20601b496749fd954688f/third_party/WebKit/public/platform/WebGamepad.h
[modify] https://crrev.com/2f298a80296e8510f74632faa55e825cfe41ec4f/third_party/WebKit/public/platform/WebGamepadListener.h
[delete] https://crrev.com/130cfd0cd29bdf5edba20601b496749fd954688f/third_party/WebKit/public/platform/WebGamepads.h

Comment 5 by juncai@chromium.org, Apr 18 2017

Status: Fixed (was: Started)

Comment 6 by blundell@chromium.org, Nov 7 2017

Components: Internals>Services>Device
►

Sign in to add a comment