Determine how to eliminate //content's browser_main_loop.cc needing to call directly into GamepadService |
||||||||
Issue descriptionTo host the Gamepad Mojo interfaces in the Device Service, the Device Service should also be responsible for shutting down the GamepadService for the appropriate time. That shutdown currently occurs in //content's browser_main_loop.cc, with a comment saying that that shutdown has to occur after the IO thread shuts down, which is in turn after the service manager and Device Service shut down. Given that comment, it's unclear how to move this shutdown into the Device Service.
,
Apr 4 2017
,
Apr 12 2017
,
Apr 18 2017
,
Apr 19 2017
Note that the approach we took in a similar case (https://codereview.chromium.org/2730333002) turns out to conflict with Lucky Luke's goal of removing MessageLoop::DestructionObserver (https://groups.google.com/a/chromium.org/forum/#!topic/services-dev/Y9FKZf9n1ls). However, we didn't come up with an alternative design while discussing this general problem (see that linked thread). Given this new information about Lucky Luke, the first question is: Can we eliminate GamepadService shutdown altogether?
,
May 31 2017
,
Nov 7 2017
,
Aug 1
|
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by blundell@chromium.org
, Mar 3 2017