New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 694986 link

Starred by 3 users

Issue metadata

Status: Verified
Owner:
Closed: Mar 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug-Regression



Sign in to add a comment

Page title fade effect not working

Reported by smoha...@etouch.net, Feb 22 2017

Issue description

Application Version: 58.0.3020.0
Android Build Number: 6.0.1/MOB30X
Device: Nexus 7

URL: http://timesofindia.indiatimes.com/world/china/sovereignty-first-jaishankar-sets-tone-before-strategic-talks-with-beijing/articleshow/57277503.cms

Steps to reproduce: 
1. Launch chrome> Open 3 more tabs (only to observe the issue clearly)
2. Open any website with large page title (example from snippets or use above URL)
3. Observe the page title 

Observed behavior:
Page title seems cropped 

Expected behavior:
Page title should fade away at the end 

Frequency:  
<5/5> 

Additional comments: 
1. Good Build: 57.0.2976.0, Bad Build: 57.0.2977.0
2. This issue is seen on Android devices ex. Nexus 7 (6.0.1/MOB30X), Nexus 9 (7.1.1/N4F26Q)

Bisect Range: https://chromium.googlesource.com/chromium/src/+log/57.0.2976.0..57.0.2977.0?pretty=fuller&n=10000
 

Comment 1 by smoha...@etouch.net, Feb 22 2017

Please find logs and video  @ http://go/chrome-androidlogs1/6/694986
Labels: M-58
Cannot provide bisect info as issue is not reproducible in the public build
Components: UI>Browser>Mobile
Components: UI>Browser>TabStrip
Labels: -Pri-3 ReleaseBlock-Stable Pri-2 Type-Bug-Regression
Owner: tedc...@chromium.org
Status: Available (was: Unconfirmed)
tedchoc@, Can you please help us in looking in to this bug, Thanks!
Cc: tedc...@chromium.org aelias@chromium.org
Owner: mdjones@chromium.org
I suspect this is the same as:
https://bugs.chromium.org/p/chromium/issues/detail?id=690111

To me, it seems like "something" broke with the fade logic, but I don't know where that could be.  Adding mdjones@ and aelias@ to glance at the regression range to see if anything jumps out.

Comment 6 by aelias@chromium.org, Feb 22 2017

Cc: mdjones@chromium.org
Labels: -Restrict-View-Google -M-58 M-57
Owner: ccameron@chromium.org
Status: Assigned (was: Available)
Summary: Page title fade effect not working (was: [Tablets]Page title seems cropped)
It does repro on chrome_public_apk, contrary to the claim on #2.  I exactly bisected to http://crrev.com/442359 "The great shader refactor: Merge all vertex shaders"

Comment 7 by aelias@chromium.org, Feb 22 2017

Cc: dtrainor@chromium.org
 Issue 690111  has been merged into this issue.

Comment 8 by aelias@chromium.org, Feb 22 2017

As I recall, this effect is implemented by creating a small UIResource for the right edge of the title text, and then using UIResourceLayer::SetVertexOpacity on it.

Comment 9 by aelias@chromium.org, Feb 23 2017

FWIW, it's DecorationTitle::layer_fade_.
Just a reminder that M57 Stable launch is coming very soon.  Since this is a release blocker, please get your fix in asap so it gets some soak time in Beta.  Thanks!
Thanks for the analysis! I'll check the vertex opacity source to see if I missed something.
Hmm, that patch has
-      v_alpha = opacity[int(a_index)]; 
And
+    SRC("v_alpha = opacity[quad_index];");

Oops. I'll put up a patch once I add a unit test.
Project Member

Comment 13 by bugdroid1@chromium.org, Mar 1 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8558df98469ef25bcd685bd9f9b0dc080ad2dc5b

commit 8558df98469ef25bcd685bd9f9b0dc080ad2dc5b
Author: ccameron <ccameron@chromium.org>
Date: Wed Mar 01 06:31:11 2017

cc: Fix vertex opacity shaders

Fix a typo that indexed by quad, not vertex.

Add a pixel test to prevent regressions.

BUG= 694986 
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2724563003
Cr-Commit-Position: refs/heads/master@{#453865}

[modify] https://crrev.com/8558df98469ef25bcd685bd9f9b0dc080ad2dc5b/cc/output/renderer_pixeltest.cc
[modify] https://crrev.com/8558df98469ef25bcd685bd9f9b0dc080ad2dc5b/cc/output/shader.cc
[add] https://crrev.com/8558df98469ef25bcd685bd9f9b0dc080ad2dc5b/cc/test/data/green_alpha_vertex_opacity.png

Labels: Merge-Request-57
Project Member

Comment 15 by sheriffbot@chromium.org, Mar 1 2017

Labels: -Merge-Request-57 Hotlist-Merge-Approved Merge-Approved-57
Your change meets the bar and is auto-approved for M57. Please go ahead and merge the CL to branch 2987 manually. Please contact milestone owner if you have questions.
Owners: amineer@(clank), cmasso@(bling), ketakid@(cros), govind@(desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
M57 Stable launch is VERY soon.  Since this is a release blocker, please get your fix merged into the release branch (2987) ASAP.  Thanks!
Project Member

Comment 17 by bugdroid1@chromium.org, Mar 2 2017

Labels: -merge-approved-57 merge-merged-2987
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/10c39d4c0e6e423f01b86ef69b5966dea4e3c682

commit 10c39d4c0e6e423f01b86ef69b5966dea4e3c682
Author: Christopher Cameron <ccameron@chromium.org>
Date: Thu Mar 02 19:45:26 2017

cc: Fix vertex opacity shaders

Fix a typo that indexed by quad, not vertex.

Add a pixel test to prevent regressions.

BUG= 694986 
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2724563003
Cr-Commit-Position: refs/heads/master@{#453865}
(cherry picked from commit 8558df98469ef25bcd685bd9f9b0dc080ad2dc5b)

Review-Url: https://codereview.chromium.org/2724183003 .
Cr-Commit-Position: refs/branch-heads/2987@{#740}
Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943}

[modify] https://crrev.com/10c39d4c0e6e423f01b86ef69b5966dea4e3c682/cc/output/renderer_pixeltest.cc
[modify] https://crrev.com/10c39d4c0e6e423f01b86ef69b5966dea4e3c682/cc/output/shader.cc
[add] https://crrev.com/10c39d4c0e6e423f01b86ef69b5966dea4e3c682/cc/test/data/green_alpha_vertex_opacity.png

Status: Fixed (was: Assigned)
This issue is fixed on latest M57-57.0.2987.91 and M58-58.0.3028.4 
Status: Verified (was: Fixed)

Sign in to add a comment