New issue
Advanced search Search tips

Issue 694958 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Aug 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

http/tests/navigation/same-and-different-back.html fails with --stable-release-mode flag

Project Member Reported by tyoshino@chromium.org, Feb 22 2017

Issue description

I've enabled a virtual test for http/tests/navigation for  bug 490015 . I marked it as skipped since it failed. But this should be investigated as a separate issue. Creating one here. Maybe it should just work with the flag.

 
Project Member

Comment 1 by bugdroid1@chromium.org, Feb 23 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8a75af1cd30519bd7205f0d9129eb8db8f29c48d

commit 8a75af1cd30519bd7205f0d9129eb8db8f29c48d
Author: tyoshino <tyoshino@chromium.org>
Date: Thu Feb 23 05:39:20 2017

Move tests for sendBeacon to a separate dedicated directory for clearer ownership

Not only because of the ownership clarification, but it's just good to
have a better home for them since they're closer to XHR and Fetch API.
It's not so reasonable to place them in navigation/ just because they
belongs to window.navigator.

The virtual test virtual/stable/http/tests/navigation/ is kept for a
different reason.

Moved redirection-respond.php to http/tests/resources as it's not
specific to the tests under http/tests/navigation/

BUG= 682571 , 619662 , 490015 , 694958 

Review-Url: https://codereview.chromium.org/2702113003
Cr-Commit-Position: refs/heads/master@{#452408}

[modify] https://crrev.com/8a75af1cd30519bd7205f0d9129eb8db8f29c48d/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/8a75af1cd30519bd7205f0d9129eb8db8f29c48d/third_party/WebKit/LayoutTests/VirtualTestSuites
[delete] https://crrev.com/645ad78c4d429cda9591f9be1486b911d7076f59/third_party/WebKit/LayoutTests/http/tests/navigation/beacon-cross-origin-redirect-expected.txt
[modify] https://crrev.com/8a75af1cd30519bd7205f0d9129eb8db8f29c48d/third_party/WebKit/LayoutTests/http/tests/navigation/post-301-response.html
[modify] https://crrev.com/8a75af1cd30519bd7205f0d9129eb8db8f29c48d/third_party/WebKit/LayoutTests/http/tests/navigation/post-302-response.html
[modify] https://crrev.com/8a75af1cd30519bd7205f0d9129eb8db8f29c48d/third_party/WebKit/LayoutTests/http/tests/navigation/post-303-response.html
[modify] https://crrev.com/8a75af1cd30519bd7205f0d9129eb8db8f29c48d/third_party/WebKit/LayoutTests/http/tests/navigation/post-307-response.html
[rename] https://crrev.com/8a75af1cd30519bd7205f0d9129eb8db8f29c48d/third_party/WebKit/LayoutTests/http/tests/resources/redirection-response.php
[modify] https://crrev.com/8a75af1cd30519bd7205f0d9129eb8db8f29c48d/third_party/WebKit/LayoutTests/http/tests/security/contentSecurityPolicy/1.1/form-action-src-redirect-blocked.html
[modify] https://crrev.com/8a75af1cd30519bd7205f0d9129eb8db8f29c48d/third_party/WebKit/LayoutTests/http/tests/security/contentSecurityPolicy/connect-src-beacon-redirect-to-blocked-expected.txt
[modify] https://crrev.com/8a75af1cd30519bd7205f0d9129eb8db8f29c48d/third_party/WebKit/LayoutTests/http/tests/security/contentSecurityPolicy/connect-src-beacon-redirect-to-blocked.html
[rename] https://crrev.com/8a75af1cd30519bd7205f0d9129eb8db8f29c48d/third_party/WebKit/LayoutTests/http/tests/sendbeacon/beacon-allowance-expected.txt
[rename] https://crrev.com/8a75af1cd30519bd7205f0d9129eb8db8f29c48d/third_party/WebKit/LayoutTests/http/tests/sendbeacon/beacon-allowance.html
[rename] https://crrev.com/8a75af1cd30519bd7205f0d9129eb8db8f29c48d/third_party/WebKit/LayoutTests/http/tests/sendbeacon/beacon-blob-with-non-simple-type.html
[rename] https://crrev.com/8a75af1cd30519bd7205f0d9129eb8db8f29c48d/third_party/WebKit/LayoutTests/http/tests/sendbeacon/beacon-cookie-expected.txt
[rename] https://crrev.com/8a75af1cd30519bd7205f0d9129eb8db8f29c48d/third_party/WebKit/LayoutTests/http/tests/sendbeacon/beacon-cookie.html
[rename] https://crrev.com/8a75af1cd30519bd7205f0d9129eb8db8f29c48d/third_party/WebKit/LayoutTests/http/tests/sendbeacon/beacon-cross-origin-expected.txt
[rename] https://crrev.com/8a75af1cd30519bd7205f0d9129eb8db8f29c48d/third_party/WebKit/LayoutTests/http/tests/sendbeacon/beacon-cross-origin-redirect-blob.html
[rename] https://crrev.com/8a75af1cd30519bd7205f0d9129eb8db8f29c48d/third_party/WebKit/LayoutTests/http/tests/sendbeacon/beacon-cross-origin-redirect-credentials.html
[add] https://crrev.com/8a75af1cd30519bd7205f0d9129eb8db8f29c48d/third_party/WebKit/LayoutTests/http/tests/sendbeacon/beacon-cross-origin-redirect-expected.txt
[rename] https://crrev.com/8a75af1cd30519bd7205f0d9129eb8db8f29c48d/third_party/WebKit/LayoutTests/http/tests/sendbeacon/beacon-cross-origin-redirect.html
[rename] https://crrev.com/8a75af1cd30519bd7205f0d9129eb8db8f29c48d/third_party/WebKit/LayoutTests/http/tests/sendbeacon/beacon-cross-origin.html
[rename] https://crrev.com/8a75af1cd30519bd7205f0d9129eb8db8f29c48d/third_party/WebKit/LayoutTests/http/tests/sendbeacon/beacon-cross-origin.https-expected.txt
[rename] https://crrev.com/8a75af1cd30519bd7205f0d9129eb8db8f29c48d/third_party/WebKit/LayoutTests/http/tests/sendbeacon/beacon-cross-origin.https.html
[rename] https://crrev.com/8a75af1cd30519bd7205f0d9129eb8db8f29c48d/third_party/WebKit/LayoutTests/http/tests/sendbeacon/beacon-detached-no-crash-expected.txt
[rename] https://crrev.com/8a75af1cd30519bd7205f0d9129eb8db8f29c48d/third_party/WebKit/LayoutTests/http/tests/sendbeacon/beacon-detached-no-crash.html
[rename] https://crrev.com/8a75af1cd30519bd7205f0d9129eb8db8f29c48d/third_party/WebKit/LayoutTests/http/tests/sendbeacon/beacon-same-origin-expected.txt
[rename] https://crrev.com/8a75af1cd30519bd7205f0d9129eb8db8f29c48d/third_party/WebKit/LayoutTests/http/tests/sendbeacon/beacon-same-origin.html
[rename] https://crrev.com/8a75af1cd30519bd7205f0d9129eb8db8f29c48d/third_party/WebKit/LayoutTests/http/tests/sendbeacon/resources/check-beacon.php
[rename] https://crrev.com/8a75af1cd30519bd7205f0d9129eb8db8f29c48d/third_party/WebKit/LayoutTests/http/tests/sendbeacon/resources/save-beacon.php
[modify] https://crrev.com/8a75af1cd30519bd7205f0d9129eb8db8f29c48d/third_party/WebKit/LayoutTests/virtual/stable/http/tests/navigation/README.txt
[delete] https://crrev.com/645ad78c4d429cda9591f9be1486b911d7076f59/third_party/WebKit/LayoutTests/virtual/stable/http/tests/navigation/beacon-cross-origin-redirect-blob-expected.txt
[add] https://crrev.com/8a75af1cd30519bd7205f0d9129eb8db8f29c48d/third_party/WebKit/LayoutTests/virtual/stable/http/tests/sendbeacon/README.txt
[add] https://crrev.com/8a75af1cd30519bd7205f0d9129eb8db8f29c48d/third_party/WebKit/LayoutTests/virtual/stable/http/tests/sendbeacon/beacon-cross-origin-redirect-blob-expected.txt

Updated the bug number in TestExpectations to this issue by the commit in #1.
Project Member

Comment 3 by bugdroid1@chromium.org, Aug 2 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5bc5e0f35461d948578a7d924b5bb387fa15d711

commit 5bc5e0f35461d948578a7d924b5bb387fa15d711
Author: Nate Chapin <japhet@chromium.org>
Date: Wed Aug 02 03:34:32 2017

Unskip virtual/stable/http/tests/navigation/same-and-different-back.html

It appears to be passing reliably.

BUG= 694958 

Change-Id: I8ae576736fd59835cfcac787c52aa864a2b96625
Reviewed-on: https://chromium-review.googlesource.com/596414
Commit-Queue: Takeshi Yoshino <tyoshino@chromium.org>
Reviewed-by: Takeshi Yoshino <tyoshino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491251}
[modify] https://crrev.com/5bc5e0f35461d948578a7d924b5bb387fa15d711/third_party/WebKit/LayoutTests/TestExpectations

Status: Fixed (was: Assigned)
Just reenabled.

Sign in to add a comment