Record UMA metrics for FaviconDriver/FaviconService |
||||||
Issue descriptiongo/uma-metrics-for-favicons Metrics can help us understand the availability of icons and what icons are frequently requested. For that purpose, a good start would be to measure ... ... the resolution clients asks for ("desired_size") ... sizes of candidate lists (generally, specified sizes, touch icons) ... cases of missing or corrupt icons* ... cases of icon size being inconsistent with real size* ... number of fetching attempts* * all of those could be processed as a "favicon rank" (This bug includes only metrics that are immediately useful for M-58. Later, metrics can include data about cached icons and access to those.)
,
Mar 14 2017
,
Apr 19 2017
Merge Request for these two CLs: Issue 2781093002: Add attempt count metric to FaviconHandler Issue 2808063002: Add DownloadStatus metric to FaviconHandler They add two more metrics (and no user visible changes). Unfortunately, the linked bug number was incorrect which is why they don't appear here.
,
Apr 19 2017
Copy of commit note: The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a9fb2c3cf6bc9b4877d9c21f9f12094fb5c26ecd commit a9fb2c3cf6bc9b4877d9c21f9f12094fb5c26ecd Author: fhorschig <fhorschig@chromium.org> Date: Wed Apr 19 08:02:36 2017 Add attempt count metric to FaviconHandler The histograms this metric introduces aggregates how many download attempts were needed to determine the best-fitting favicon. This is stored in two metrics in order to separate requests for large icons. BUG= 672939 Review-Url: https://codereview.chromium.org/2781093002 Cr-Commit-Position: refs/heads/master@{#465526} [modify] https://crrev.com/a9fb2c3cf6bc9b4877d9c21f9f12094fb5c26ecd/components/favicon/core/favicon_handler.cc [modify] https://crrev.com/a9fb2c3cf6bc9b4877d9c21f9f12094fb5c26ecd/components/favicon/core/favicon_handler.h [modify] https://crrev.com/a9fb2c3cf6bc9b4877d9c21f9f12094fb5c26ecd/components/favicon/core/favicon_handler_unittest.cc [modify] https://crrev.com/a9fb2c3cf6bc9b4877d9c21f9f12094fb5c26ecd/tools/metrics/histograms/histograms.xml
,
Apr 19 2017
Copy of commit note: The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/be0a6071e24bc1e0f432533042d3d813bbe6ed3f commit be0a6071e24bc1e0f432533042d3d813bbe6ed3f Author: fhorschig <fhorschig@chromium.org> Date: Wed Apr 19 10:17:16 2017 Add DownloadStatus metric to FaviconHandler This metric records how often single icon downloads fail with 404 and how often 404'ing icons can be skipped because they were already known. BUG= 672939 Review-Url: https://codereview.chromium.org/2808063002 Cr-Commit-Position: refs/heads/master@{#465545} [modify] https://crrev.com/be0a6071e24bc1e0f432533042d3d813bbe6ed3f/components/favicon/core/favicon_handler.cc [modify] https://crrev.com/be0a6071e24bc1e0f432533042d3d813bbe6ed3f/components/favicon/core/favicon_handler.h [modify] https://crrev.com/be0a6071e24bc1e0f432533042d3d813bbe6ed3f/components/favicon/core/favicon_handler_unittest.cc [modify] https://crrev.com/be0a6071e24bc1e0f432533042d3d813bbe6ed3f/tools/metrics/histograms/histograms.xml
,
Apr 19 2017
Your change meets the bar and is auto-approved for M59. Please go ahead and merge the CL to branch 3071 manually. Please contact milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), gkihumba@(ChromeOS), Abdul Syed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Apr 24 2017
Copy of merge note: The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/29f35e1cdef86ccb133616795b0845130d2cad86 commit 29f35e1cdef86ccb133616795b0845130d2cad86 Author: Vitalii Iarko <vitaliii@chromium.org> Date: Mon Apr 24 08:22:44 2017 Merge of "Add attempt count metric to FaviconHandler" into M59. This is a merge of https://codereview.chromium.org/2781093002 into M59 (3071). Done on behalf of fhorschig@. Reason: recording metrics in M59 (and not waiting for M60). === Original description === The histograms this metric introduces aggregates how many download attempts were needed to determine the best-fitting favicon. This is stored in two metrics in order to separate requests for large icons. BUG= 672939 Review-Url: https://codereview.chromium.org/2781093002 Cr-Commit-Position: refs/heads/master@{#465526} (cherry picked from commit a9fb2c3cf6bc9b4877d9c21f9f12094fb5c26ecd) Review-Url: https://codereview.chromium.org/2839573002 . Cr-Commit-Position: refs/branch-heads/3071@{#157} Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641} [modify] https://crrev.com/29f35e1cdef86ccb133616795b0845130d2cad86/components/favicon/core/favicon_handler.cc [modify] https://crrev.com/29f35e1cdef86ccb133616795b0845130d2cad86/components/favicon/core/favicon_handler.h [modify] https://crrev.com/29f35e1cdef86ccb133616795b0845130d2cad86/components/favicon/core/favicon_handler_unittest.cc [modify] https://crrev.com/29f35e1cdef86ccb133616795b0845130d2cad86/tools/metrics/histograms/histograms.xml
,
Apr 24 2017
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible! If all merges have been completed, please remove any remaining Merge-Approved labels from this issue. Thanks for your time! To disable nags, add the Disable-Nags label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Apr 25 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a35ca902cc2840eaaab3715060a4a17f91d486c8 commit a35ca902cc2840eaaab3715060a4a17f91d486c8 Author: Friedrich Horschig <fhorschig@chromium.org> Date: Tue Apr 25 07:49:20 2017 Merge of "Add DownloadStatus metric to FaviconHandler" into M59 This is a merge of https://codereview.chromium.org/2808063002/ into M59. Reason: recording metrics in M59 (and not waiting for M60). === Original description === Add DownloadStatus metric to FaviconHandler This metric records how often single icon downloads fail with 404 and how often 404'ing icons can be skipped because they were already known. BUG= 672939 Review-Url: https://codereview.chromium.org/2808063002 Cr-Commit-Position: refs/heads/master@{#465545} (cherry picked from commit be0a6071e24bc1e0f432533042d3d813bbe6ed3f) Review-Url: https://codereview.chromium.org/2843703002 . Cr-Commit-Position: refs/branch-heads/3071@{#193} Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641} [modify] https://crrev.com/a35ca902cc2840eaaab3715060a4a17f91d486c8/components/favicon/core/favicon_handler.cc [modify] https://crrev.com/a35ca902cc2840eaaab3715060a4a17f91d486c8/components/favicon/core/favicon_handler.h [modify] https://crrev.com/a35ca902cc2840eaaab3715060a4a17f91d486c8/components/favicon/core/favicon_handler_unittest.cc [modify] https://crrev.com/a35ca902cc2840eaaab3715060a4a17f91d486c8/tools/metrics/histograms/histograms.xml |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by bugdroid1@chromium.org
, Mar 2 2017