New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 694943 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner: ----
Closed: Feb 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

consider renaming the "blame" layer to "annotate" in code search

Project Member Reported by jochen@chromium.org, Feb 22 2017

Issue description

The commands are idempotent, however, annotate is less accusatory, so why not just use that?
 

Comment 1 by emso@chromium.org, Feb 22 2017

Status: Available (was: Untriaged)
I agree with that point. However, the use of blame does connect the functionality provided to that one would expect when using git blame on the command line. 

Comment 2 by jochen@chromium.org, Feb 22 2017

Well, and so there is git annotate...

Comment 3 by emso@chromium.org, Feb 22 2017

Yes, true, but isn't that more of a legacy command and blame is the command commonly used? Not that that would be a blocker. Mostly thinking about user expectation. 

Also, we are sharing this layer with internal instances and we would have to investigate how to separate the layer names. Not a blocker I think, but this would have to be solved.  
Status: WontFix (was: Available)
I really don't think this is worth fixing.  "blame" is a commonly used term and isn't accusatory in context.

Sign in to add a comment