New issue
Advanced search Search tips

Issue 694941 link

Starred by 4 users

Issue metadata

Status: Verified
Owner:
Closed: Feb 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

ShelfAppBrowserTest.MatchingShelfIDandActiveTab is super flaky

Project Member Reported by dcheng@chromium.org, Feb 22 2017

Issue description

Project Member

Comment 1 by bugdroid1@chromium.org, Feb 22 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/813f80ebbcf52c45108ee09c8b682d8af502017e

commit 813f80ebbcf52c45108ee09c8b682d8af502017e
Author: dcheng <dcheng@chromium.org>
Date: Wed Feb 22 10:05:33 2017

Disable flaky test ShelfAppBrowserTest.MatchingShelfIDandActiveTab

BUG= 694941 
TBR=skuhne@chromium.org

Review-Url: https://codereview.chromium.org/2709483008
Cr-Commit-Position: refs/heads/master@{#451965}

[modify] https://crrev.com/813f80ebbcf52c45108ee09c8b682d8af502017e/chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl_browsertest.cc

Comment 2 by fdoray@chromium.org, Feb 22 2017

 Issue 694101  has been merged into this issue.
Cc: jamescook@chromium.org
Labels: Proj-Mustash-Mash
Owner: msw@chromium.org
msw, maybe related to recent mojo-ification of shelf and/or shelf vs. app ids?

Project Member

Comment 4 by bugdroid1@chromium.org, Feb 28 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8efedb10c4620871e01944c79c294be9ef04db07

commit 8efedb10c4620871e01944c79c294be9ef04db07
Author: msw <msw@chromium.org>
Date: Tue Feb 28 02:31:26 2017

Fix browser window shelf id init; re-enable browser test.

Initialize browser window shelf ids on shortcut creation.
This was only happening on page load, etc. (after shortcut creation).

Re-enable ShelfAppBrowserTest.MatchingShelfIDandActiveTab.
I'm not sure what caused/exacerbated the recent flakiness.

BUG= 694941 
TEST=Automated; no behavior changes.
R=jamescook@chromium.org

Review-Url: https://codereview.chromium.org/2719233002
Cr-Commit-Position: refs/heads/master@{#453469}

[modify] https://crrev.com/8efedb10c4620871e01944c79c294be9ef04db07/chrome/browser/ui/ash/launcher/browser_shortcut_launcher_item_controller.cc
[modify] https://crrev.com/8efedb10c4620871e01944c79c294be9ef04db07/chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl_browsertest.cc

Comment 5 by msw@chromium.org, Feb 28 2017

Status: Fixed (was: Assigned)
Labels: mash

Comment 7 by dchan@google.com, Apr 17 2017

Labels: VerifyIn-59
Labels: code-change
Status: Verified (was: Fixed)
Components: Tests>Disabled
Labels: Test-Disabled

Sign in to add a comment